2010-04-21 00:01:05

by Frederic Weisbecker

Subject: [PATCH] perf: Fix perf probe build error

When we run into dry run mode, we want to make write_kprobe_trace_event
to succeed on writing the event. Let's initialize it to 0.

Fixes the following build error:
util/probe-event.c:1266: attention : «ret» may be used uninitialized in this function
util/probe-event.c:1266: note: «ret» was declared here

Signed-off-by: Frederic Weisbecker <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Paul Mackerras <[email protected]>
---
tools/perf/util/probe-event.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 3967f8f..4fb4803 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -1263,7 +1263,7 @@ static struct strlist *get_kprobe_trace_event_names(int fd, bool include_group)

static int write_kprobe_trace_event(int fd, struct kprobe_trace_event *tev)
{
- int ret;
+ int ret = 0;
char *buf = synthesize_kprobe_trace_command(tev);

if (!buf) {
--
1.6.2.3

2010-04-21 00:03:13

by Masami Hiramatsu

Subject: Re: [PATCH] perf: Fix perf probe build error

Frederic Weisbecker wrote:
> When we run into dry run mode, we want to make write_kprobe_trace_event
> to succeed on writing the event. Let's initialize it to 0.
>
> Fixes the following build error:
> util/probe-event.c:1266: attention : «ret» may be used uninitialized in this function
> util/probe-event.c:1266: note: «ret» was declared here
>
> Signed-off-by: Frederic Weisbecker <[email protected]>
> Cc: Arnaldo Carvalho de Melo <[email protected]>
> Cc: Masami Hiramatsu <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Paul Mackerras <[email protected]>

Acked-by: Masami Hiramatsu <[email protected]>

Thanks! that's what I've found today...

> ---
> tools/perf/util/probe-event.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 3967f8f..4fb4803 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -1263,7 +1263,7 @@ static struct strlist *get_kprobe_trace_event_names(int fd, bool include_group)
>
> static int write_kprobe_trace_event(int fd, struct kprobe_trace_event *tev)
> {
> - int ret;
> + int ret = 0;
> char *buf = synthesize_kprobe_trace_command(tev);
>
> if (!buf) {

--
Masami Hiramatsu
e-mail: [email protected]