Micha? Miros?aw wrote:
> Thanks for your review!
>
> On Fri, May 28, 2010 at 02:40:27PM -0700, Andrew Morton wrote:
>> On Tue, 25 May 2010 18:10:28 +0200 (CEST)
>> Micha__ Miros__aw <[email protected]> wrote:
>>> This is needed to avoid code duplication in SD-combo support.
>> hm. Perhaps you could have told us a bit more about it than this.
>>> +int mmc_sd_get_cid(struct mmc_host *host, u32 ocr, u32 *cid)
>>> +int mmc_sd_get_csd(struct mmc_host *host, struct mmc_card *card)
>>> +int mmc_sd_setup_card(struct mmc_host *host, struct mmc_card *card,
>>> +unsigned mmc_sd_get_max_clock(struct mmc_card *card)
>>> +void mmc_sd_go_highspeed(struct mmc_card *card)
>> These are global symbols, but they are not exported to (other) modules.
>> That's odd. I'd have expected to see them either `static' or
>> EXPORT_MODULE()d.
>
> This is all contained in mmc_core.ko and needs not be exported to other
> modules. A SD-combo card is a SD (memory) and SDIO in one package - the
> only changes needed are in initialization sequence, after which both
> parts are mostly independent.
That is a bit vague. An SD card is a memory. An SDIO "card" is an
I/O connection made using the same physical interface as an SD card
and a very similar protocal to SD cards (at least with respect to
reading and writing). I do not understand how a card can be SD and
SDIO. Are you sure you are not talking about a controller that supports
SD and SDIO? A lot of controllers do that.
>
>> I'll take the lack of a signed-off-by: and the "RFC" as signal to not
>> apply these patches.
>
> I would like for this to get tested by other people first, but it looks
> like not many kernel developers use SD combo cards.
>
> I'll resend the patches after applying your suggestions from the other
> mail.
>
> Best Regards,
> Micha? Miros?aw
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Hi,
> That is a bit vague. An SD card is a memory. An SDIO "card" is
> an I/O connection made using the same physical interface as an SD
> card and a very similar protocal to SD cards (at least with
> respect to reading and writing). I do not understand how a card
> can be SD and SDIO. Are you sure you are not talking about a
> controller that supports SD and SDIO? A lot of controllers do
> that.
Adrian, I presume we're talking about something like:
http://www.arasan.com/products/sd/SD-Combo-Flyer.pdf
Michał, could you let us know which SD-combo device(s) in particular
you've been working with?
- Chris.
--
Chris Ball <[email protected]>
One Laptop Per Child
On Thu, Jun 03, 2010 at 01:21:23PM -0400, Chris Ball wrote:
> > That is a bit vague. An SD card is a memory. An SDIO "card" is
> > an I/O connection made using the same physical interface as an SD
> > card and a very similar protocal to SD cards (at least with
> > respect to reading and writing). I do not understand how a card
> > can be SD and SDIO. Are you sure you are not talking about a
> > controller that supports SD and SDIO? A lot of controllers do
> > that.
> Adrian, I presume we're talking about something like:
> http://www.arasan.com/products/sd/SD-Combo-Flyer.pdf
> Micha?, could you let us know which SD-combo device(s) in particular
> you've been working with?
The card I'm using is one I'm working on (SDIO-like card interoperating
with optional SD memory card) and I can't disclose what it really is nor
when it will be available.
Spectec SDG-810 (GPS with micro-SD slot) looks like a similar SD-combo card.
Answering Adrian's question: SDIO uses separate command set (CMD5 for
init, CMD52 and CMD53 for IO transactions) than SD memory and so the
parts can coexist in one card (provided some additional constraints are
met). The SDIO specification covers the details.
Best Regards,
Micha? Miros?aw