2010-06-04 10:25:44

by Wan ZongShun

Subject: [PATCH] lib: fix a memory leak risk

The netlink_kernel_create failed will arouse memory leak,
this patch is to add the 'kfree(ue_sk)' here.

Signed-off-by: Wan ZongShun <[email protected]>

---
lib/kobject_uevent.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 59c1551..08e15f7 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -378,6 +378,7 @@ static int uevent_net_init(struct net *net)
if (!ue_sk->sk) {
printk(KERN_ERR
"kobject_uevent: unable to create netlink socket!\n");
+ kfree(ue_sk);
return -ENODEV;
}
mutex_lock(&uevent_sock_mutex);
--
1.6.3.3

2010-06-04 15:29:14

by Greg KH

Subject: Re: [PATCH] lib: fix a memory leak risk

On Fri, Jun 04, 2010 at 06:25:28PM +0800, Wan ZongShun wrote:
> The netlink_kernel_create failed will arouse memory leak,
> this patch is to add the 'kfree(ue_sk)' here.
>
> Signed-off-by: Wan ZongShun <[email protected]>
>
> ---
> lib/kobject_uevent.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
> index 59c1551..08e15f7 100644
> --- a/lib/kobject_uevent.c
> +++ b/lib/kobject_uevent.c
> @@ -378,6 +378,7 @@ static int uevent_net_init(struct net *net)
> if (!ue_sk->sk) {
> printk(KERN_ERR
> "kobject_uevent: unable to create netlink socket!\n");
> + kfree(ue_sk);

Sorry, others already sent this patch in before you, it's already in the
linux-next tree, and is going to Linus later today.

thanks,

greg k-h