Update hid-ids.h to support new N-trig firmware.
Product id 0x02 - 0x0A
Signed-off-by: Micki Balanga <[email protected]>
---
---
drivers/hid/hid-core.c | 9 +++++++++
drivers/hid/hid-ids.h | 10 ++++++++++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index aa0f7dc..19f627a 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1337,6 +1337,15 @@ static const struct hid_device_id hid_blacklist[]
= {
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY,
USB_DEVICE_ID_GENIUS_KB29E) },
{ HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_1) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_2) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_3) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_4) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_5) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_6) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_7) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_8) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_9) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ORTEK,
USB_DEVICE_ID_ORTEK_WKB2000) },
{ HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX,
USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_QUANTA,
USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 6af77ed..55fbfd6 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -391,6 +391,16 @@
#define USB_VENDOR_ID_NTRIG 0x1b96
#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN 0x0001
+#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_1 0x0002
+#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_2 0x0003
+#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_3 0x0004
+#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_4 0x0005
+#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_5 0x0006
+#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_6 0x0007
+#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_7 0x0008
+#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_8 0x0009
+#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_9 0x000A
+
#define USB_VENDOR_ID_ONTRAK 0x0a07
#define USB_DEVICE_ID_ONTRAK_ADU100 0x0064
--
1.6.3.3
On Thu, 3 Jun 2010, Micki Balanga wrote:
> Update hid-ids.h to support new N-trig firmware.
> Product id 0x02 - 0x0A
[ adding Rafi Rubin to CC ]
Hi Micki,
thanks a lot for the update. Your mail client line-wrapped the patch
though, so I couldn't apply it without having to fix all the wrapped lines
manually. Could you please fix it and resend? (or send it as attachment if
your mail client can't be configured not to damage the patch if put
in-line)?
Thanks.
> Signed-off-by: Micki Balanga <[email protected]>
> ---
> ---
> drivers/hid/hid-core.c | 9 +++++++++
> drivers/hid/hid-ids.h | 10 ++++++++++
> 2 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index aa0f7dc..19f627a 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1337,6 +1337,15 @@ static const struct hid_device_id hid_blacklist[]
> = {
> { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
> USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) },
> { HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY,
> USB_DEVICE_ID_GENIUS_KB29E) },
> { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_1) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_2) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_3) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_4) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_5) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_6) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_7) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_8) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_9) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ORTEK,
> USB_DEVICE_ID_ORTEK_WKB2000) },
> { HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX,
> USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) },
> { HID_USB_DEVICE(USB_VENDOR_ID_QUANTA,
> USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH) },
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 6af77ed..55fbfd6 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -391,6 +391,16 @@
>
> #define USB_VENDOR_ID_NTRIG 0x1b96
> #define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN 0x0001
> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_1 0x0002
> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_2 0x0003
> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_3 0x0004
> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_4 0x0005
> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_5 0x0006
> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_6 0x0007
> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_7 0x0008
> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_8 0x0009
> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_9 0x000A
> +
>
> #define USB_VENDOR_ID_ONTRAK 0x0a07
> #define USB_DEVICE_ID_ONTRAK_ADU100 0x0064
> --
> 1.6.3.3
>
--
Jiri Kosina
SUSE Labs, Novell Inc.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/04/10 05:17, Jiri Kosina wrote:
> On Thu, 3 Jun 2010, Micki Balanga wrote:
>
>> Update hid-ids.h to support new N-trig firmware.
>> Product id 0x02 - 0x0A
>
> [ adding Rafi Rubin to CC ]
>
> Hi Micki,
>
> thanks a lot for the update. Your mail client line-wrapped the patch
> though, so I couldn't apply it without having to fix all the wrapped lines
> manually. Could you please fix it and resend? (or send it as attachment if
> your mail client can't be configured not to damage the patch if put
> in-line)?
>
> Thanks.
Micki: thanks for the heads up. Should we expect the behavior of the new
devices to remain consistent, or will they require adjustments?
Rafi
>> Signed-off-by: Micki Balanga <[email protected]>
>> ---
>> ---
>> drivers/hid/hid-core.c | 9 +++++++++
>> drivers/hid/hid-ids.h | 10 ++++++++++
>> 2 files changed, 19 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>> index aa0f7dc..19f627a 100644
>> --- a/drivers/hid/hid-core.c
>> +++ b/drivers/hid/hid-core.c
>> @@ -1337,6 +1337,15 @@ static const struct hid_device_id hid_blacklist[]
>> = {
>> { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
>> USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY,
>> USB_DEVICE_ID_GENIUS_KB29E) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_1) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_2) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_3) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_4) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_5) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_6) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_7) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_8) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_NTRIG,
>> USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_9) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_ORTEK,
>> USB_DEVICE_ID_ORTEK_WKB2000) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX,
>> USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_QUANTA,
>> USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH) },
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> index 6af77ed..55fbfd6 100644
>> --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -391,6 +391,16 @@
>>
>> #define USB_VENDOR_ID_NTRIG 0x1b96
>> #define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN 0x0001
>> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_1 0x0002
>> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_2 0x0003
>> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_3 0x0004
>> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_4 0x0005
>> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_5 0x0006
>> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_6 0x0007
>> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_7 0x0008
>> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_8 0x0009
>> +#define USB_DEVICE_ID_NTRIG_TOUCH_SCREEN_9 0x000A
>> +
>>
>> #define USB_VENDOR_ID_ONTRAK 0x0a07
>> #define USB_DEVICE_ID_ONTRAK_ADU100 0x0064
>> --
>> 1.6.3.3
>>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkwIzfMACgkQwuRiAT9o608fcQCg95rLIvR4hyKP+r6XRE/nJaY6
hKMAnRjmRUGXT32en4UVC1lb2hv6xlAp
=Tax4
-----END PGP SIGNATURE-----
On Fri, 4 Jun 2010, Micki Balanga wrote:
> Hi Jiri,
> Attach the patch via file.
> (Also fix 3 warning: please , no space before tabs)
Thanks Micki, I have applied the patch.
--
Jiri Kosina
SUSE Labs, Novell Inc.
Hi Jiri
We have some new product so I have to update the patch,
When I update my git branch I didn't see the changes regarding N-trig
Product id. If you can insert this patch, if there a problem with the
patch
Let me know and hi will update it
Thank you
Micki
-----Original Message-----
From: Jiri Kosina [mailto:[email protected]]
Sent: Saturday, June 05, 2010 6:42 PM
To: Micki Balanga
Cc: [email protected]; [email protected];
[email protected]; [email protected]; Rafi Rubin
Subject: RE: [PATCH] HID: Add support to new N-trig firwmare
On Fri, 4 Jun 2010, Micki Balanga wrote:
> Hi Jiri,
> Attach the patch via file.
> (Also fix 3 warning: please , no space before tabs)
Thanks Micki, I have applied the patch.
--
Jiri Kosina
SUSE Labs, Novell Inc.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/21/10 01:06, Micki Balanga wrote:
> Hi Jiri
> We have some new product so I have to update the patch,
> When I update my git branch I didn't see the changes regarding N-trig
> Product id. If you can insert this patch, if there a problem with the
> patch
> Let me know and hi will update it
> Thank you
> Micki
>
>
> -----Original Message-----
> From: Jiri Kosina [mailto:[email protected]]
> Sent: Saturday, June 05, 2010 6:42 PM
> To: Micki Balanga
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Rafi Rubin
> Subject: RE: [PATCH] HID: Add support to new N-trig firwmare
>
> On Fri, 4 Jun 2010, Micki Balanga wrote:
>
>> Hi Jiri,
>> Attach the patch via file.
>> (Also fix 3 warning: please , no space before tabs)
>
> Thanks Micki, I have applied the patch.
>
Micki, looks like there are a couple of accidental whitespace modifications:
- -#define USB_VENDOR_ID_ADS_TECH 0x06e1
+#define USB_VENDOR_ID_ADS_TECH 0x06e1
- -#define USB_VENDOR_ID_EZKEY 0x0518
+#define USB_VENDOR_ID_EZKEY 0x0518
Also, in the list of product ids, did you mean to skip 2?
Jiri, is there a better way than listing each device individually?
Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkwfA0UACgkQwuRiAT9o60+M9QCfQJcJ7pMo9TOY5vYgfK6Yq16d
nD8AoK+l5sVJKAUEpyYEEANnCFCNm/zr
=IFqR
-----END PGP SIGNATURE-----
Hi rafi
Thank for the remarks
Before submitting the patch I used checkpatch.pl script
And checked whitespace in the code I inserted.
Yes I aware there is no product id 0x002. (it's ok)
Micki
-----Original Message-----
From: Rafi Rubin [mailto:[email protected]]
Sent: Monday, June 21, 2010 9:15 AM
To: Micki Balanga
Cc: Jiri Kosina; [email protected]; [email protected];
[email protected]; [email protected]
Subject: Re: [PATCH] HID: Add support to new N-trig firwmare
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/21/10 01:06, Micki Balanga wrote:
> Hi Jiri
> We have some new product so I have to update the patch,
> When I update my git branch I didn't see the changes regarding N-trig
> Product id. If you can insert this patch, if there a problem with the
> patch
> Let me know and hi will update it
> Thank you
> Micki
>
>
> -----Original Message-----
> From: Jiri Kosina [mailto:[email protected]]
> Sent: Saturday, June 05, 2010 6:42 PM
> To: Micki Balanga
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Rafi Rubin
> Subject: RE: [PATCH] HID: Add support to new N-trig firwmare
>
> On Fri, 4 Jun 2010, Micki Balanga wrote:
>
>> Hi Jiri,
>> Attach the patch via file.
>> (Also fix 3 warning: please , no space before tabs)
>
> Thanks Micki, I have applied the patch.
>
Micki, looks like there are a couple of accidental whitespace
modifications:
- -#define USB_VENDOR_ID_ADS_TECH 0x06e1
+#define USB_VENDOR_ID_ADS_TECH 0x06e1
- -#define USB_VENDOR_ID_EZKEY 0x0518
+#define USB_VENDOR_ID_EZKEY 0x0518
Also, in the list of product ids, did you mean to skip 2?
Jiri, is there a better way than listing each device individually?
Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkwfA0UACgkQwuRiAT9o60+M9QCfQJcJ7pMo9TOY5vYgfK6Yq16d
nD8AoK+l5sVJKAUEpyYEEANnCFCNm/zr
=IFqR
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/21/10 02:39, Micki Balanga wrote:
> Hi rafi
> Thank for the remarks
> Before submitting the patch I used checkpatch.pl script
> And checked whitespace in the code I inserted.
I'm not saying anything in the patch is a style violation, just looks like you
changed two lines unintentionally.
Take a look at the patch itself, or try out "git difftool drivers/hid/hid-ids.h"
and look at the ADS_TECH and EZKEY lines.
> Yes I aware there is no product id 0x002. (it's ok)
Ok, just sanity checking.
> -----Original Message-----
> From: Rafi Rubin [mailto:[email protected]]
> Sent: Monday, June 21, 2010 9:15 AM
> To: Micki Balanga
> Cc: Jiri Kosina; [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH] HID: Add support to new N-trig firwmare
>
> On 06/21/10 01:06, Micki Balanga wrote:
>> Hi Jiri
>> We have some new product so I have to update the patch,
>> When I update my git branch I didn't see the changes regarding N-trig
>> Product id. If you can insert this patch, if there a problem with the
>> patch
>> Let me know and hi will update it
>> Thank you
>> Micki
>
>
>> -----Original Message-----
>> From: Jiri Kosina [mailto:[email protected]]
>> Sent: Saturday, June 05, 2010 6:42 PM
>> To: Micki Balanga
>> Cc: [email protected]; [email protected];
>> [email protected]; [email protected]; Rafi Rubin
>> Subject: RE: [PATCH] HID: Add support to new N-trig firwmare
>
>> On Fri, 4 Jun 2010, Micki Balanga wrote:
>
>>> Hi Jiri,
>>> Attach the patch via file.
>>> (Also fix 3 warning: please , no space before tabs)
>
>> Thanks Micki, I have applied the patch.
>
>
> Micki, looks like there are a couple of accidental whitespace
> modifications:
>
> -#define USB_VENDOR_ID_ADS_TECH 0x06e1
> +#define USB_VENDOR_ID_ADS_TECH 0x06e1
>
> -#define USB_VENDOR_ID_EZKEY 0x0518
> +#define USB_VENDOR_ID_EZKEY 0x0518
>
>
> Also, in the list of product ids, did you mean to skip 2?
>
>
> Jiri, is there a better way than listing each device individually?
>
>
> Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkwfGvkACgkQwuRiAT9o608vqACfZgAPtUYpEJHZMPwjGR/0u2l/
I/UAoNUrl8V75kFOBVmMCNRKIfnYB7Pk
=55Y2
-----END PGP SIGNATURE-----
On Mon, 21 Jun 2010, Micki Balanga wrote:
> We have some new product so I have to update the patch,
> When I update my git branch I didn't see the changes regarding N-trig
> Product id. If you can insert this patch, if there a problem with the
> patch
> Let me know and hi will update it
Hi Micki,
the patch seems incomplete -- it adds new entries to hid_blacklist[], but
doesn't update ntrig_devices[].
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
Hi Jiri,
Attach one file which update hid_blacklist.
Attach Second patch which update ntrig_devices.
Micki
-----Original Message-----
From: Jiri Kosina [mailto:[email protected]]
Sent: Monday, June 21, 2010 12:49 PM
To: Micki Balanga
Cc: [email protected]; [email protected];
[email protected]; [email protected]; Rafi Rubin
Subject: RE: [PATCH] HID: Add support to new N-trig firwmare
On Mon, 21 Jun 2010, Micki Balanga wrote:
> We have some new product so I have to update the patch,
> When I update my git branch I didn't see the changes regarding N-trig
> Product id. If you can insert this patch, if there a problem with the
> patch
> Let me know and hi will update it
Hi Micki,
the patch seems incomplete -- it adds new entries to hid_blacklist[],
but
doesn't update ntrig_devices[].
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
On Mon, 21 Jun 2010, Micki Balanga wrote:
> Attach one file which update hid_blacklist.
> Attach Second patch which update ntrig_devices.
I have folded the patches together, rebased them on top of the patch you
already sent me and I had in my tree (adding devices up od 0x0A), and
applied. Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
Hi
Thank you very much but the product id runs from 0x01 - 0x14(Not 0x0A)
(hid_blacklist, ntrig_devices - were updated till 0x14)
Micki
-----Original Message-----
From: Jiri Kosina [mailto:[email protected]]
Sent: Monday, June 21, 2010 2:44 PM
To: Micki Balanga
Cc: [email protected]; [email protected];
[email protected]; [email protected]; Rafi Rubin
Subject: RE: [PATCH] HID: Add support to new N-trig firwmare
On Mon, 21 Jun 2010, Micki Balanga wrote:
> Attach one file which update hid_blacklist.
> Attach Second patch which update ntrig_devices.
I have folded the patches together, rebased them on top of the patch you
already sent me and I had in my tree (adding devices up od 0x0A), and
applied. Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
On Mon, 21 Jun 2010, Micki Balanga wrote:
> Thank you very much but the product id runs from 0x01 - 0x14(Not 0x0A)
> (hid_blacklist, ntrig_devices - were updated till 0x14)
Yes, but you already sent me patch adding device ids up to 0x0a, and that
has already been in my tree.
--
Jiri Kosina
SUSE Labs, Novell Inc.