2010-06-21 21:07:09

by Ky Srinivasan

Subject: [PATCH] Hyperv: Export the symbol that tracks hyperv features and recommendations

From: K. Y. Srinivasan <[email protected]>
Subject: Export the symbol for hyperv drivers to access hyperv
features and recommendations. This patch is needed by the hyperV clocksource driver.

Signed-off-by: K. Y. Srinivasan <[email protected]>

Index: linux.trees.git/arch/x86/kernel/cpu/mshyperv.c
===================================================================
--- linux.trees.git.orig/arch/x86/kernel/cpu/mshyperv.c 2010-05-18 10:14:02.000000000 -0600
+++ linux.trees.git/arch/x86/kernel/cpu/mshyperv.c 2010-05-18 14:12:11.000000000 -0600
@@ -18,6 +18,7 @@
#include <asm/mshyperv.h>

struct ms_hyperv_info ms_hyperv;
+EXPORT_SYMBOL(ms_hyperv);

static bool __init ms_hyperv_platform(void)
{

2010-06-21 21:14:54

by Greg KH

Subject: Re: [PATCH] Hyperv: Export the symbol that tracks hyperv features and recommendations

On Mon, Jun 21, 2010 at 03:07:02PM -0600, Ky Srinivasan wrote:
>
>
> From: K. Y. Srinivasan <[email protected]>
> Subject: Export the symbol for hyperv drivers to access hyperv
> features and recommendations. This patch is needed by the hyperV clocksource driver.
>
> Signed-off-by: K. Y. Srinivasan <[email protected]>
>
> Index: linux.trees.git/arch/x86/kernel/cpu/mshyperv.c
> ===================================================================
> --- linux.trees.git.orig/arch/x86/kernel/cpu/mshyperv.c 2010-05-18 10:14:02.000000000 -0600
> +++ linux.trees.git/arch/x86/kernel/cpu/mshyperv.c 2010-05-18 14:12:11.000000000 -0600
> @@ -18,6 +18,7 @@
> #include <asm/mshyperv.h>
>
> struct ms_hyperv_info ms_hyperv;
> +EXPORT_SYMBOL(ms_hyperv);

EXPORT_SYMBOL_GPL()? Didn't you have it that way in your previous
patch?

thanks,

greg k-h

2010-06-22 14:36:16

by Ky Srinivasan

Subject: Re: [PATCH] Hyperv: Export the symbol that tracks hyperv features and recommendations

>>> On 6/21/2010 at 5:13 PM, in message <[email protected]>, Greg
KH <[email protected]> wrote:
> On Mon, Jun 21, 2010 at 03:07:02PM -0600, Ky Srinivasan wrote:
>>
>>
>> From: K. Y. Srinivasan <[email protected]>
>> Subject: Export the symbol for hyperv drivers to access hyperv
>> features and recommendations. This patch is needed by the hyperV clocksource
> driver.
>>
>> Signed-off-by: K. Y. Srinivasan <[email protected]>
>>
>> Index: linux.trees.git/arch/x86/kernel/cpu/mshyperv.c
>> ===================================================================
>> --- linux.trees.git.orig/arch/x86/kernel/cpu/mshyperv.c 2010-05-18
> 10:14:02.000000000 -0600
>> +++ linux.trees.git/arch/x86/kernel/cpu/mshyperv.c 2010-05-18
> 14:12:11.000000000 -0600
>> @@ -18,6 +18,7 @@
>> #include <asm/mshyperv.h>
>>
>> struct ms_hyperv_info ms_hyperv;
>> +EXPORT_SYMBOL(ms_hyperv);
>
> EXPORT_SYMBOL_GPL()? Didn't you have it that way in your previous
> patch?
I don't recall now. I agree with you that making it a GPL export makes sense.

Regards,

K. Y
>
> thanks,
>
> greg k-h