2010-07-08 02:08:43

by Axel Lin

Subject: [PATCH] msi-laptop: make struct rfkill_ops const

rfkill uses a const struct rfkill_ops pointer.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/platform/x86/msi-laptop.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
index afd762b..05634f8 100644
--- a/drivers/platform/x86/msi-laptop.c
+++ b/drivers/platform/x86/msi-laptop.c
@@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
return 0;
}

-static struct rfkill_ops rfkill_bluetooth_ops = {
+static const struct rfkill_ops rfkill_bluetooth_ops = {
.set_block = rfkill_bluetooth_set
};

-static struct rfkill_ops rfkill_wlan_ops = {
+static const struct rfkill_ops rfkill_wlan_ops = {
.set_block = rfkill_wlan_set
};

-static struct rfkill_ops rfkill_threeg_ops = {
+static const struct rfkill_ops rfkill_threeg_ops = {
.set_block = rfkill_threeg_set
};

--
1.5.4.3

2010-07-08 18:13:24

by Joey Lee

Subject: Re: [PATCH] msi-laptop: make struct rfkill_ops const

Hi Axel,

於 四，2010-07-08 於 10:08 +0800，Axel Lin 提到：
> rfkill uses a const struct rfkill_ops pointer.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/platform/x86/msi-laptop.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> index afd762b..05634f8 100644
> --- a/drivers/platform/x86/msi-laptop.c
> +++ b/drivers/platform/x86/msi-laptop.c
> @@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
> return 0;
> }
>
> -static struct rfkill_ops rfkill_bluetooth_ops = {
> +static const struct rfkill_ops rfkill_bluetooth_ops = {
> .set_block = rfkill_bluetooth_set
> };
>
> -static struct rfkill_ops rfkill_wlan_ops = {
> +static const struct rfkill_ops rfkill_wlan_ops = {
> .set_block = rfkill_wlan_set
> };
>
> -static struct rfkill_ops rfkill_threeg_ops = {
> +static const struct rfkill_ops rfkill_threeg_ops = {
> .set_block = rfkill_threeg_set
> };
>

The patch good to me, do I need Signed-off it?
How can I signed off a patch?


Thank's a lot!
Joey Lee

2010-07-08 18:43:00

by Greg KH

Subject: Re: [PATCH] msi-laptop: make struct rfkill_ops const

On Thu, Jul 08, 2010 at 11:53:15AM -0600, Joey Lee wrote:
> Hi Axel,
>
> 於 四，2010-07-08 於 10:08 +0800，Axel Lin 提到：
> > rfkill uses a const struct rfkill_ops pointer.
> >
> > Signed-off-by: Axel Lin <[email protected]>
> > ---
> > drivers/platform/x86/msi-laptop.c | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> > index afd762b..05634f8 100644
> > --- a/drivers/platform/x86/msi-laptop.c
> > +++ b/drivers/platform/x86/msi-laptop.c
> > @@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
> > return 0;
> > }
> >
> > -static struct rfkill_ops rfkill_bluetooth_ops = {
> > +static const struct rfkill_ops rfkill_bluetooth_ops = {
> > .set_block = rfkill_bluetooth_set
> > };
> >
> > -static struct rfkill_ops rfkill_wlan_ops = {
> > +static const struct rfkill_ops rfkill_wlan_ops = {
> > .set_block = rfkill_wlan_set
> > };
> >
> > -static struct rfkill_ops rfkill_threeg_ops = {
> > +static const struct rfkill_ops rfkill_threeg_ops = {
> > .set_block = rfkill_threeg_set
> > };
> >
>
> The patch good to me, do I need Signed-off it?
> How can I signed off a patch?

You can say:
Signed-off-by: your name <your_email>

and then Matthew will add it.

Or you can take the original patch, add your signed-off-by, and resend
it to Matthew keeping the correct authorship information there by making
sure the first line in the body of the email has:
From: Original author <email>

so git will get it right.

hope this helps,

greg k-h

2010-07-09 10:24:44

by Joey Lee

Subject: Re: [PATCH] msi-laptop: make struct rfkill_ops const

Hi Greg,

於 四，2010-07-08 於 11:39 -0700，Greg KH 提到：
> On Thu, Jul 08, 2010 at 11:53:15AM -0600, Joey Lee wrote:
> > Hi Axel,
> >
> > 於 四，2010-07-08 於 10:08 +0800，Axel Lin 提到：
> > > rfkill uses a const struct rfkill_ops pointer.
> > >
> > > Signed-off-by: Axel Lin <[email protected]>
> > > ---
> > > drivers/platform/x86/msi-laptop.c | 6 +++---
> > > 1 files changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> > > index afd762b..05634f8 100644
> > > --- a/drivers/platform/x86/msi-laptop.c
> > > +++ b/drivers/platform/x86/msi-laptop.c
> > > @@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
> > > return 0;
> > > }
> > >
> > > -static struct rfkill_ops rfkill_bluetooth_ops = {
> > > +static const struct rfkill_ops rfkill_bluetooth_ops = {
> > > .set_block = rfkill_bluetooth_set
> > > };
> > >
> > > -static struct rfkill_ops rfkill_wlan_ops = {
> > > +static const struct rfkill_ops rfkill_wlan_ops = {
> > > .set_block = rfkill_wlan_set
> > > };
> > >
> > > -static struct rfkill_ops rfkill_threeg_ops = {
> > > +static const struct rfkill_ops rfkill_threeg_ops = {
> > > .set_block = rfkill_threeg_set
> > > };
> > >
> >
> > The patch good to me, do I need Signed-off it?
> > How can I signed off a patch?
>
> You can say:
> Signed-off-by: your name <your_email>
>
> and then Matthew will add it.
>
> Or you can take the original patch, add your signed-off-by, and resend
> it to Matthew keeping the correct authorship information there by making
> sure the first line in the body of the email has:
> From: Original author <email>
>
> so git will get it right.
>
> hope this helps,

Thank's for your kindly teach, it's useful to a rookie. :-)

Joey Lee

2010-07-09 10:26:07

by Joey Lee

Subject: Re: [PATCH] msi-laptop: make struct rfkill_ops const

Hi Axel,

於 四，2010-07-08 於 10:08 +0800，Axel Lin 提到：
> rfkill uses a const struct rfkill_ops pointer.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/platform/x86/msi-laptop.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> index afd762b..05634f8 100644
> --- a/drivers/platform/x86/msi-laptop.c
> +++ b/drivers/platform/x86/msi-laptop.c
> @@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
> return 0;
> }
>
> -static struct rfkill_ops rfkill_bluetooth_ops = {
> +static const struct rfkill_ops rfkill_bluetooth_ops = {
> .set_block = rfkill_bluetooth_set
> };
>
> -static struct rfkill_ops rfkill_wlan_ops = {
> +static const struct rfkill_ops rfkill_wlan_ops = {
> .set_block = rfkill_wlan_set
> };
>
> -static struct rfkill_ops rfkill_threeg_ops = {
> +static const struct rfkill_ops rfkill_threeg_ops = {
> .set_block = rfkill_threeg_set
> };
>

The patch is good to me, thank's a lot!

Signed-off-by: Lee, Chun-Yi <[email protected]>


Joey Lee