2010-07-12 02:47:04

by Neal B

Subject: [PATCH 1/6] Mtd: fixed coding style indent errors

From f4301b9c13f65d173d67759d53acaf3e8d2331c6 Mon Sep 17 00:00:00 2001
From: Neal Buckendahl <[email protected]>
Date: Sun, 11 Jul 2010 16:58:24 -0500
Subject: [PATCH 1/6] Mtd: fixed coding style indent errors found by the
checkpatch.pl tool
Signed-off-by: Neal Buckendahl <[email protected]>

---
drivers/mtd/afs.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/afs.c b/drivers/mtd/afs.c
index cec7ab9..2bea681 100644
--- a/drivers/mtd/afs.c
+++ b/drivers/mtd/afs.c
@@ -162,8 +162,8 @@ afs_read_iis(struct mtd_info *mtd, struct
image_info_struct *iis, u_int ptr)
}

static int parse_afs_partitions(struct mtd_info *mtd,
- struct mtd_partition **pparts,
- unsigned long origin)
+ struct mtd_partition **pparts,
+ unsigned long origin)
{
struct mtd_partition *parts;
u_int mask, off, idx, sz;
--
1.7.1

2010-07-18 07:27:33

by Artem Bityutskiy

Subject: Re: [PATCH 1/6] Mtd: fixed coding style indent errors

On Sun, 2010-07-11 at 21:46 -0500, Neal B wrote:
> From f4301b9c13f65d173d67759d53acaf3e8d2331c6 Mon Sep 17 00:00:00 2001
> From: Neal Buckendahl <[email protected]>
> Date: Sun, 11 Jul 2010 16:58:24 -0500
> Subject: [PATCH 1/6] Mtd: fixed coding style indent errors found by the
> checkpatch.pl tool
> Signed-off-by: Neal Buckendahl <[email protected]>

Unfortunately, your patches are line-wrapped. You should send
non-wrapped patches. Use git send-email - it can do the trick (use
--dry-run first, check everything is fine, then send).

Also, int the commit message, it is a bit better to specify which
exactly warning it fixes.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)