2010-07-23 05:20:15

by Xiao Guangrong

Subject: [PATCH] KVM: MMU: fix hugepage mapping corrupt caused by regression

This is the regression, the bug which is fixed by commit e09e90a5
is active now

Signed-off-by: Xiao Guangrong <[email protected]>
---
arch/x86/kvm/paging_tmpl.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
index a09e04c..d9a2742 100644
--- a/arch/x86/kvm/paging_tmpl.h
+++ b/arch/x86/kvm/paging_tmpl.h
@@ -374,13 +374,13 @@ static u64 *FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr,
shadow_walk_next(&it)) {
gfn_t direct_gfn;

+ validate_direct_spte(vcpu, it.sptep, direct_access);
+
drop_large_spte(vcpu, it.sptep);

if (is_shadow_present_pte(*it.sptep))
continue;

- validate_direct_spte(vcpu, it.sptep, direct_access);
-
direct_gfn = gw->gfn & ~(KVM_PAGES_PER_HPAGE(it.level) - 1);

sp = kvm_mmu_get_page(vcpu, direct_gfn, addr, it.level-1,
--
1.6.1.2

2010-07-25 08:48:41

by Avi Kivity

Subject: Re: [PATCH] KVM: MMU: fix hugepage mapping corrupt caused by regression

On 07/23/2010 08:16 AM, Xiao Guangrong wrote:
> This is the regression, the bug which is fixed by commit e09e90a5
> is active now
>

Applied, thanks.

--
error compiling committee.c: too many arguments to function