2010-08-13 12:25:45

by Milan Broz

[permalink] [raw]
Subject: Re: Q. NFS, return value of close(2)

On 08/11/2010 07:06 PM, Trond Myklebust wrote:
>> commit e56f956a08a6227004cd9b7747df6a089dbb3594
>> Author: J. R. Okajima <[email protected]>
>> Date: Thu Aug 12 02:00:02 2010 +0900
>>
>> NFS: fix the return value of nfs_file_fsync()
>>
>> By the commit
>> af7fa16 2010-08-03 NFS: Fix up the fsync code
>> close(2) became returning the non-zero value even if it went well.
>> nfs_file_fsync() should return 0 when "status" is positive.
>>
>> Signed-off-by: J. R. Okajima <[email protected]>

Hi,

please can you send this patch to Linus' tree?
NFS is currently broken, so it will save time for people trying
to bisect the problem.

It breaks even elementary operation on nfs mounts
# cat a > b
cat: write error

Patch above from nfs-git fixed the problem for me
http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commitdiff;h=0702099bd86c33c2dcdbd3963433a61f3f503901

Thanks,
Milan
--
[email protected]