2010-08-19 05:00:15

by Sachin Sant

[permalink] [raw]
Subject: [s390] Build failure with latest 2.6.36-rc1 git (sys_execve)

Latest 2.6.36-rc1 git fails to build on a s390 with

arch/s390/kernel/process.c:272: error: conflicting types for 'sys_execve'
arch/s390/kernel/entry.h:45: error: previous declaration of 'sys_execve' was here
make[1]: *** [arch/s390/kernel/process.o] Error 1

This error was introduced via commit :

commit d7627467b7a8dd6944885290a03a07ceb28c10eb
Make do_execve() take a const filename pointer

I guess the corresponding definition of sys_execve()
in arch/s390/kernel/entry.h also needs an update.

Thanks
-Sachin

--

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------


2010-08-19 07:44:49

by Martin Schwidefsky

[permalink] [raw]
Subject: Re: [s390] Build failure with latest 2.6.36-rc1 git (sys_execve)

On Thu, 19 Aug 2010 10:30:06 +0530
Sachin Sant <[email protected]> wrote:

> Latest 2.6.36-rc1 git fails to build on a s390 with
>
> arch/s390/kernel/process.c:272: error: conflicting types for 'sys_execve'
> arch/s390/kernel/entry.h:45: error: previous declaration of 'sys_execve' was here
> make[1]: *** [arch/s390/kernel/process.o] Error 1
>
> This error was introduced via commit :
>
> commit d7627467b7a8dd6944885290a03a07ceb28c10eb
> Make do_execve() take a const filename pointer
>
> I guess the corresponding definition of sys_execve()
> in arch/s390/kernel/entry.h also needs an update.

Fix is uploaded to git390. Tomorrows -next tree should work again.


--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

2010-08-23 13:37:46

by Sachin Sant

[permalink] [raw]
Subject: Re: [s390] Build failure with latest 2.6.36-rc1 git (sys_execve)

Martin Schwidefsky wrote:
> On Thu, 19 Aug 2010 10:30:06 +0530
> Sachin Sant <[email protected]> wrote:
>
>
>> Latest 2.6.36-rc1 git fails to build on a s390 with
>>
>> arch/s390/kernel/process.c:272: error: conflicting types for 'sys_execve'
>> arch/s390/kernel/entry.h:45: error: previous declaration of 'sys_execve' was here
>> make[1]: *** [arch/s390/kernel/process.o] Error 1
>>
>> This error was introduced via commit :
>>
>> commit d7627467b7a8dd6944885290a03a07ceb28c10eb
>> Make do_execve() take a const filename pointer
>>
>> I guess the corresponding definition of sys_execve()
>> in arch/s390/kernel/entry.h also needs an update.
>>
>
> Fix is uploaded to git390. Tomorrows -next tree should work again.
>
The patch is still missing from Linus's tree.
2.6.36-rc2-git1 (9ee4747..) fails with the same error.

Thanks
-Sachin


--

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------