2010-08-18 00:41:14

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the libata tree

Hi Jeff,

After merging the libata tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/ata/libata-transport.c: In function 'ata_attach_transport':
drivers/ata/libata-transport.c:678: error: implicit declaration of function 'kzalloc'
drivers/ata/libata-transport.c:678: warning: assignment makes pointer from integer without a cast
drivers/ata/libata-transport.c: In function 'ata_release_transport':
drivers/ata/libata-transport.c:741: error: implicit declaration of function 'kfree'

Caused by commit 97395d39931160a171959ac2e1fbff1caba3374b ("[libata] Add
ATA transport class") neglecting to include linux/slab.h. See Rule 1 in
Documentation/SubmitChecklist.

I have used the libata tree form next-20100817 for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

Attachments:
(No filename) (857.00 B)
 (No filename) (490.00 B)
 Download all attachments

2010-08-18 00:46:16

by Gwendal Grignou

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the libata tree

Let me fix it and send a patch to Jeff.

Gwendal.

On Tue, Aug 17, 2010 at 5:40 PM, Stephen Rothwell <[email protected]> wrote:
> Hi Jeff,
>
> After merging the libata tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/ata/libata-transport.c: In function 'ata_attach_transport':
> drivers/ata/libata-transport.c:678: error: implicit declaration of function 'kzalloc'
> drivers/ata/libata-transport.c:678: warning: assignment makes pointer from integer without a cast
> drivers/ata/libata-transport.c: In function 'ata_release_transport':
> drivers/ata/libata-transport.c:741: error: implicit declaration of function 'kfree'
>
> Caused by commit 97395d39931160a171959ac2e1fbff1caba3374b ("[libata] Add
> ATA transport class") neglecting to include linux/slab.h. ? See Rule 1 in
> Documentation/SubmitChecklist.
>
> I have used the libata tree form next-20100817 for today.
> --
> Cheers,
> Stephen Rothwell ? ? ? ? ? ? ? ? ? [email protected]
> http://www.canb.auug.org.au/~sfr/
>

2010-08-19 20:15:31

by Jeff Garzik

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the libata tree

On 08/17/2010 08:46 PM, Gwendal Grignou wrote:
> Let me fix it and send a patch to Jeff.
>
> Gwendal.
>
> On Tue, Aug 17, 2010 at 5:40 PM, Stephen Rothwell<[email protected]> wrote:
>> Hi Jeff,
>>
>> After merging the libata tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
>>
>> drivers/ata/libata-transport.c: In function 'ata_attach_transport':
>> drivers/ata/libata-transport.c:678: error: implicit declaration of function 'kzalloc'
>> drivers/ata/libata-transport.c:678: warning: assignment makes pointer from integer without a cast
>> drivers/ata/libata-transport.c: In function 'ata_release_transport':
>> drivers/ata/libata-transport.c:741: error: implicit declaration of function 'kfree'
>>
>> Caused by commit 97395d39931160a171959ac2e1fbff1caba3374b ("[libata] Add
>> ATA transport class") neglecting to include linux/slab.h. See Rule 1 in
>> Documentation/SubmitChecklist.
>>
>> I have used the libata tree form next-20100817 for today.


Never received a patch; pushed out the obvious fix myself.