2010-08-20 21:18:39

by Jeff Mahoney

[permalink] [raw]
Subject: [patch 04/10] ioctl: Use asm-generic/ioctls.h on frv (enables termiox)

This patch converts frv to use asm-generic/ioctls.h instead of its
own version.

The differences between the arch-specific version and the generic
version are as follows:

- FRV defines its own value for FIOQSIZE, asm-generic/ioctls.h keeps it
- FRV defines TIOCTTYGSTRUCT, kept in arch-specific version
- The generic version provides TIOCGRS485 and TIOCSRS485 but they
are unused by any driver available for this architecture.
- The generic version adds support for termiox

Cc: David Howells <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Jeff Mahoney <[email protected]>
---

arch/frv/include/asm/ioctls.h | 80 ------------------------------------------
1 file changed, 1 insertion(+), 79 deletions(-)

--- a/arch/frv/include/asm/ioctls.h
+++ b/arch/frv/include/asm/ioctls.h
@@ -1,88 +1,10 @@
#ifndef __ASM_IOCTLS_H__
#define __ASM_IOCTLS_H__

-#include <asm/ioctl.h>
-
-/* 0x54 is just a magic number to make these relatively unique ('T') */
-
-#define TCGETS 0x5401
-#define TCSETS 0x5402
-#define TCSETSW 0x5403
-#define TCSETSF 0x5404
-#define TCGETA 0x5405
-#define TCSETA 0x5406
-#define TCSETAW 0x5407
-#define TCSETAF 0x5408
-#define TCSBRK 0x5409
-#define TCXONC 0x540A
-#define TCFLSH 0x540B
-#define TIOCEXCL 0x540C
-#define TIOCNXCL 0x540D
-#define TIOCSCTTY 0x540E
-#define TIOCGPGRP 0x540F
-#define TIOCSPGRP 0x5410
-#define TIOCOUTQ 0x5411
-#define TIOCSTI 0x5412
-#define TIOCGWINSZ 0x5413
-#define TIOCSWINSZ 0x5414
-#define TIOCMGET 0x5415
-#define TIOCMBIS 0x5416
-#define TIOCMBIC 0x5417
-#define TIOCMSET 0x5418
-#define TIOCGSOFTCAR 0x5419
-#define TIOCSSOFTCAR 0x541A
-#define FIONREAD 0x541B
-#define TIOCINQ FIONREAD
-#define TIOCLINUX 0x541C
-#define TIOCCONS 0x541D
-#define TIOCGSERIAL 0x541E
-#define TIOCSSERIAL 0x541F
-#define TIOCPKT 0x5420
-#define FIONBIO 0x5421
-#define TIOCNOTTY 0x5422
-#define TIOCSETD 0x5423
-#define TIOCGETD 0x5424
-#define TCSBRKP 0x5425 /* Needed for POSIX tcsendbreak() */
#define TIOCTTYGSTRUCT 0x5426 /* For debugging only */
-#define TIOCSBRK 0x5427 /* BSD compatibility */
-#define TIOCCBRK 0x5428 /* BSD compatibility */
-#define TIOCGSID 0x5429 /* Return the session ID of FD */
-#define TCGETS2 _IOR('T',0x2A, struct termios2)
-#define TCSETS2 _IOW('T',0x2B, struct termios2)
-#define TCSETSW2 _IOW('T',0x2C, struct termios2)
-#define TCSETSF2 _IOW('T',0x2D, struct termios2)
-#define TIOCGPTN _IOR('T',0x30, unsigned int) /* Get Pty Number (of pty-mux device) */
-#define TIOCSPTLCK _IOW('T',0x31, int) /* Lock/unlock Pty */
-#define TIOCSIG _IOW('T',0x36, int) /* Generate signal on Pty slave */
-
-#define FIONCLEX 0x5450 /* these numbers need to be adjusted. */
-#define FIOCLEX 0x5451
-#define FIOASYNC 0x5452
-#define TIOCSERCONFIG 0x5453
-#define TIOCSERGWILD 0x5454
-#define TIOCSERSWILD 0x5455
-#define TIOCGLCKTRMIOS 0x5456
-#define TIOCSLCKTRMIOS 0x5457
-#define TIOCSERGSTRUCT 0x5458 /* For debugging only */
-#define TIOCSERGETLSR 0x5459 /* Get line status register */
-#define TIOCSERGETMULTI 0x545A /* Get multiport config */
-#define TIOCSERSETMULTI 0x545B /* Set multiport config */
-
-#define TIOCMIWAIT 0x545C /* wait for a change on serial input line(s) */
-#define TIOCGICOUNT 0x545D /* read serial port inline interrupt counts */
#define FIOQSIZE 0x545E

-/* Used for packet mode */
-#define TIOCPKT_DATA 0
-#define TIOCPKT_FLUSHREAD 1
-#define TIOCPKT_FLUSHWRITE 2
-#define TIOCPKT_STOP 4
-#define TIOCPKT_START 8
-#define TIOCPKT_NOSTOP 16
-#define TIOCPKT_DOSTOP 32
-#define TIOCPKT_IOCTL 64
-
-#define TIOCSER_TEMT 0x01 /* Transmitter physically empty */
+#include <asm-generic/ioctls.h>

#endif /* __ASM_IOCTLS_H__ */



2010-08-20 22:25:30

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [patch 04/10] ioctl: Use asm-generic/ioctls.h on frv (enables termiox)

On Friday 20 August 2010 23:14:05 Jeff Mahoney wrote:
> - FRV defines TIOCTTYGSTRUCT, kept in arch-specific version

Pointless, this was removed by the other architecture, and the
same change should be done here, possibly in a separate patch.

Arnd

2010-08-20 22:45:52

by Jeff Mahoney

[permalink] [raw]
Subject: Re: [patch 04/10] ioctl: Use asm-generic/ioctls.h on frv (enables termiox)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/20/2010 06:24 PM, Arnd Bergmann wrote:
> On Friday 20 August 2010 23:14:05 Jeff Mahoney wrote:
>> - FRV defines TIOCTTYGSTRUCT, kept in arch-specific version
>
> Pointless, this was removed by the other architecture, and the
> same change should be done here, possibly in a separate patch.

Agreed.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAkxvBZYACgkQLPWxlyuTD7I6DwCeP4N3tAiD1VB3S215KzyckOO6
0NAAoI2qtv6aKz6yDl4dQdBatOLENEwh
=Cnn1
-----END PGP SIGNATURE-----

2010-08-21 10:36:43

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [patch 04/10] ioctl: Use asm-generic/ioctls.h on frv (enables termiox)

On Fri, Aug 20, 2010 at 05:14:05PM -0400, Jeff Mahoney wrote:
> This patch converts frv to use asm-generic/ioctls.h instead of its
> own version.
>
> The differences between the arch-specific version and the generic
> version are as follows:
>
> - FRV defines its own value for FIOQSIZE, asm-generic/ioctls.h keeps it
> - FRV defines TIOCTTYGSTRUCT, kept in arch-specific version

This is an ioctl that used be implemented in generic code and then
was removed. I looks like a couple of ports added after the removal
kept the defintion anyway. Just kill it from all of them.