2010-08-23 16:21:24

by Niels de Vos

Subject: [PATCH] parport_pc: show the detection of a 2 serial port ITE8874 chip

The printk message for the 2 serial port version is obscured with a debug
macro, unlike all other versions of the card. It should be changed to make
the output equal for all detected models.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=578616#c1

CC: Joe Krahn <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
---
drivers/parport/parport_pc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
index 0950fa4..8d62fb7 100644
--- a/drivers/parport/parport_pc.c
+++ b/drivers/parport/parport_pc.c
@@ -2599,7 +2599,7 @@ static int __devinit sio_ite_8872_probe(struct pci_dev *pdev, int autoirq,
printk(KERN_INFO "parport_pc: ITE8873 found (1S)\n");
return 0;
case 0x8:
- DPRINTK(KERN_DEBUG "parport_pc: ITE8874 found (2S)\n");
+ printk(KERN_INFO "parport_pc: ITE8874 found (2S)\n");
return 0;
default:
printk(KERN_INFO "parport_pc: unknown ITE887x\n");
--
1.7.2.1

2010-08-24 13:21:35

by Jiri Kosina

Subject: Re: [PATCH] parport_pc: show the detection of a 2 serial port ITE8874 chip

On Mon, 23 Aug 2010, Niels de Vos wrote:

> The printk message for the 2 serial port version is obscured with a debug
> macro, unlike all other versions of the card. It should be changed to make
> the output equal for all detected models.
>
> Reference: https://bugzilla.redhat.com/show_bug.cgi?id=578616#c1
>
> CC: Joe Krahn <[email protected]>
> Signed-off-by: Niels de Vos <[email protected]>
> ---
> drivers/parport/parport_pc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
> index 0950fa4..8d62fb7 100644
> --- a/drivers/parport/parport_pc.c
> +++ b/drivers/parport/parport_pc.c
> @@ -2599,7 +2599,7 @@ static int __devinit sio_ite_8872_probe(struct pci_dev *pdev, int autoirq,
> printk(KERN_INFO "parport_pc: ITE8873 found (1S)\n");
> return 0;
> case 0x8:
> - DPRINTK(KERN_DEBUG "parport_pc: ITE8874 found (2S)\n");
> + printk(KERN_INFO "parport_pc: ITE8874 found (2S)\n");
> return 0;
> default:
> printk(KERN_INFO "parport_pc: unknown ITE887x\n");

Applied, thank you.

--
Jiri Kosina
SUSE Labs, Novell Inc.