2010-08-30 07:52:25

by Jin Dongming

Subject: [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

I think this patch will fix it.

Signed-off-by: Jin Dongming <[email protected]>
---
arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index d9368ee..2f9f468 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)

static void unexpected_thermal_interrupt(void)
{
- printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+ printk(KERN_ERR "CPU%d: Unexpected LVT Thermal Interrupt!\n",
smp_processor_id());
add_taint(TAINT_MACHINE_CHECK);
}
--
1.7.1.1

2010-08-30 07:58:13

by Jean Delvare

Subject: Re: [lm-sensors] [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.

On Mon, 30 Aug 2010 16:52:56 +0900, Jin Dongming wrote:
> In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
> in error message.
>
> I don't think TMR is a suitable abbreviation for thermal.
> 1.TMR has been used in IA32 Architectures Software Developer's
> Manual, and is the abbreviation for Trigger Mode Register.
> 2.There is not an standard abbreviation "TMR" defined for thermal
> in IA32 Architectures Software Developer's Manual.
> 3.Though we could understand it as Thermal Monitor Register, it is
> easy to be misunderstood as a *TIMER* interrupt also.
>
> I think this patch will fix it.
>
> Signed-off-by: Jin Dongming <[email protected]>
> ---
> arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> index d9368ee..2f9f468 100644
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
>
> static void unexpected_thermal_interrupt(void)
> {
> - printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
> + printk(KERN_ERR "CPU%d: Unexpected LVT Thermal Interrupt!\n",
> smp_processor_id());
> add_taint(TAINT_MACHINE_CHECK);
> }

I see no good reason to upper-case the first letter of each word. This
is a kernel log message, not a movie title.

Other than that, I agree with your proposal.


--
Jean Delvare

2010-08-31 00:13:03

by Jin Dongming

Subject: [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

I think this patch will fix it.

Signed-off-by: Jin Dongming <[email protected]>
---
arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index d9368ee..ba52598 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)

static void unexpected_thermal_interrupt(void)
{
- printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+ printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
smp_processor_id());
add_taint(TAINT_MACHINE_CHECK);
}
--
1.7.1.1

2010-08-31 06:57:05

by Jean Delvare

Subject: Re: [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.

On Tue, 31 Aug 2010 09:13:33 +0900, Jin Dongming wrote:
> In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
> in error message.
>
> I don't think TMR is a suitable abbreviation for thermal.
> 1.TMR has been used in IA32 Architectures Software Developer's
> Manual, and is the abbreviation for Trigger Mode Register.
> 2.There is not an standard abbreviation "TMR" defined for thermal
> in IA32 Architectures Software Developer's Manual.
> 3.Though we could understand it as Thermal Monitor Register, it is
> easy to be misunderstood as a *TIMER* interrupt also.
>
> I think this patch will fix it.
>
> Signed-off-by: Jin Dongming <[email protected]>

Reviewed-by: Jean Delvare <[email protected]>

> ---
> arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> index d9368ee..ba52598 100644
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
>
> static void unexpected_thermal_interrupt(void)
> {
> - printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
> + printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
> smp_processor_id());
> add_taint(TAINT_MACHINE_CHECK);
> }


--
Jean Delvare

2010-08-31 17:40:13

by Fenghua Yu

Subject: Re: [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.

On Mon, Aug 30, 2010 at 11:56:53PM -0700, Jean Delvare wrote:
> On Tue, 31 Aug 2010 09:13:33 +0900, Jin Dongming wrote:
> > In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
> > in error message.
> >
> > I don't think TMR is a suitable abbreviation for thermal.
> > 1.TMR has been used in IA32 Architectures Software Developer's
> > Manual, and is the abbreviation for Trigger Mode Register.
> > 2.There is not an standard abbreviation "TMR" defined for thermal
> > in IA32 Architectures Software Developer's Manual.
> > 3.Though we could understand it as Thermal Monitor Register, it is
> > easy to be misunderstood as a *TIMER* interrupt also.
> >
> > I think this patch will fix it.
> >
> > Signed-off-by: Jin Dongming <[email protected]>
>
> Reviewed-by: Jean Delvare <[email protected]>
Reviewed-by: Fenghua Yu <[email protected]>
>
> > ---
> > arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > index d9368ee..ba52598 100644
> > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > @@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
> >
> > static void unexpected_thermal_interrupt(void)
> > {
> > - printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
> > + printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
> > smp_processor_id());
> > add_taint(TAINT_MACHINE_CHECK);
> > }
>
>
> --
> Jean Delvare