2010-11-02 07:19:02

by gimli

[permalink] [raw]
Subject: [PATCH 2/6] MacBookAir3,1(3,2) touchpad ( bcm5974 ) support

This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
bcm5974 driver.

Signed-off-by: Edgar (gimli) Hucek <[email protected]>


Attachments:
bcm5974_macbookair.patch (2.69 kB)

2010-11-02 16:52:59

by Henrik Rydberg

[permalink] [raw]
Subject: Re: [PATCH 2/6] MacBookAir3,1(3,2) touchpad ( bcm5974 ) support

On 11/02/2010 08:18 AM, gimli wrote:

> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
> bcm5974 driver.
>
> Signed-off-by: Edgar (gimli) Hucek <[email protected]>


Thanks for your patches. Do the usb message packet lengths of these new device
ids differ in any respect from the old ones? What is the difference between the
two sets of ids? Physical size? Are the devices really exactly the same?

Any additional information you can provide to shed light on these questions
would be greatly appreciated. My concern is that there might be more things that
need to be changed for these devices.

Thanks,
Henrik

2010-11-03 10:56:25

by gimli

[permalink] [raw]
Subject: Re: [PATCH 2/6] MacBookAir3,1(3,2) touchpad ( bcm5974 ) support

On Tue, 02 Nov 2010 17:51:58 +0100, Henrik Rydberg <[email protected]>
wrote:
> On 11/02/2010 08:18 AM, gimli wrote:
>
>> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
>> bcm5974 driver.
>>
>> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
>
>
> Thanks for your patches. Do the usb message packet lengths of these new
> device
> ids differ in any respect from the old ones? What is the difference
between
> the
> two sets of ids? Physical size? Are the devices really exactly the same?
>
> Any additional information you can provide to shed light on these
questions
> would be greatly appreciated. My concern is that there might be more
things
> that
> need to be changed for these devices.

What i did was asuming the touchpad works similiar to the WELLSPRING3 ones.
So i took the names from the Apple kext's and used the values from the
WELLSPRING3.
If i can with any debug output let me know how to make it and i'll more
than happy
to send it.
As far as i see only the Size on the new ones differ.

lg

Edgar (gimli) Hucek

> Thanks,
> Henrik
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2010-11-03 11:15:51

by Henrik Rydberg

[permalink] [raw]
Subject: Re: [PATCH 2/6] MacBookAir3,1(3,2) touchpad ( bcm5974 ) support

On 11/03/2010 11:56 AM, gimli wrote:
[...]

>> Any additional information you can provide to shed light on these
> questions
>> would be greatly appreciated. My concern is that there might be more
> things
>> that
>> need to be changed for these devices.
>
> What i did was asuming the touchpad works similiar to the WELLSPRING3 ones.
> So i took the names from the Apple kext's and used the values from the
> WELLSPRING3.
> If i can with any debug output let me know how to make it and i'll more
> than happy
> to send it.
> As far as i see only the Size on the new ones differ.


Thanks for the background and your work on this. Yes, let's hash out the
reamining details in the forums, and leave this thread until then. Will get my
hands on one of the 11'' today as well. :-)

Cheers,
Henrik