This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
applesmc driver.
Signed-off-by: Edgar (gimli) Hucek <[email protected]>
On 11/02/2010 08:17 AM, gimli wrote:
> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
> applesmc driver.
>
> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
Thanks for this information. The patch is conflicting with a makeover currently
on review, but it is a candidate for inclusion in 2.6.37 and stable.
> /* List of keys used to read/write fan speeds */
> @@ -1524,11 +1528,21 @@
> { .accelerometer = 1, .light = 1, .temperature_set = 21 },
> /* MacBook Pro 7,1: accelerometer, backlight and temperature set 22 */
> { .accelerometer = 1, .light = 1, .temperature_set = 22 },
> +/* MacBook Air 3,1: accelerometer, backlight and temperature set 15 */
> + { .accelerometer = 0, .light = 0, .temperature_set = 23 },
> };
Comment "temperature set 15" is confusing.
> /* Note that DMI_MATCH(...,"MacBook") will match "MacBookPro1,1".
> * So we need to put "Apple MacBook Pro" before "Apple MacBook". */
> static __initdata struct dmi_system_id applesmc_whitelist[] = {
> + { applesmc_dmi_match, "Apple MacBook Air 3", {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir3,2") },
> + &applesmc_dmi_data[23]},
> + { applesmc_dmi_match, "Apple MacBook Air 3", {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir3,1") },
> + &applesmc_dmi_data[23]},
What is the different between models 3,1 and 3,2? If there is no difference, a
single entry will suffice.
Thanks,
Henrik
On Tue, 02 Nov 2010 17:43:28 +0100, Henrik Rydberg <[email protected]>
wrote:
> On 11/02/2010 08:17 AM, gimli wrote:
>
>> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
>> applesmc driver.
>>
>> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
>
>
> Thanks for this information. The patch is conflicting with a makeover
> currently
> on review, but it is a candidate for inclusion in 2.6.37 and stable.
>
>> /* List of keys used to read/write fan speeds */
>> @@ -1524,11 +1528,21 @@
>> { .accelerometer = 1, .light = 1, .temperature_set = 21 },
>> /* MacBook Pro 7,1: accelerometer, backlight and temperature set 22 */
>> { .accelerometer = 1, .light = 1, .temperature_set = 22 },
>> +/* MacBook Air 3,1: accelerometer, backlight and temperature set 15 */
>> + { .accelerometer = 0, .light = 0, .temperature_set = 23 },
>> };
>
> Comment "temperature set 15" is confusing.
>
This is a copy and paste error. Should be :
+/* MacBook Air 3,1(2): temperature set 23 */
>> /* Note that DMI_MATCH(...,"MacBook") will match "MacBookPro1,1".
>> * So we need to put "Apple MacBook Pro" before "Apple MacBook". */
>> static __initdata struct dmi_system_id applesmc_whitelist[] = {
>> + { applesmc_dmi_match, "Apple MacBook Air 3", {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir3,2") },
>> + &applesmc_dmi_data[23]},
>> + { applesmc_dmi_match, "Apple MacBook Air 3", {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir3,1") },
>> + &applesmc_dmi_data[23]},
>
> What is the different between models 3,1 and 3,2? If there is no
> difference, a
> single entry will suffice.
They are both the same.
lg
Edgar (gimli) Hucek
> Thanks,
> Henrik
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
On 11/03/2010 10:39 AM, gimli wrote:
> On Tue, 02 Nov 2010 17:43:28 +0100, Henrik Rydberg <[email protected]>
> wrote:
>> On 11/02/2010 08:17 AM, gimli wrote:
>>
>>> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
>>> applesmc driver.
>>>
>>> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
>>
>>
>> Thanks for this information. The patch is conflicting with a makeover
>> currently
>> on review, but it is a candidate for inclusion in 2.6.37 and stable.
>>
>>> /* List of keys used to read/write fan speeds */
>>> @@ -1524,11 +1528,21 @@
>>> { .accelerometer = 1, .light = 1, .temperature_set = 21 },
>>> /* MacBook Pro 7,1: accelerometer, backlight and temperature set 22 */
>>> { .accelerometer = 1, .light = 1, .temperature_set = 22 },
>>> +/* MacBook Air 3,1: accelerometer, backlight and temperature set 15 */
>>> + { .accelerometer = 0, .light = 0, .temperature_set = 23 },
>>> };
>>
>> Comment "temperature set 15" is confusing.
>>
>
> This is a copy and paste error. Should be :
>
> +/* MacBook Air 3,1(2): temperature set 23 */
>
>
>
>>> /* Note that DMI_MATCH(...,"MacBook") will match "MacBookPro1,1".
>>> * So we need to put "Apple MacBook Pro" before "Apple MacBook". */
>>> static __initdata struct dmi_system_id applesmc_whitelist[] = {
>>> + { applesmc_dmi_match, "Apple MacBook Air 3", {
>>> + DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
>>> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir3,2") },
>>> + &applesmc_dmi_data[23]},
>>> + { applesmc_dmi_match, "Apple MacBook Air 3", {
>>> + DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
>>> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir3,1") },
>>> + &applesmc_dmi_data[23]},
>>
>> What is the different between models 3,1 and 3,2? If there is no
>> difference, a
>> single entry will suffice.
>
> They are both the same.
Great - would you care to resend the patch with the changes incorporated?
Thanks,
Henrik
Typo fixed patch.
Signed-off-by: Edgar (gimli) Hucek <[email protected]>
On Wed, 03 Nov 2010 11:21:35 +0100, Henrik Rydberg <[email protected]>
wrote:
> On 11/03/2010 10:39 AM, gimli wrote:
>
>> On Tue, 02 Nov 2010 17:43:28 +0100, Henrik Rydberg <[email protected]>
>> wrote:
>>> On 11/02/2010 08:17 AM, gimli wrote:
>>>
>>>> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
>>>> applesmc driver.
>>>>
>>>> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
>>>
>>>
>>> Thanks for this information. The patch is conflicting with a makeover
>>> currently
>>> on review, but it is a candidate for inclusion in 2.6.37 and stable.
>>>
>>>> /* List of keys used to read/write fan speeds */
>>>> @@ -1524,11 +1528,21 @@
>>>> { .accelerometer = 1, .light = 1, .temperature_set = 21 },
>>>> /* MacBook Pro 7,1: accelerometer, backlight and temperature set 22
*/
>>>> { .accelerometer = 1, .light = 1, .temperature_set = 22 },
>>>> +/* MacBook Air 3,1: accelerometer, backlight and temperature set 15
*/
>>>> + { .accelerometer = 0, .light = 0, .temperature_set = 23 },
>>>> };
>>>
>>> Comment "temperature set 15" is confusing.
>>>
>>
>> This is a copy and paste error. Should be :
>>
>> +/* MacBook Air 3,1(2): temperature set 23 */
>>
>>
>>
>>>> /* Note that DMI_MATCH(...,"MacBook") will match "MacBookPro1,1".
>>>> * So we need to put "Apple MacBook Pro" before "Apple MacBook". */
>>>> static __initdata struct dmi_system_id applesmc_whitelist[] = {
>>>> + { applesmc_dmi_match, "Apple MacBook Air 3", {
>>>> + DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
>>>> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir3,2") },
>>>> + &applesmc_dmi_data[23]},
>>>> + { applesmc_dmi_match, "Apple MacBook Air 3", {
>>>> + DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
>>>> + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir3,1") },
>>>> + &applesmc_dmi_data[23]},
>>>
>>> What is the different between models 3,1 and 3,2? If there is no
>>> difference, a
>>> single entry will suffice.
>>
>> They are both the same.
>
>
> Great - would you care to resend the patch with the changes incorporated?
>
> Thanks,
> Henrik
On 11/03/2010 11:41 AM, gimli wrote:
> Typo fixed patch.
>
> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
Still two entries... Ok, I can correct this patch myself and incorporate it in
the upcoming rebase, which will follow after some discussions regarding the
patches currently on review. I would also suggest that you please read through
the documentation on how to submit patches, to better help the maintainers and
make your submissions smoother.
Thanks,
Henrik