On Sun, Oct 31, 2010 at 03:50:34AM -0400, Henrik Rydberg wrote:
> With the preceding patches, git blame assigns about half of
> the file to the present author. Add a line to the copyright
> to reflect this.
>
> Signed-off-by: Henrik Rydberg <[email protected]>
> ---
> drivers/hwmon/applesmc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
> index c09cd2e..7ae37eb 100644
> --- a/drivers/hwmon/applesmc.c
> +++ b/drivers/hwmon/applesmc.c
> @@ -4,6 +4,7 @@
> * computers.
> *
> * Copyright (C) 2007 Nicolas Boichat <[email protected]>
> + * Copyright (C) 2010 Henrik Rydberg <[email protected]>
> *
> * Based on hdaps.c driver:
> * Copyright (C) 2005 Robert Love <[email protected]>
> --
Hi Henrik,
overall excellent cleanup.
One suggestion - since you did that much rework, it would be nice if you could fix
the remaining few checkpatch errors in the file as well (and possibly the warnings).
Guenter
>
> One suggestion - since you did that much rework, it would be nice if you could fix
> the remaining few checkpatch errors in the file as well (and possibly the warnings).
Absolutely. Regarding the warnings, I was deliberately leaving the over-80 lines
since they appear in static array listings, and as such seem to be pretty common
in the kernel. I know these things have been discussed before. :-)
Cheers,
Henrik
On Fri, Nov 05, 2010 at 05:00:05AM -0400, Henrik Rydberg wrote:
> >
>
> > One suggestion - since you did that much rework, it would be nice if you could fix
> > the remaining few checkpatch errors in the file as well (and possibly the warnings).
>
>
> Absolutely. Regarding the warnings, I was deliberately leaving the over-80 lines
> since they appear in static array listings, and as such seem to be pretty common
> in the kernel. I know these things have been discussed before. :-)
>
Ok, no problem with me.
Guenter