2010-11-06 19:03:23

by Tracey Dent

[permalink] [raw]
Subject: [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile

Use the ccflag-y instead of EXTRA_CFLAGS.

Signed-off-by: Tracey Dent <[email protected]>
---
drivers/dma/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
index a8a84f4..64b21f5 100644
--- a/drivers/dma/Makefile
+++ b/drivers/dma/Makefile
@@ -1,8 +1,8 @@
ifeq ($(CONFIG_DMADEVICES_DEBUG),y)
- EXTRA_CFLAGS += -DDEBUG
+ ccflags-y += -DDEBUG
endif
ifeq ($(CONFIG_DMADEVICES_VDEBUG),y)
- EXTRA_CFLAGS += -DVERBOSE_DEBUG
+ ccflags-y += -DVERBOSE_DEBUG
endif

obj-$(CONFIG_DMA_ENGINE) += dmaengine.o
--
1.7.3.1.104.gc752e


2010-11-06 19:03:25

by Tracey Dent

[permalink] [raw]
Subject: [PATCH 2/2] Drivers: dma: ioat: Makeile: Cleaned up Makefile

Changed Makefile to use <modules>-y instead of <modules>-objs.

Signed-off-by: Tracey Dent <[email protected]>
---
drivers/dma/ioat/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/ioat/Makefile b/drivers/dma/ioat/Makefile
index 8997d3f..0ff7270 100644
--- a/drivers/dma/ioat/Makefile
+++ b/drivers/dma/ioat/Makefile
@@ -1,2 +1,2 @@
obj-$(CONFIG_INTEL_IOATDMA) += ioatdma.o
-ioatdma-objs := pci.o dma.o dma_v2.o dma_v3.o dca.o
+ioatdma-y := pci.o dma.o dma_v2.o dma_v3.o dca.o
--
1.7.3.1.104.gc752e

2010-11-06 19:40:34

by Dan Williams

[permalink] [raw]
Subject: Re: [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile

On 11/06/2010 12:03 PM, Tracey Dent wrote:
> Use the ccflag-y instead of EXTRA_CFLAGS.

Thanks for the patch.

Please make the subject line: "drivers/dma/: Use the ccflag-y instead of
EXTRA_CFLAGS", and the description say why it is preferable to use
ccflag-y over EXTRA_CFLAGS.

That would make easy for me to judge why I should apply this.

Ditto for [PATCH 2/2]

--
Dan

2010-11-08 09:35:03

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile

Tracey Dent wrote:

> Use the ccflag-y instead of EXTRA_CFLAGS.
>
> Signed-off-by: Tracey Dent <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Linus Walleij