2010-11-10 10:51:41

by Jovi Zhang

Subject: [PATCH] kdb: use macro instead of const number

It's better to use macro KDB_BASE_CMD_MAX instead of 50

Signed-off-by: jovi zhang <[email protected]>
kernel/debug/kdb/kdb_main.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 37755d6..3579105 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -78,7 +78,7 @@ static unsigned int kdb_continue_catastrophic;
static kdbtab_t *kdb_commands;
#define KDB_BASE_CMD_MAX 50
static int kdb_max_commands = KDB_BASE_CMD_MAX;
-static kdbtab_t kdb_base_commands[50];
+static kdbtab_t kdb_base_commands[KDB_BASE_CMD_MAX];
#define for_each_kdbcmd(cmd, num)                                      \
       for ((cmd) = kdb_base_commands, (num) = 0;                      \
            num < kdb_max_commands;                                    \

2010-11-10 13:21:51

by Jason Wessel

Subject: Re: [PATCH] kdb: use macro instead of const number

The 3 patches you have sent me so far all have white space that is
completely mangled. In the future, please use a mail client that does
not mangle white space, or use "git send-email".

I did fix up your patches so as to add them to the merge queue. The
code cleanup (this patch) will be deferred to the next merge window.

Please see my other comment about signed off by tags.


On 11/10/2010 04:51 AM, jovi zhang wrote:
> It's better to use macro KDB_BASE_CMD_MAX instead of 50
>
> Signed-off-by: jovi zhang <[email protected]>
>

For a signed off tag, you want to make sure these are consistent for all
the patches you send to any kernel maintainer or kernel mailing list.
You already have one patch in the kernel
(85e00b55517a5696282b80836655e6b6f5702df0), and it does not match your
signed-off-by line.

If you are using git to make your patches, please edit the ~/.gitconfig
and use something like:
[user]
name = Jovi Zhang
email = [email protected]

Thanks,
Jason.

> kernel/debug/kdb/kdb_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
> index 37755d6..3579105 100644
> --- a/kernel/debug/kdb/kdb_main.c
> +++ b/kernel/debug/kdb/kdb_main.c
> @@ -78,7 +78,7 @@ static unsigned int kdb_continue_catastrophic;
> static kdbtab_t *kdb_commands;
> #define KDB_BASE_CMD_MAX 50
> static int kdb_max_commands = KDB_BASE_CMD_MAX;
> -static kdbtab_t kdb_base_commands[50];
> +static kdbtab_t kdb_base_commands[KDB_BASE_CMD_MAX];
> #define for_each_kdbcmd(cmd, num) \
> for ((cmd) = kdb_base_commands, (num) = 0; \
> num < kdb_max_commands; \
>