I was able to reproduce and test the transmission error on vt6420
hardware with the 2G WD drives. Adding the controller ID to this fix
seems to result in a properly working system.
Signed-off-by: Peter Zijlstra <[email protected]>
---
drivers/ata/sata_via.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 4730c42..2822492 100644
--- a/drivers/ata/sata_via.c
+++ b/drivers/ata/sata_via.c
@@ -577,7 +577,7 @@ static void svia_configure(struct pci_dev *pdev)
}
/*
- * vt6421 has problems talking to some drives. The following
+ * vt642[01] has problems talking to some drives. The following
* is the fix from Joseph Chan <[email protected]>.
*
* When host issues HOLD, device may send up to 20DW of data
@@ -597,7 +597,7 @@ static void svia_configure(struct pci_dev *pdev)
* https://bugzilla.kernel.org/show_bug.cgi?id=15173
* http://article.gmane.org/gmane.linux.ide/46352
*/
- if (pdev->device == 0x3249) {
+ if (pdev->device == 0x3249 || pdev->device == 0x3149) {
pci_read_config_byte(pdev, 0x52, &tmp8);
tmp8 |= 1 << 2;
pci_write_config_byte(pdev, 0x52, tmp8);
On Sun, 2010-11-14 at 13:31 +0100, Peter Zijlstra wrote:
> hardware with the 2G WD drives. Adding the controller ID to this fix
Clearly that was meant to say 2T drives :-)
On 11/14/2010 07:31 AM, Peter Zijlstra wrote:
> I was able to reproduce and test the transmission error on vt6420
> hardware with the 2G WD drives. Adding the controller ID to this fix
> seems to result in a properly working system.
>
> Signed-off-by: Peter Zijlstra<[email protected]>
Please CC linux-ide and myself on all libata patches, as MAINTAINERS and
drivers/ata/sata_via.c both indicate.
Hello, Peter.
On 11/14/2010 01:31 PM, Peter Zijlstra wrote:
> I was able to reproduce and test the transmission error on vt6420
> hardware with the 2G WD drives. Adding the controller ID to this fix
> seems to result in a properly working system.
Yeah, there was another report on bugzilla and I contacted Joseph a
few days ago for confirmation. There are multiple PCI IDs for vt6420
and I think we'll probably have to apply the workaround to all of
them. Joseph, can you please confirm this?
Thanks.
--
tejun
On Sun, 2010-11-14 at 23:02 -0500, Jeff Garzik wrote:
> On 11/14/2010 07:31 AM, Peter Zijlstra wrote:
> > I was able to reproduce and test the transmission error on vt6420
> > hardware with the 2G WD drives. Adding the controller ID to this fix
> > seems to result in a properly working system.
> >
> > Signed-off-by: Peter Zijlstra<[email protected]>
>
> Please CC linux-ide and myself on all libata patches, as MAINTAINERS and
> drivers/ata/sata_via.c both indicate.
Oh, I thought I had CC'ed you, you're in the signoff trail of the
initial patch, I must have fudged it. Sorry about that.