2010-11-22 05:58:58

by Toshiharu Okada

Subject: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry

The wrong of initializer entry was modified.

Signed-off-by: Toshiharu Okada <[email protected]>
---
drivers/net/pch_gbe/pch_gbe_param.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/pch_gbe/pch_gbe_param.c b/drivers/net/pch_gbe/pch_gbe_param.c
index 2510146..ef0996a 100644
--- a/drivers/net/pch_gbe/pch_gbe_param.c
+++ b/drivers/net/pch_gbe/pch_gbe_param.c
@@ -434,8 +434,8 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
.err = "using default of "
__MODULE_STRING(PCH_GBE_DEFAULT_TXD),
.def = PCH_GBE_DEFAULT_TXD,
- .arg = { .r = { .min = PCH_GBE_MIN_TXD } },
- .arg = { .r = { .max = PCH_GBE_MAX_TXD } }
+ .arg = { .r = { .min = PCH_GBE_MIN_TXD,
+ .max = PCH_GBE_MAX_TXD } }
};
struct pch_gbe_tx_ring *tx_ring = adapter->tx_ring;
tx_ring->count = TxDescriptors;
@@ -450,8 +450,8 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
.err = "using default of "
__MODULE_STRING(PCH_GBE_DEFAULT_RXD),
.def = PCH_GBE_DEFAULT_RXD,
- .arg = { .r = { .min = PCH_GBE_MIN_RXD } },
- .arg = { .r = { .max = PCH_GBE_MAX_RXD } }
+ .arg = { .r = { .min = PCH_GBE_MIN_RXD,
+ .max = PCH_GBE_MAX_RXD } }
};
struct pch_gbe_rx_ring *rx_ring = adapter->rx_ring;
rx_ring->count = RxDescriptors;
--
1.6.2.5

2010-11-28 01:40:40

by David Miller

Subject: Re: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry

From: Toshiharu Okada <[email protected]>
Date: Mon, 22 Nov 2010 14:58:53 +0900

> The wrong of initializer entry was modified.
>
> Signed-off-by: Toshiharu Okada <[email protected]>

How about you give some credit to David Alan Gilbert who made
you aware of this issue?

2010-11-29 05:06:38

by Toshiharu Okada

Subject: Re: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry

Hi David Miller


Date: Sat, 27 Nov 2010 17:41:03 -0800 (PST)
From: "David Miller" <[email protected]>
>
> > The wrong of initializer entry was modified.
> >
> > Signed-off-by: Toshiharu Okada <[email protected]>
>
> How about you give some credit to David Alan Gilbert who made
> you aware of this issue?

Credit?
Does this mean that I add "Singed of by: Dr. David Alan Gilbert
<[email protected]>" ?
Is my understanding correct?

Best regards
Toshiharu Okada (OKI SEMICONDUCTOR)

2010-11-29 05:59:09

by David Miller

Subject: Re: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry

From: "Toshiharu Okada" <[email protected]>
Date: Mon, 29 Nov 2010 14:06:23 +0900

> Hi David Miller
>
>
> Date: Sat, 27 Nov 2010 17:41:03 -0800 (PST)
> From: "David Miller" <[email protected]>
>>
>> > The wrong of initializer entry was modified.
>> >
>> > Signed-off-by: Toshiharu Okada <[email protected]>
>>
>> How about you give some credit to David Alan Gilbert who made
>> you aware of this issue?
>
> Credit?
> Does this mean that I add "Singed of by: Dr. David Alan Gilbert
> <[email protected]>" ?
> Is my understanding correct?

You should use "Reported-by: ..."