2010-11-26 02:20:09

by Hitoshi Mitake

Subject: [PATCH] workqueue: check the allocation of system_unbound_wq

I found a trivial bug on initialization of workqueue.
Current init_workqueues doesn't check the result of
allocation of system_unbound_wq, this should be checked
like other queues.

Signed-off-by: Hitoshi Mitake <[email protected]>
Cc: Arjan van de Ven <[email protected]>
Cc: David Howells <[email protected]>
---
kernel/workqueue.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 90db1bd..b60374d 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -3692,7 +3692,8 @@ static int __init init_workqueues(void)
system_nrt_wq = alloc_workqueue("events_nrt", WQ_NON_REENTRANT, 0);
system_unbound_wq = alloc_workqueue("events_unbound", WQ_UNBOUND,
WQ_UNBOUND_MAX_ACTIVE);
- BUG_ON(!system_wq || !system_long_wq || !system_nrt_wq);
+ BUG_ON(!system_wq || !system_long_wq ||
+ !system_nrt_wq || !system_unbound_wq);
return 0;
}
early_initcall(init_workqueues);
--
1.6.5.2

2010-11-26 11:08:05

by Tejun Heo

Subject: Re: [PATCH] workqueue: check the allocation of system_unbound_wq

Hello,

On 11/26/2010 03:19 AM, Hitoshi Mitake wrote:
> I found a trivial bug on initialization of workqueue.
> Current init_workqueues doesn't check the result of
> allocation of system_unbound_wq, this should be checked
> like other queues.
>
> Signed-off-by: Hitoshi Mitake <[email protected]>
> Cc: Arjan van de Ven <[email protected]>
> Cc: David Howells <[email protected]>

Queued to wq#for-linus with new line adjustment.

Thanks a lot. :-)

--
tejun

2010-11-29 13:32:43

by Hitoshi Mitake

Subject: Re: [PATCH] workqueue: check the allocation of system_unbound_wq

On 2010年11月26日 20:07, Tejun Heo wrote:
> Hello,
>
> On 11/26/2010 03:19 AM, Hitoshi Mitake wrote:
>> I found a trivial bug on initialization of workqueue.
>> Current init_workqueues doesn't check the result of
>> allocation of system_unbound_wq, this should be checked
>> like other queues.
>>
>> Signed-off-by: Hitoshi Mitake<[email protected]>
>> Cc: Arjan van de Ven<[email protected]>
>> Cc: David Howells<[email protected]>
>
> Queued to wq#for-linus with new line adjustment.
>
> Thanks a lot. :-)
>

Hi Tejun,
Thanks for your adjustment and applying :)