2010-12-07 15:02:07

by Jan Beulich

Subject: [PATCH] name_to_dev_t() must not call __init code

The function can't be __init itself (being called from some sysfs
handler), and hence none of the functions it call can be either.

Signed-off-by: Jan Beulich <[email protected]>

---
init/do_mounts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.37-rc5/init/do_mounts.c
+++ 2.6.37-rc5-do_mounts-sections/init/do_mounts.c
@@ -93,7 +93,7 @@ no_match:
*
* Returns the matching dev_t on success or 0 on failure.
*/
-static dev_t __init devt_from_partuuid(char *uuid_str)
+static dev_t devt_from_partuuid(char *uuid_str)
{
dev_t res = 0;
struct device *dev = NULL;

2010-12-07 21:48:04

by Randy Dunlap

Subject: Re: [PATCH] name_to_dev_t() must not call __init code

On Tue, December 7, 2010 7:02 am, Jan Beulich wrote:
> The function can't be __init itself (being called from some sysfs
> handler), and hence none of the functions it call can be either.
>
> Signed-off-by: Jan Beulich <[email protected]>
>

Acked-by: Randy Dunlap <[email protected]>

>
> ---
> init/do_mounts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> --- linux-2.6.37-rc5/init/do_mounts.c
> +++ 2.6.37-rc5-do_mounts-sections/init/do_mounts.c
> @@ -93,7 +93,7 @@ no_match:
> *
> * Returns the matching dev_t on success or 0 on failure.
> */
> -static dev_t __init devt_from_partuuid(char *uuid_str)
> +static dev_t devt_from_partuuid(char *uuid_str)
> {
> dev_t res = 0; struct device *dev = NULL;
>
>
>
> --

--
~Randy