2010-12-07 11:09:50

by Tomoya MORINAGA

[permalink] [raw]

Subject: [PATCH net-next-2.6 v8 20/20] CAN : Replace netif_rx to netif_receive_skb

---

Since this driver is implemented as NAPI,
netif_receive_skb must be used not netif_rx.

Signed-off-by: Tomoya MORINAGA <[email protected]>
---
drivers/net/can/pch_can.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
index 4697b1c..8d45fdd 100644
--- a/drivers/net/can/pch_can.c
+++ b/drivers/net/can/pch_can.c
@@ -572,7 +572,7 @@ static void pch_can_error(struct net_device *ndev, u32 status)
cf->data[7] = (errc & PCH_REC) >> 8;

priv->can.state = state;
- netif_rx(skb);
+ netif_receive_skb(skb);

stats->rx_packets++;
stats->rx_bytes += cf->can_dlc;
--
1.6.0.6

2010-12-12 18:29:30

by Marc Kleine-Budde

[permalink] [raw]

Subject: Re: [PATCH net-next-2.6 v8 20/20] CAN : Replace netif_rx to netif_receive_skb

---

On 12/07/2010 12:12 PM, Tomoya MORINAGA wrote:
> Since this driver is implemented as NAPI,
> netif_receive_skb must be used not netif_rx.
>
> Signed-off-by: Tomoya MORINAGA <[email protected]>

Looks good.
Acked-by: Marc Kleine-Budde <[email protected]>

Marc

> ---
> drivers/net/can/pch_can.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
> index 4697b1c..8d45fdd 100644
> --- a/drivers/net/can/pch_can.c
> +++ b/drivers/net/can/pch_can.c
> @@ -572,7 +572,7 @@ static void pch_can_error(struct net_device *ndev, u32 status)
> cf->data[7] = (errc & PCH_REC) >> 8;
>
> priv->can.state = state;
> - netif_rx(skb);
> + netif_receive_skb(skb);
>
> stats->rx_packets++;
> stats->rx_bytes += cf->can_dlc;


--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

---

Attachments:

signature.asc (262.00 B)
OpenPGP digital signature