2010-12-21 07:47:52

by Daniel Morsing

Subject: [PATCH] OMAP2: Devkit8000: Use _cansleep GPIO functions for display reset lines

The display reset lines are connected to a TPS65930 which may sleep
when changing GPIO values. Use the appropriate function to silence
a nasty warning from gpiolib.

Signed-off-by: Daniel Morsing <[email protected]>
---
arch/arm/mach-omap2/board-devkit8000.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-omap2/board-devkit8000.c
b/arch/arm/mach-omap2/board-devkit8000.c
index 53ac762..f1f58f5 100644
--- a/arch/arm/mach-omap2/board-devkit8000.c
+++ b/arch/arm/mach-omap2/board-devkit8000.c
@@ -118,27 +118,27 @@ static int devkit8000_panel_enable_lcd(struct
omap_dss_device *dssdev)
twl_i2c_write_u8(TWL4030_MODULE_LED, 0x0, 0x0);

if (gpio_is_valid(dssdev->reset_gpio))
- gpio_set_value(dssdev->reset_gpio, 1);
+ gpio_set_value_cansleep(dssdev->reset_gpio, 1);
return 0;
}

static void devkit8000_panel_disable_lcd(struct omap_dss_device *dssdev)
{
if (gpio_is_valid(dssdev->reset_gpio))
- gpio_set_value(dssdev->reset_gpio, 0);
+ gpio_set_value_cansleep(dssdev->reset_gpio, 0);
}

static int devkit8000_panel_enable_dvi(struct omap_dss_device *dssdev)
{
if (gpio_is_valid(dssdev->reset_gpio))
- gpio_set_value(dssdev->reset_gpio, 1);
+ gpio_set_value_cansleep(dssdev->reset_gpio, 1);
return 0;
}

static void devkit8000_panel_disable_dvi(struct omap_dss_device *dssdev)
{
if (gpio_is_valid(dssdev->reset_gpio))
- gpio_set_value(dssdev->reset_gpio, 0);
+ gpio_set_value_cansleep(dssdev->reset_gpio, 0);
}

static struct regulator_consumer_supply devkit8000_vmmc1_supply =
--
1.7.3.3

2010-12-21 09:17:29

by Thomas Weber

Subject: Re: [PATCH] OMAP2: Devkit8000: Use _cansleep GPIO functions for display reset lines

Am 21.12.2010 08:47, schrieb Daniel Morsing:
> The display reset lines are connected to a TPS65930 which may sleep
> when changing GPIO values. Use the appropriate function to silence
> a nasty warning from gpiolib.
>
> Signed-off-by: Daniel Morsing <[email protected]>
> ---
> arch/arm/mach-omap2/board-devkit8000.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-devkit8000.c
> b/arch/arm/mach-omap2/board-devkit8000.c
> index 53ac762..f1f58f5 100644
> --- a/arch/arm/mach-omap2/board-devkit8000.c
> +++ b/arch/arm/mach-omap2/board-devkit8000.c
> @@ -118,27 +118,27 @@ static int devkit8000_panel_enable_lcd(struct
> omap_dss_device *dssdev)
> twl_i2c_write_u8(TWL4030_MODULE_LED, 0x0, 0x0);
>
> if (gpio_is_valid(dssdev->reset_gpio))
> - gpio_set_value(dssdev->reset_gpio, 1);
> + gpio_set_value_cansleep(dssdev->reset_gpio, 1);
> return 0;
> }
>
> static void devkit8000_panel_disable_lcd(struct omap_dss_device *dssdev)
> {
> if (gpio_is_valid(dssdev->reset_gpio))
> - gpio_set_value(dssdev->reset_gpio, 0);
> + gpio_set_value_cansleep(dssdev->reset_gpio, 0);
> }
>
> static int devkit8000_panel_enable_dvi(struct omap_dss_device *dssdev)
> {
> if (gpio_is_valid(dssdev->reset_gpio))
> - gpio_set_value(dssdev->reset_gpio, 1);
> + gpio_set_value_cansleep(dssdev->reset_gpio, 1);
> return 0;
> }
>
> static void devkit8000_panel_disable_dvi(struct omap_dss_device *dssdev)
> {
> if (gpio_is_valid(dssdev->reset_gpio))
> - gpio_set_value(dssdev->reset_gpio, 0);
> + gpio_set_value_cansleep(dssdev->reset_gpio, 0);
> }
>
> static struct regulator_consumer_supply devkit8000_vmmc1_supply =
Hello Daniel,

Your patch is destroyed by gmail.
Please read Documentation/email-clients.txt

I have the same patch on my list.

So you can add an

Acked-by: Thomas Weber <[email protected]>


Regards,
Thomas

2010-12-21 10:33:30

by Daniel Morsing

Subject: Re: [PATCH] OMAP2: Devkit8000: Use _cansleep GPIO functions for display reset lines

On Tue, 2010-12-21 at 10:16 +0100, Thomas Weber wrote:
> Am 21.12.2010 08:47, schrieb Daniel Morsing:
> Hello Daniel,
>
> Your patch is destroyed by gmail.
> Please read Documentation/email-clients.txt
>
> I have the same patch on my list.
>
> So you can add an
>
> Acked-by: Thomas Weber <[email protected]>
>
>
> Regards,
> Thomas
>

Hi Thomas

Thank you for the help. I've resent the patch with a sane mail client
and your Acked-by line

Regards,
Daniel