2011-02-06 23:39:21

by Thomas Gleixner

Subject: [patch 01/10] m68knommu: 5772: Replace private irq flow handler

That handler lacks the minimal checks for action being zero etc. Keep
the weird flow - ack before handling - intact and call into
handle_simple_irq which does the right thing.

Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: Greg Ungerer <[email protected]>
LKML-Reference: <[email protected]>
---
arch/m68knommu/platform/5272/intc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

Index: linux-next/arch/m68knommu/platform/5272/intc.c
===================================================================
--- linux-next.orig/arch/m68knommu/platform/5272/intc.c
+++ linux-next/arch/m68knommu/platform/5272/intc.c
@@ -137,11 +137,8 @@ static int intc_irq_set_type(unsigned in
*/
static void intc_external_irq(unsigned int irq, struct irq_desc *desc)
{
- kstat_incr_irqs_this_cpu(irq, desc);
- desc->status |= IRQ_INPROGRESS;
desc->chip->ack(irq);
- handle_IRQ_event(irq, desc->action);
- desc->status &= ~IRQ_INPROGRESS;
+ handle_simple_irq(irq, desc);
}

static struct irq_chip intc_irq_chip = {

2011-02-08 04:50:11

by Greg Ungerer

Subject: Re: [patch 01/10] m68knommu: 5772: Replace private irq flow handler

Hi Thomas,

On 07/02/11 09:39, Thomas Gleixner wrote:
> That's a conversion to the new irq_chips and a cleanup to irq_desc
> accessor functions. Finally it sets GENERIC_HARDIRQS_NO_DEPRECATED.
>
> Warning: untested.

I am fine with all of these, so:

Acked-by: Greg Ungerer <[email protected]>

I compile tested to cover all changes, only fix was to patch 7
(as noted in reply to that patch). I can't run test to cover
all changes right at the moment, but on the one board I can try
it ran with no problems.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: [email protected]
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com

2011-02-08 04:52:46

by Greg Ungerer

Subject: Re: [patch 01/10] m68knommu: 5772: Replace private irq flow handler

Hi Thomas,

On 07/02/11 09:39, Thomas Gleixner wrote:
> That handler lacks the minimal checks for action being zero etc. Keep
> the weird flow - ack before handling - intact and call into
> handle_simple_irq which does the right thing.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Acked-by: Greg Ungerer <[email protected]>
> LKML-Reference: <[email protected]>

Nitpick, the title should read "5272" not "5772".

Regards
Greg


> ---
> arch/m68knommu/platform/5272/intc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> Index: linux-next/arch/m68knommu/platform/5272/intc.c
> ===================================================================
> --- linux-next.orig/arch/m68knommu/platform/5272/intc.c
> +++ linux-next/arch/m68knommu/platform/5272/intc.c
> @@ -137,11 +137,8 @@ static int intc_irq_set_type(unsigned in
> */
> static void intc_external_irq(unsigned int irq, struct irq_desc *desc)
> {
> - kstat_incr_irqs_this_cpu(irq, desc);
> - desc->status |= IRQ_INPROGRESS;
> desc->chip->ack(irq);
> - handle_IRQ_event(irq, desc->action);
> - desc->status &= ~IRQ_INPROGRESS;
> + handle_simple_irq(irq, desc);
> }
>
> static struct irq_chip intc_irq_chip = {

--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: [email protected]
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com