Subject: fused X86_UP_APIC and X86_UP_IOAPIC ?

Hi there,

In commit 7cd92366a593246650cc7d6198e2c7d3af8c1d8a (x86/Voyager: remove APIC/IO-APIC Kbuild quirk / just before 2.6.29-rc4)
Ingo replaced the X86_UP_IOAPIC with X86_UP_APIC.

Was this intended ord by accident?


Greets,
Henrik Kretzschmar





2011-02-10 12:18:46

by Ingo Molnar

[permalink] [raw]
Subject: Re: fused X86_UP_APIC and X86_UP_IOAPIC ?


* Henrik Kretzschmar <[email protected]> wrote:

> Hi there,
>
> In commit 7cd92366a593246650cc7d6198e2c7d3af8c1d8a (x86/Voyager: remove
> APIC/IO-APIC Kbuild quirk / just before 2.6.29-rc4) Ingo replaced the
> X86_UP_IOAPIC with X86_UP_APIC.
>
> Was this intended or by accident?

Looks accidental. Wondering why it didn't cause problems. Mind sending a patch
against the latest x86 tree:

http://people.redhat.com/mingo/tip.git/README

Thanks,

Ingo

2011-02-12 09:13:20

by Henrik Kretzschmar

[permalink] [raw]
Subject: Re: fused X86_UP_APIC and X86_UP_IOAPIC ?

Am 10.02.2011 11:35, schrieb Henrik Kretzschmar:
>> In commit 7cd92366a593246650cc7d6198e2c7d3af8c1d8a (x86/Voyager: remove APIC/IO-APIC Kbuild quirk / just before 2.6.29-rc4)
>> Ingo replaced the X86_UP_IOAPIC with X86_UP_APIC.
>>
>> Was this intended ord by accident?

* Ingo Molnar <[email protected]> wrote:
> Mind sending a patch against the latest x86 tree.

Yes, I do, but just changing the config makes the compilation break,
so some prior steps are needed, since X86_APIC and X86_IO_APIC
have fused a bit too much.

But I'm confident.

Greets,
Henrik