2011-02-11 20:48:03

by Ayan George

[permalink] [raw]
Subject: [PATCH] dell-laptop: add Dell Vostro 1520 to blacklist.

The dell-laptop module erroneously hard-blocks the wireless interface on
the Dell Vostro 1520.

All functionality (backlight, volume, physical wireless switch, &c)
is there without the dell-laptop module so this blacklists the
Dell Vostro 1520.

BugLink: http://bugs.launchpad.net/bugs/701259
Signed-off-by: Ayan George <[email protected]>
Cc: <[email protected]>
---
drivers/platform/x86/dell-laptop.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/dell-laptop.c
b/drivers/platform/x86/dell-lapt
op.c
index 34657f9..ed889a2 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -144,6 +144,13 @@ static struct dmi_system_id __devinitdata
dell_blacklist[]
= {
DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1210"),
},
},
+ {
+ .ident = "Dell Vostro 1520",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 1520"),
+ },
+ },
{}
};

--
1.7.1


2011-02-11 20:56:38

by Matthew Garrett

[permalink] [raw]
Subject: Re: [PATCH] dell-laptop: add Dell Vostro 1520 to blacklist.

On Fri, Feb 11, 2011 at 03:47:54PM -0500, Ayan George wrote:
> The dell-laptop module erroneously hard-blocks the wireless interface on
> the Dell Vostro 1520.
>
> All functionality (backlight, volume, physical wireless switch, &c)
> is there without the dell-laptop module so this blacklists the
> Dell Vostro 1520.
>
> BugLink: http://bugs.launchpad.net/bugs/701259
> Signed-off-by: Ayan George <[email protected]>
> Cc: <[email protected]>

I'd like to try to work out what's actually going on here first. Do we
have any feedback from Dell on whether this is expected to work?

--
Matthew Garrett | [email protected]