2011-02-15 01:39:35

by wwang

Subject: [PATCH] usb_storage: realtek_cr patch: fix sparse warning

From: wwang <[email protected]>

Fix some sparse warning for realtek_cr patch

Signed-off-by: wwang <[email protected]>
---
drivers/usb/storage/realtek_cr.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
index c2bebb3..4f6b25f 100644
--- a/drivers/usb/storage/realtek_cr.c
+++ b/drivers/usb/storage/realtek_cr.c
@@ -141,7 +141,7 @@ static int init_realtek_cr(struct us_data *us);
.driver_info = (flags)|(USB_US_TYPE_STOR<<24)\
}

-struct usb_device_id realtek_cr_ids[] = {
+static struct usb_device_id realtek_cr_ids[] = {
# include "unusual_realtek.h"
{ } /* Terminating entry */
};
@@ -570,7 +570,7 @@ static void realtek_cr_destructor(void *extra)
}

#ifdef CONFIG_PM
-void realtek_pm_hook(struct us_data *us, int pm_state)
+static void realtek_pm_hook(struct us_data *us, int pm_state)
{
if (pm_state == US_SUSPEND)
(void)config_autodelink_before_power_down(us);
--
1.7.4

2011-02-15 08:50:58

by Jiri Slaby

Subject: Re: [PATCH] usb_storage: realtek_cr patch: fix sparse warning

On 02/15/2011 02:38 AM, [email protected] wrote:
> From: wwang <[email protected]>
>
> Fix some sparse warning for realtek_cr patch
>
> Signed-off-by: wwang <[email protected]>
> ---
> drivers/usb/storage/realtek_cr.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
> index c2bebb3..4f6b25f 100644
> --- a/drivers/usb/storage/realtek_cr.c
> +++ b/drivers/usb/storage/realtek_cr.c
> @@ -141,7 +141,7 @@ static int init_realtek_cr(struct us_data *us);
> .driver_info = (flags)|(USB_US_TYPE_STOR<<24)\
> }
>
> -struct usb_device_id realtek_cr_ids[] = {
> +static struct usb_device_id realtek_cr_ids[] = {

And it may be const too while you are at it...

regards,
--
js