2011-02-17 15:46:48

by Jan Beulich

Subject: [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()

show_regs() already prints two(!) stack traces, no need for a third one.

Signed-off-by: Jan Beulich <[email protected]>

---
arch/x86/kernel/apic/hw_nmi.c | 1 -
1 file changed, 1 deletion(-)

--- 2.6.38-rc5/arch/x86/kernel/apic/hw_nmi.c
+++ 2.6.38-rc5-x86-backtrace-all-no-dump_stack/arch/x86/kernel/apic/hw_nmi.c
@@ -83,7 +83,6 @@ arch_trigger_all_cpu_backtrace_handler(s
arch_spin_lock(&lock);
printk(KERN_WARNING "NMI backtrace for cpu %d\n", cpu);
show_regs(regs);
- dump_stack();
arch_spin_unlock(&lock);
cpumask_clear_cpu(cpu, to_cpumask(backtrace_mask));
return NOTIFY_STOP;

2011-02-18 07:44:49

by Ingo Molnar

Subject: Re: [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()

* Jan Beulich <[email protected]> wrote:

> show_regs() already prints two(!) stack traces, [...]

That ought to get fixed as well, right?

> no need for a third one.

Agreed.

Thanks,

Ingo

2011-02-18 07:59:01

by Jan Beulich

Subject: Re: [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()

>>> On 18.02.11 at 08:44, Ingo Molnar <[email protected]> wrote:

> * Jan Beulich <[email protected]> wrote:
>
>> show_regs() already prints two(!) stack traces, [...]
>
> That ought to get fixed as well, right?

Yes, I'm intending to send a patch for that as a follow-up.

Jan

2011-02-18 10:40:04

by Jan Beulich

Subject: [tip:x86/debug] x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()

Commit-ID: bb3e6251a69e67d7620373ee18e35b404964273e
Gitweb: http://git.kernel.org/tip/bb3e6251a69e67d7620373ee18e35b404964273e
Author: Jan Beulich <[email protected]>
AuthorDate: Thu, 17 Feb 2011 15:47:37 +0000
Committer: Ingo Molnar <[email protected]>
CommitDate: Fri, 18 Feb 2011 08:52:29 +0100

x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()

show_regs() already prints two(!) stack traces, no need for a third one.

Signed-off-by: Jan Beulich <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/kernel/apic/hw_nmi.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index 79fd43c..c4e557a 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -83,7 +83,6 @@ arch_trigger_all_cpu_backtrace_handler(struct notifier_block *self,
arch_spin_lock(&lock);
printk(KERN_WARNING "NMI backtrace for cpu %d\n", cpu);
show_regs(regs);
- dump_stack();
arch_spin_unlock(&lock);
cpumask_clear_cpu(cpu, to_cpumask(backtrace_mask));
return NOTIFY_STOP;