2011-03-03 01:27:48

by Andrew Morton

[permalink] [raw]
Subject: mmotm 2011-03-02-16-52 uploaded

The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to

http://userweb.kernel.org/~akpm/mmotm/

and will soon be available at

git://zen-kernel.org/kernel/mmotm.git

It contains the following patches against 2.6.38-rc7:

drivers-rtc-rtc-s3cc-fix-prototype-for-s3c_rtc_setaie.patch
cpuset-add-a-missing-unlock-in-cpuset_write_resmask.patch
cpuset-add-a-missing-unlock-in-cpuset_write_resmask-fix.patch
misc-bmp085-add-module_device_table.patch
backlight-new-driver-for-the-adp8870-backlight-devices.patch
pps-make-pps_gen_parport-depend-on-broken.patch
linux-next.patch
next-remove-localversion.patch
i-need-old-gcc.patch
arch-alpha-kernel-systblss-remove-debug-check.patch
include-asm-generic-vmlinuxldsh-fix-__modver-section-warnings.patch
drivers-usb-serial-usb_wwanc-unbork.patch
drivers-misc-apds9802alsc-put-the-device-into-runtime-suspend-after-resume-probe-is-handled.patch
mm-vmap-area-cache.patch
drivers-media-video-tlg2300-pd-videoc-fix-double-mutex_unlock-in-pd_vidioc_s_fmt.patch
rxrpc-fix-v1-keys.patch
x86-fix-pgd_lock-deadlock.patch
acerhdf-add-support-for-aspire-1410-bios-v13314.patch
arch-x86-kernel-microcode_corec-do-not-warn_oncpu-=-0-during-resume.patch
arch-x86-include-asm-delayh-fix-udelay-and-ndelay-for-8-bit-args.patch
x86-fix-mmap-random-address-range.patch
msm-timer-migrate-to-timer-based-__delay.patch
audit-always-follow-va_copy-with-va_end.patch
fs-btrfs-inodec-eliminate-memory-leak.patch
btrfs-dont-dereference-extent_mapping-if-null.patch
drivers-dma-ipu-ipu_irqc-irq_data-conversion.patch
drivers-gpu-drm-radeon-atomc-fix-warning.patch
fb-fix-potential-deadlock-between-lock_fb_info-and-console_lock.patch
cyber2000fb-avoid-palette-corruption-at-higher-clocks.patch
leds-convert-bd2802-driver-to-dev_pm_ops.patch
leds-convert-bd2802-driver-to-dev_pm_ops-fix.patch
leds-add-driver-for-lm3530-als.patch
leds-add-driver-for-lm3530-als-update.patch
drivers-leds-leds-pca9532c-add-gpio-capability.patch
leds-make-struct-gpio_led_platform_dataleds-const.patch
drivers-vidfeo-backlight-ld9040-amoled-driver-support.patch
leds-route-kbd-leds-through-the-generic-leds-layer.patch
drivers-mtd-maps-ts5500_flashc-avoid-calling-map_destroy-on-null.patch
backlight-add-backlight-type.patch
backlight-add-backlight-type-fix.patch
backlight-add-backlight-type-fix-fix.patch
i915-add-native-backlight-control.patch
radeon-expose-backlight-class-device-for-legacy-lvds-encoder.patch
radeon-expose-backlight-class-device-for-legacy-lvds-encoder-update.patch
nouveau-change-the-backlight-parent-device-to-the-connector-not-the-pci-dev.patch
acpi-tie-acpi-backlight-devices-to-pci-devices-if-possible.patch
mbp_nvidia_bl-remove-dmi-dependency.patch
mbp_nvidia_bl-check-that-the-backlight-control-functions.patch
mbp_nvidia_bl-rename-to-apple_bl.patch
backlight-apple_bl-depends-on-acpi.patch
drivers-video-backlight-jornada720_c-make-needlessly-global-symbols-static.patch
btusb-patch-add_apple_macbookpro62.patch
drivers-message-fusion-mptsasc-fix-warning.patch
scsi-fix-a-header-to-include-linux-typesh.patch
drbd-fix-warning.patch
block-fix-kernel-doc-format-for-blkdev_issue_zeroout.patch
usb-yurex-recognize-generalkeys-wireless-presenter-as-generic-hid.patch
mm.patch
mm-compaction-check-migrate_pagess-return-value-instead-of-list_empty.patch
mm-numa-aware-alloc_task_struct_node.patch
mm-numa-aware-alloc_thread_info_node.patch
kthread-numa-aware-kthread_create_on_cpu.patch
kthread-use-kthread_create_on_cpu.patch
oom-suppress-nodes-that-are-not-allowed-from-meminfo-on-oom-kill.patch
oom-suppress-show_mem-for-many-nodes-in-irq-context-on-page-alloc-failure.patch
oom-suppress-nodes-that-are-not-allowed-from-meminfo-on-page-alloc-failure.patch
mm-notifier_from_errno-cleanup.patch
mm-remove-unused-token-argument-from-apply_to_page_range-callback.patch
mm-add-apply_to_page_range_batch.patch
ioremap-use-apply_to_page_range_batch-for-ioremap_page_range.patch
vmalloc-use-plain-pte_clear-for-unmaps.patch
vmalloc-use-apply_to_page_range_batch-for-vunmap_page_range.patch
vmalloc-use-apply_to_page_range_batch-for-vmap_page_range_noflush.patch
vmalloc-use-apply_to_page_range_batch-in-alloc_vm_area.patch
xen-mmu-use-apply_to_page_range_batch-in-xen_remap_domain_mfn_range.patch
xen-grant-table-use-apply_to_page_range_batch.patch
mm-allow-gup-to-fail-instead-of-waiting-on-a-page.patch
mm-allow-gup-to-fail-instead-of-waiting-on-a-page-fix.patch
mm-add-replace_page_cache_page-function.patch
mm-add-replace_page_cache_page-function-add-freepage-hook.patch
mm-introduce-delete_from_page_cache.patch
mm-hugetlbfs-change-remove_from_page_cache.patch
mm-shmem-change-remove_from_page_cache.patch
mm-truncate-change-remove_from_page_cache.patch
mm-good-bye-remove_from_page_cache.patch
mm-change-__remove_from_page_cache.patch
mm-batch-free-pcp-list-if-possible.patch
mm-batch-free-pcp-list-if-possible-fix.patch
mm-debug-pagealloc-fix-kconfig-dependency-warning.patch
mm-rename-drop_anon_vma-to-put_anon_vma.patch
mm-move-anon_vma-ref-out-from-under-config_foo.patch
mm-simplify-anon_vma-refcounts.patch
mm-remove-unused-testsetpagelocked-interface.patch
mm-mm_struct-remove-16-bytes-of-alignment-padding-on-64-bit-builds.patch
mm-deactivate-invalidated-pages.patch
memcg-move-memcg-reclaimable-page-into-tail-of-inactive-list.patch
mm-reclaim-invalidated-page-asap.patch
pagewalk-only-split-huge-pages-when-necessary.patch
pagewalk-only-split-huge-pages-when-necessary-checkpatch-fixes.patch
smaps-break-out-smaps_pte_entry-from-smaps_pte_range.patch
smaps-pass-pte-size-argument-in-to-smaps_pte_entry.patch
smaps-teach-smaps_pte_range-about-thp-pmds.patch
smaps-have-smaps-show-transparent-huge-pages.patch
mempolicy-remove-redundant-check-in-__mpol_equal.patch
mm-vmscan-kswapd-should-not-free-an-excessive-number-of-pages-when-balancing-small-zones.patch
hugetlbfs-correct-handling-of-negative-input-to-proc-sys-vm-nr_hugepages.patch
mm-remove-worrying-dead-code-from-find_get_pages.patch
mm-dont-return-0-too-early-from-find_get_pages.patch
mm-compaction-minimise-the-time-irqs-are-disabled-while-isolating-free-pages.patch
mm-compaction-minimise-the-time-irqs-are-disabled-while-isolating-pages-for-migration.patch
mm-compaction-minimise-the-time-irqs-are-disabled-while-isolating-pages-for-migration-fix.patch
ksm-add-vm_stat-and-meminfo-entry-to-reflect-pte-mapping-to-ksm-pages.patch
ksm-add-vm_stat-and-meminfo-entry-to-reflect-pte-mapping-to-ksm-pages-fix.patch
ksm-add-vm_stat-and-meminfo-entry-to-reflect-pte-mapping-to-ksm-pages-fix-fix.patch
memsw-remove-noswapaccount-kernel-parameter.patch
xattrh-expose-string-defines-to-userspace.patch
frv-duplicate-output_buffer-of-e03.patch
frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch
hpet-factor-timer-allocate-from-open.patch
arch-alpha-include-asm-ioh-s-extern-inline-static-inline.patch
uml-kernels-on-i386x86_64-produce-bad-coredumps.patch
add-the-common-dma_addr_t-typedef-to-include-linux-typesh.patch
fs-use-appropriate-printk-priority-level.patch
include-linux-compiler-gcch-unify-macro-definitions.patch
fsh-remove-8-bytes-of-padding-from-block_device-on-64bit-builds.patch
fs-inode-fix-kernel-doc-format-for-inode_init_owner.patch
fs-locksc-remove-stale-fixme-left-over-from-bkl-conversion.patch
bh1780gli-convert-to-dev-pm-ops.patch
bh1780gli-convert-to-dev-pm-ops-update.patch
drivers-misc-bmp085c-free-initmem-memory.patch
st-spear-pcie-gadget-suppport.patch
move-x86-specific-oops=panic-to-generic-code.patch
include-linux-errh-add-a-function-to-cast-error-pointers-to-a-return-value.patch
smp-move-smp-setup-functions-to-kernel-smpc.patch
kernel-cpuc-fix-many-errors-related-to-style.patch
kernel-cpuc-fix-many-errors-related-to-style-fix.patch
llist-add-kconfig-option-arch_have_nmi_safe_cmpxchg.patch
llist-lib-add-lock-less-null-terminated-single-list.patch
llist-irq_work-use-llist-in-irq_work.patch
llist-net-rds-replace-xlist-in-net-rds-xlisth-with-llist.patch
sys_unshare-remove-the-dead-clone_thread-sighand-vm-code.patch
net-convert-%p-usage-to-%pk.patch
vsprintf-neaten-%pk-kptr_restrict-save-a-bit-of-code-space.patch
console-allow-to-retain-boot-console-via-boot-option-keep_bootcon.patch
console-prevent-registered-consoles-from-dumping-old-kernel-message-over-again.patch
printk-use-%pk-for-proc-kallsyms-and-proc-modules.patch
printk-allow-setting-default_message_level-via-kconfig.patch
vfs-ignore-error-on-forced-remount.patch
vfs-keep-list-of-mounts-for-each-superblock.patch
vfs-protect-remounting-superblock-read-only.patch
vfs-fs_may_remount_ro-turn-unnecessary-check-into-a-warn_on.patch
fs-ioctlc-remove-unnecessary-variable.patch
get_maintainerpl-allow-k-pattern-tests-to-match-non-patch-text.patch
maintainers-add-topgit-for-t.patch
maintainers-quote-non-alphanumeric-email-addresses.patch
maintainers-update-adp5520-pattern.patch
maintainers-change-web-links-from-wiki-analog-to-wikianalog.patch
maintainers-remove-asoc-codec-drivers-files-not-in-tree.patch
maintainers-add-missing-after-hr-timers-f-tag.patch
maintainers-remove-unnecessary-linux-kernel-vgerkernelorg-entries.patch
maintainers-update-clkdev-location.patch
maintainers-update-media-path.patch
maintainers-remove-unused-clockeventsh.patch
maintainers-remove-ieee1394-entry.patch
maintainers-remove-unused-timekeeping-timekeepingh.patch
maintainers-update-scx200-file-pattern.patch
maintainers-remove-sharp-lh7a40x-section.patch
maintainers-update-sfi-pattern.patch
maintainers-update-tipc-patterns.patch
maintainers-usb-se401-moved-to-staging-update-pattern.patch
maintainers-update-winbond-cir-pattern.patch
lib-vsprintf-optimised-put_dec-function.patch
lib-vsprintf-optimised-put_dec-function-fix.patch
lib-vsprintf-added-a-put_dec-test-and-benchmark-tool.patch
kstrto-converting-strings-to-integers-done-hopefully-right.patch
sigma-firmware-loader-for-analog-devices-sigmastudio.patch
sigma-firmware-loader-for-analog-devices-sigmastudio-v2.patch
drivers-mmc-host-omapc-use-resource_size.patch
drivers-mmc-host-omap_hsmmcc-use-resource_size.patch
scripts-checkpatchpl-reset-rpt_cleaners-warnings.patch
crc32-add-missed-brackets-in-macro.patch
select-remove-unused-max_select_seconds.patch
epoll-move-ready-event-check-into-proper-inline.patch
epoll-fix-compiler-warning-and-optimize-the-non-blocking-path.patch
epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix.patch
binfmt_elf-quiet-gcc-46-set-but-not-used-warning-in-load_elf_binary.patch
lib-hexdumpc-make-hex2bin-return-the-updated-src-address.patch
fs-binfmt_miscc-use-kernels-hex_to_bin-method.patch
fs-binfmt_miscc-use-kernels-hex_to_bin-method-fix.patch
fs-binfmt_miscc-use-kernels-hex_to_bin-method-fix-fix.patch
init-return-proper-error-code-in-do_mounts_rd.patch
rtc-add-support-for-the-rtc-in-via-vt8500-and-compatibles.patch
rtc-convert-ds1374-to-dev_pm_ops.patch
rtc-include-information-about-uie-and-pie-in-rtc-driver-proc.patch
rtc-add-real-time-clock-driver-for-nvidia-tegra.patch
gpio-add-new-altera-pio-driver.patch
gpio-add-new-altera-pio-driver-update.patch
gpio-make-gpio_requestfree_array-gpio-array-parameter-const.patch
pnp-only-assign-ioresource_dma-if-config_isa_dma_api-is-enabled.patch
x86-only-compile-8237a-if-config_isa_dma_api-is-enabled.patch
x86-only-compile-floppy-driver-if-config_isa_dma_api-is-enabled.patch
x86-allow-config_isa_dma_api-to-be-disabled.patch
jbd-remove-dependency-on-__gfp_nofail.patch
documentation-codingstyle-flesh-out-if-else-examples.patch
cgroup-remove-the-ns_cgroup.patch
memcg-res_counter_read_u64-fix-potential-races-on-32-bit-machines.patch
memcg-fix-ugly-initialization-of-return-value-is-in-caller.patch
memcg-soft-limit-reclaim-should-end-at-limit-not-below.patch
memcg-simplify-the-way-memory-limits-are-checked.patch
memcg-remove-unused-page-flag-bitfield-defines.patch
memcg-remove-impossible-conditional-when-committing.patch
memcg-remove-null-check-from-lookup_page_cgroup-result.patch
memcg-add-memcg-sanity-checks-at-allocating-and-freeing-pages.patch
memcg-add-memcg-sanity-checks-at-allocating-and-freeing-pages-update.patch
memcg-add-memcg-sanity-checks-at-allocating-and-freeing-pages-update-fix.patch
memcg-no-uncharged-pages-reach-page_cgroup_zoneinfo.patch
memcg-change-page_cgroup_zoneinfo-signature.patch
memcg-fold-__mem_cgroup_move_account-into-caller.patch
memcg-condense-page_cgroup-to-page-lookup-points.patch
memcg-remove-direct-page_cgroup-to-page-pointer.patch
memcg-remove-direct-page_cgroup-to-page-pointer-fix.patch
memcg-remove-direct-page_cgroup-to-page-pointer-fix-fix.patch
memcg-charged-pages-always-have-valid-per-memcg-zone-info.patch
memcg-remove-memcg-reclaim_param_lock.patch
memcg-keep-only-one-charge-cancelling-function.patch
memcg-keep-only-one-charge-cancelling-function-fix.patch
memcg-convert-per-cpu-stock-from-bytes-to-page-granularity.patch
memcg-convert-uncharge-batching-from-bytes-to-page-granularity.patch
memcg-unify-charge-uncharge-quantities-to-units-of-pages.patch
memcg-break-out-event-counters-from-other-stats.patch
memcg-use-native-word-page-statistics-counters.patch
mm-memcontrolc-suppress-uninitializer-var-warning-with-older-gccs.patch
cpuset-remove-unneeded-nodemask_alloc-in-cpuset_sprintf_memlist.patch
cpuset-remove-unneeded-nodemask_alloc-in-cpuset_sprintf_memlist-v2.patch
cpuset-remove-unneeded-nodemask_alloc-in-cpuset_attch.patch
cpuset-fix-unchecked-calls-to-nodemask_alloc.patch
cpuset-fix-unchecked-calls-to-nodemask_alloc-v2.patch
cpuset-hold-callback_mutex-in-cpuset_clone.patch
proc-hide-kernel-addresses-via-%pk-in-proc-pid-stack.patch
char-ipmi-fix-cleanup_one_si-section-mismatch.patch
drivers-char-add-msm-smd_pkt-driver.patch
drivers-char-bfin_jtag_commc-avoid-calling-put_tty_driver-on-null.patch
drivers-char-specialixc-convert-func_enter-to-func_exit.patch
drivers-char-memc-clean-up-the-code.patch
rapidio-add-new-sysfs-attributes.patch
rapidio-add-new-sysfs-attributes-v2.patch
rapidio-add-rapidio-documentation.patch
rapidio-add-rapidio-documentation-v2.patch
rapidio-add-architecture-specific-callbacks.patch
rapidio-modify-configuration-to-support-pci-srio-controller.patch
rapidio-modify-subsystem-and-driver-initialization-sequence.patch
rapidio-modify-mport-id-assignment.patch
rapidio-remove-mport-resource-reservation-from-common-rio-code.patch
sysctl_check-drop-table-procname-checks.patch
sysctl_check-drop-dead-code.patch
pid-remove-the-child_reaper-special-case-in-init-mainc.patch
pidns-call-pid_ns_prepare_proc-from-create_pid_namespace.patch
procfs-kill-the-global-proc_mnt-variable.patch
userns-add-a-user_namespace-as-creator-owner-of-uts_namespace.patch
userns-security-make-capabilities-relative-to-the-user-namespace.patch
userns-security-make-capabilities-relative-to-the-user-namespace-fix.patch
userns-security-make-capabilities-relative-to-the-user-namespace-fix-fix.patch
userns-allow-sethostname-in-a-container.patch
userns-allow-killing-tasks-in-your-own-or-child-userns.patch
userns-allow-ptrace-from-non-init-user-namespaces.patch
userns-user-namespaces-convert-all-capable-checks-in-kernel-sysc.patch
userns-add-a-user-namespace-owner-of-ipc-ns.patch
userns-user-namespaces-convert-several-capable-calls.patch
userns-user-namespaces-convert-several-capable-calls-checkpatch-fixes.patch
userns-userns-check-user-namespace-for-task-file-uid-equivalence-checks.patch
userns-userns-check-user-namespace-for-task-file-uid-equivalence-checks-checkpatch-fixes.patch
userns-rename-is_owner_or_cap-to-inode_owner_or_capable.patch
userns-rename-is_owner_or_cap-to-inode_owner_or_capable-fix.patch
userns-rename-is_owner_or_cap-to-inode_owner_or_capable-fix-fix.patch
fs-execc-provide-the-correct-process-pid-to-the-pipe-helper.patch
taskstats-use-appropriate-printk-priority-level.patch
kernel-gcov-makefile-use-proper-ccflag-flag-in-makefile.patch
remove-dma64_addr_t.patch
adfs-fix-e-f-dir-size-2048-crashing-kernel.patch
adfs-improve-timestamp-precision.patch
adfs-add-hexadecimal-filetype-suffix-option.patch
pps-remove-unreachable-code.patch
scatterlist-new-helper-functions.patch
memstick-add-driver-for-ricoh-r5c592-card-reader.patch
memstick-add-support-for-legacy-memorysticks.patch
memstick-add-support-for-legacy-memorysticks-update.patch
memstick-add-alex-dubov-to-maintainers-of-the-memstick-core.patch
crash_dump-export-is_kdump_kernel-to-modules-consolidate-elfcorehdr_addr-setup_elfcorehdr-and-saved_max_pfn.patch
crash_dump-export-is_kdump_kernel-to-modules-consolidate-elfcorehdr_addr-setup_elfcorehdr-and-saved_max_pfn-fix.patch
crash_dump-export-is_kdump_kernel-to-modules-consolidate-elfcorehdr_addr-setup_elfcorehdr-and-saved_max_pfn-fix-fix.patch
crash_dump-export-is_kdump_kernel-to-modules-consolidate-elfcorehdr_addr-setup_elfcorehdr-and-saved_max_pfn-fix-fix-fix.patch
kexec-remove-kmsg_dump_kexec.patch
fs-devpts-inodec-correctly-check-d_alloc_name-return-code-in-devpts_pty_new.patch
fs-devpts_pty_new-return-enomem-if-dentry-allocation-failed.patch
kvm-stop-including-asm-generic-bitops-leh-directly.patch
rds-stop-including-asm-generic-bitops-leh-directly.patch
bitops-merge-little-and-big-endian-definisions-in-asm-generic-bitops-leh.patch
asm-generic-rename-generic-little-endian-bitops-functions.patch
asm-generic-change-little-endian-bitops-to-take-any-pointer-types.patch
asm-generic-change-little-endian-bitops-to-take-any-pointer-types-convert-little-endian-bitops-macros-to-static-inline-functions.patch
powerpc-introduce-little-endian-bitops.patch
powerpc-introduce-little-endian-bitops-convert-little-endian-bitops-macros-to-static-inline-functions.patch
s390-introduce-little-endian-bitops.patch
s390-introduce-little-endian-bitops-convert-little-endian-bitops-macros-to-static-inline-functions.patch
arm-introduce-little-endian-bitops.patch
arm-introduce-little-endian-bitops-convert-little-endian-bitops-macros-to-static-inline-functions.patch
m68k-introduce-little-endian-bitops.patch
m68k-introduce-little-endian-bitops-convert-little-endian-bitops-macros-to-static-inline-functions.patch
bitops-introduce-config_generic_find_bit_le.patch
m68knommu-introduce-little-endian-bitops.patch
m68knommu-introduce-little-endian-bitops-convert-little-endian-bitops-macros-to-static-inline-functions.patch
bitops-introduce-little-endian-bitops-for-most-architectures.patch
asm-generic-use-little-endian-bitops.patch
kvm-use-little-endian-bitops.patch
rds-use-little-endian-bitops.patch
ext3-use-little-endian-bitops.patch
ext4-use-little-endian-bitops.patch
ocfs2-use-little-endian-bitops.patch
nilfs2-use-little-endian-bitops.patch
reiserfs-use-little-endian-bitops.patch
udf-use-little-endian-bitops.patch
ufs-use-little-endian-bitops.patch
md-use-little-endian-bitops.patch
dm-use-little-endian-bitops.patch
bitops-remove-ext2-non-atomic-bitops-from-asm-bitopsh.patch
m68k-remove-inline-asm-from-minix_find_first_zero_bit.patch
bitops-remove-minix-bitops-from-asm-bitopsh.patch
make-sure-nobodys-leaking-resources.patch
journal_add_journal_head-debug.patch
releasing-resources-with-children.patch
make-frame_pointer-default=y.patch
mutex-subsystem-synchro-test-module.patch
mutex-subsystem-synchro-test-module-add-missing-header-file.patch
slab-leaks3-default-y.patch
put_bh-debug.patch
add-debugging-aid-for-memory-initialisation-problems.patch
workaround-for-a-pci-restoring-bug.patch
prio_tree-debugging-patch.patch
single_open-seq_release-leak-diagnostics.patch
add-a-refcount-check-in-dput.patch
memblock-add-input-size-checking-to-memblock_find_region.patch
memblock-add-input-size-checking-to-memblock_find_region-fix.patch


2011-03-03 02:05:46

by Stephen Rothwell

[permalink] [raw]
Subject: Re: mmotm 2011-03-02-16-52 uploaded

Hi Andrew,

On Wed, 02 Mar 2011 16:52:55 -0800 [email protected] wrote:
>
> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/

If you create your linux-next.patch using kapm-start..kapm-end in the
linux-next tree, you will save about 8000+ lines of patch and you won't
need "next-remove-localversion.patch" any more. I am keeping those
references up to date each day.

BTW, To keep "git am" happy:

diff --git a/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
index e081c43..42c45fc 100644
--- a/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
+++ b/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
@@ -1,3 +1,4 @@
+From: Johannes Weiner <[email protected]>

Keep the underscore-version of the charge cancelling function which took a
page count, rather than silently changing the semantics of the

Cheers,
Stephen Rothwell


Attachments:
(No filename) (960.00 B)
(No filename) (490.00 B)
Download all attachments

2011-03-03 02:17:22

by Andrew Morton

[permalink] [raw]
Subject: Re: mmotm 2011-03-02-16-52 uploaded

On Thu, 3 Mar 2011 13:05:38 +1100 Stephen Rothwell <[email protected]> wrote:

> Hi Andrew,
>
> On Wed, 02 Mar 2011 16:52:55 -0800 [email protected] wrote:
> >
> > The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> If you create your linux-next.patch using kapm-start..kapm-end in the
> linux-next tree, you will save about 8000+ lines of patch and you won't
> need "next-remove-localversion.patch" any more. I am keeping those
> references up to date each day.

What's in the 8000 lines?

> BTW, To keep "git am" happy:
>
> diff --git a/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
> index e081c43..42c45fc 100644
> --- a/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
> +++ b/broken-out/memcg-keep-only-one-charge-cancelling-function-fix.patch
> @@ -1,3 +1,4 @@
> +From: Johannes Weiner <[email protected]>
>
> Keep the underscore-version of the charge cancelling function which took a
> page count, rather than silently changing the semantics of the
>

Didn't understand that - why is git-am unhappy? Your sentence was
truncated.

2011-03-03 02:31:08

by Stephen Rothwell

[permalink] [raw]
Subject: Re: mmotm 2011-03-02-16-52 uploaded

Hi Andrew,

On Wed, 2 Mar 2011 18:17:11 -0800 Andrew Morton <[email protected]> wrote:
>
> What's in the 8000 lines?

Just the localversion-next file and the stuff in the "Next" directory ...
meta information about the linux-next tree.

> Didn't understand that - why is git-am unhappy? Your sentence was
> truncated.

It didn't recognise the patch format since it wants an email-like patch
(with a From line to show the author).

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (543.00 B)
(No filename) (490.00 B)
Download all attachments

2011-03-03 08:26:22

by Sedat Dilek

[permalink] [raw]
Subject: Re: mmotm 2011-03-02-16-52 uploaded

On Thu, Mar 3, 2011 at 1:52 AM, <[email protected]> wrote:
> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
>   http://userweb.kernel.org/~akpm/mmotm/
>
> and will soon be available at
>
>   git://zen-kernel.org/kernel/mmotm.git
>
> It contains the following patches against 2.6.38-rc7:
>
[...]
> backlight-add-backlight-type.patch
> backlight-add-backlight-type-fix.patch
> backlight-add-backlight-type-fix-fix.patch
> i915-add-native-backlight-control.patch
> radeon-expose-backlight-class-device-for-legacy-lvds-encoder.patch
> radeon-expose-backlight-class-device-for-legacy-lvds-encoder-update.patch
> nouveau-change-the-backlight-parent-device-to-the-connector-not-the-pci-dev.patch
> acpi-tie-acpi-backlight-devices-to-pci-devices-if-possible.patch
> mbp_nvidia_bl-remove-dmi-dependency.patch
> mbp_nvidia_bl-check-that-the-backlight-control-functions.patch
> mbp_nvidia_bl-rename-to-apple_bl.patch
> backlight-apple_bl-depends-on-acpi.patch
> drivers-video-backlight-jornada720_c-make-needlessly-global-symbols-static.patch
[...]

And Sedat asked and is asking again for backlight (acpi + drm-2.6)
patches to go into 2.6.39...

There were 5 patches from Matthew Garrett...
IIRC you told me you took over backlight stuff from Richard Purdie
(hope I recall the name correctly).
First it is a bit hard for me to assign your changed patch names to
the original ones.
There are patches from your tree being recognised for linux-next...
What's up with the backlight ones?
Unfortunately, the last working linux-next (next-20110224) and the
patchset (I have maintained here) do not apply due to recent changes
in linux-next this week.
(Mostly the big patch 1-5 required adaptation to fit linux-next.)
And yes, I am a bit sick of it, so I kicked them for now.

I am not sure what is the ideal way to let these 5 patches (and more?)
go into linux-next (aka for-2.6.39)
But for the mentionned patchset platform-drivers-x86.git#linux-next
could be a good choice (it is automatically pulled into linux-next),
but this would mean Matthew has to do the work...

Anyway, I want to see this patchset in 2.6.39.

BTW, the below listed patchset was take #2 from Matthew.
I am sure take #3 will make me and others happy :-).

- Sedat -

$ ls -lR backlight-type/
backlight-type/:
insgesamt 80
-rw-r--r-- 1 sd sd 39541 23. Feb 09:19 1-5-Backlight-Add-backlight-type-v6.patch
-rw-r--r-- 1 sd sd 7389 15. Jan 15:18
2-5-i915-Add-native-backlight-control.patch
-rw-r--r-- 1 sd sd 7083 15. Jan 15:19
4-5-nouveau-Change-the-backlight-parent-device-to-the-connector-not-the-PCI-dev.patch
-rw-r--r-- 1 sd sd 2040 15. Jan 15:19
5-5-ACPI-Tie-ACPI-backlight-devices-to-PCI-devices-if-possible.patch
-rw-r--r-- 1 sd sd 13723 20. Jan 20:56
drm-radeon-kms-Expose-backlight-class-device-for-legacy-LVDS-encoder-v2.patch
drwxr-xr-x 2 sd sd 4096 8. Feb 17:39 orig

backlight-type/orig:
insgesamt 56
-rw-r--r-- 1 sd sd 39265 15. Jan 15:17 1-5-Backlight-Add-backlight-type.patch
-rw-r--r-- 1 sd sd 13905 15. Jan 15:18
3-5-radeon-Expose-backlight-class-device-for-legacy-LVDS-encoder.patch

-EOT-

2011-03-03 20:51:04

by Randy Dunlap

[permalink] [raw]
Subject: Re: mmotm 2011-03-02-16-52 uploaded (linux-next: drivers/staging/epca - missing header files)

On Wed, 02 Mar 2011 16:52:55 -0800 [email protected] wrote:

> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> and will soon be available at
>
> git://zen-kernel.org/kernel/mmotm.git
>
> It contains the following patches against 2.6.38-rc7:


Who did the (incomplete) move of some tty drivers to staging? (in linux-next)

Please also move drivers/char/digi*.h

#include "digiPCI.h"
#include "digi1.h"
#include "digiFep1.h"
=>
drivers/staging/tty/epca.c:46:21: error: digiPCI.h: No such file or directory
drivers/staging/tty/epca.c:49:19: error: digi1.h: No such file or directory
drivers/staging/tty/epca.c:50:22: error: digiFep1.h: No such file or directory

causes over 100 build errors.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

2011-03-03 21:06:54

by Greg KH

[permalink] [raw]
Subject: Re: mmotm 2011-03-02-16-52 uploaded (linux-next: drivers/staging/epca - missing header files)

On Thu, Mar 03, 2011 at 12:50:12PM -0800, Randy Dunlap wrote:
> On Wed, 02 Mar 2011 16:52:55 -0800 [email protected] wrote:
>
> > The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
> >
> > and will soon be available at
> >
> > git://zen-kernel.org/kernel/mmotm.git
> >
> > It contains the following patches against 2.6.38-rc7:
>
>
> Who did the (incomplete) move of some tty drivers to staging? (in linux-next)

That would be me :)

> Please also move drivers/char/digi*.h
>
> #include "digiPCI.h"
> #include "digi1.h"
> #include "digiFep1.h"
> =>
> drivers/staging/tty/epca.c:46:21: error: digiPCI.h: No such file or directory
> drivers/staging/tty/epca.c:49:19: error: digi1.h: No such file or directory
> drivers/staging/tty/epca.c:50:22: error: digiFep1.h: No such file or directory
>
> causes over 100 build errors.

Crap, sorry, thanks for pointing it out, will go fix this right now.

greg k-h

2011-03-03 23:52:17

by Valdis Klētnieks

[permalink] [raw]
Subject: mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card

On Wed, 02 Mar 2011 16:52:55 PST, [email protected] said:
> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/

Dell Latitude E6500, with an NVidia G98M (Quadro NVS 160M) graphics card.

Seen in my dmesg - it's had the 'Firmware Bug' message for roughly forever, but
apparently somewhere recently a warning crawled in. 2.6.38-rc5-next-20110222
did not throw the warning, jsut the firmware bug msg.

Hope somebody recognizes it, I won't be able to bisect this one for a bit (I
have 2 or 3 other things I have a bigger need to track down).

[ 0.784712] ACPI: Sleep Button [SBTN]
[ 0.816626] ------------[ cut here ]------------
[ 0.816633] WARNING: at fs/sysfs/dir.c:455 sysfs_add_one+0x88/0x9c()
[ 0.816635] Hardware name: Latitude E6500
[ 0.816637] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:01.0/0000:01:00.0/backlight/acpi_video0/device'
[ 0.816640] Modules linked in:
[ 0.816645] Pid: 1, comm: swapper Not tainted 2.6.38-rc7-mmotm0302 #2
[ 0.816647] Call Trace:
[ 0.816652] [<ffffffff8103899e>] ? warn_slowpath_common+0x7e/0x96
[ 0.816657] [<ffffffff81038a4a>] ? warn_slowpath_fmt+0x41/0x43
[ 0.816661] [<ffffffff8114d876>] ? sysfs_add_one+0x88/0x9c
[ 0.816665] [<ffffffff8114e06e>] ? sysfs_do_create_link+0x145/0x1d5
[ 0.816669] [<ffffffff8114e10c>] ? sysfs_create_link+0xe/0x10
[ 0.816674] [<ffffffff8126cef1>] ? acpi_video_device_find_cap+0x1f5/0x2de
[ 0.816678] [<ffffffff8126d196>] ? acpi_video_bus_get_one_device+0x1bc/0x250
[ 0.816682] [<ffffffff8126d3f8>] ? acpi_video_bus_add+0x1ce/0x36e
[ 0.816687] [<ffffffff8124983d>] ? acpi_device_probe+0x49/0x117
[ 0.816692] [<ffffffff812bd56b>] ? really_probe+0xc0/0x14d
[ 0.816696] [<ffffffff812bd6fe>] ? driver_probe_device+0x37/0x52
[ 0.816700] [<ffffffff812bd773>] ? __driver_attach+0x5a/0x7d
[ 0.816704] [<ffffffff812bd719>] ? __driver_attach+0x0/0x7d
[ 0.816708] [<ffffffff812bc85d>] ? bus_for_each_dev+0x54/0x88
[ 0.816712] [<ffffffff812bd319>] ? driver_attach+0x19/0x1b
[ 0.816715] [<ffffffff812bcf6d>] ? bus_add_driver+0xab/0x201
[ 0.816719] [<ffffffff812bd976>] ? driver_register+0xb2/0x11f
[ 0.816724] [<ffffffff81b3cf29>] ? acpi_video_init+0x0/0x17
[ 0.816729] [<ffffffff8124a29e>] ? acpi_bus_register_driver+0x3e/0x40
[ 0.816732] [<ffffffff8126c8c5>] ? acpi_video_register+0x1b/0x34
[ 0.816736] [<ffffffff81b3cf3e>] ? acpi_video_init+0x15/0x17
[ 0.816741] [<ffffffff8100020a>] ? do_one_initcall+0x7a/0x130
[ 0.816746] [<ffffffff81b1bc0e>] ? kernel_init+0xe1/0x15b
[ 0.816750] [<ffffffff81002f94>] ? kernel_thread_helper+0x4/0x10
[ 0.816754] [<ffffffff8102a634>] ? finish_task_switch+0x3f/0xe3
[ 0.816759] [<ffffffff8155ab44>] ? restore_args+0x0/0x30
[ 0.816763] [<ffffffff81b1bb2d>] ? kernel_init+0x0/0x15b
[ 0.816766] [<ffffffff81002f90>] ? kernel_thread_helper+0x0/0x10
[ 0.816804] ---[ end trace 6d450e935ee1897c ]---
[ 0.816808] ACPI: Create sysfs link
[ 0.817274] acpi device:38: registered as cooling_device0
[ 0.818068] input: Video Bus as /devices/LNXSYSTM:00/device:00/PNP0A03:00/device:36/LNXVIDEO:00/input/input3
[ 0.818077] ACPI: Video Device [VID] (multi-head: yes rom: no post: no)
[ 0.818236] [Firmware Bug]: Duplicate ACPI video bus devices for the same VGA controller, please try module parameter "video.allow_duplicates=1"if the current driver doesn't work.
[ 0.818369] ACPI: acpi_idle registered with cpuidle




Attachments:
(No filename) (227.00 B)

2011-03-04 00:12:23

by Greg KH

[permalink] [raw]
Subject: Re: mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card

On Thu, Mar 03, 2011 at 06:50:41PM -0500, [email protected] wrote:
> On Wed, 02 Mar 2011 16:52:55 PST, [email protected] said:
> > The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> Dell Latitude E6500, with an NVidia G98M (Quadro NVS 160M) graphics card.
>
> Seen in my dmesg - it's had the 'Firmware Bug' message for roughly forever, but
> apparently somewhere recently a warning crawled in. 2.6.38-rc5-next-20110222
> did not throw the warning, jsut the firmware bug msg.
>
> Hope somebody recognizes it, I won't be able to bisect this one for a bit (I
> have 2 or 3 other things I have a bigger need to track down).
>
> [ 0.784712] ACPI: Sleep Button [SBTN]
> [ 0.816626] ------------[ cut here ]------------
> [ 0.816633] WARNING: at fs/sysfs/dir.c:455 sysfs_add_one+0x88/0x9c()
> [ 0.816635] Hardware name: Latitude E6500
> [ 0.816637] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:01.0/0000:01:00.0/backlight/acpi_video0/device'
> [ 0.816640] Modules linked in:
> [ 0.816645] Pid: 1, comm: swapper Not tainted 2.6.38-rc7-mmotm0302 #2
> [ 0.816647] Call Trace:
> [ 0.816652] [<ffffffff8103899e>] ? warn_slowpath_common+0x7e/0x96
> [ 0.816657] [<ffffffff81038a4a>] ? warn_slowpath_fmt+0x41/0x43
> [ 0.816661] [<ffffffff8114d876>] ? sysfs_add_one+0x88/0x9c
> [ 0.816665] [<ffffffff8114e06e>] ? sysfs_do_create_link+0x145/0x1d5
> [ 0.816669] [<ffffffff8114e10c>] ? sysfs_create_link+0xe/0x10
> [ 0.816674] [<ffffffff8126cef1>] ? acpi_video_device_find_cap+0x1f5/0x2de
> [ 0.816678] [<ffffffff8126d196>] ? acpi_video_bus_get_one_device+0x1bc/0x250
> [ 0.816682] [<ffffffff8126d3f8>] ? acpi_video_bus_add+0x1ce/0x36e
> [ 0.816687] [<ffffffff8124983d>] ? acpi_device_probe+0x49/0x117
> [ 0.816692] [<ffffffff812bd56b>] ? really_probe+0xc0/0x14d
> [ 0.816696] [<ffffffff812bd6fe>] ? driver_probe_device+0x37/0x52
> [ 0.816700] [<ffffffff812bd773>] ? __driver_attach+0x5a/0x7d
> [ 0.816704] [<ffffffff812bd719>] ? __driver_attach+0x0/0x7d
> [ 0.816708] [<ffffffff812bc85d>] ? bus_for_each_dev+0x54/0x88
> [ 0.816712] [<ffffffff812bd319>] ? driver_attach+0x19/0x1b
> [ 0.816715] [<ffffffff812bcf6d>] ? bus_add_driver+0xab/0x201
> [ 0.816719] [<ffffffff812bd976>] ? driver_register+0xb2/0x11f
> [ 0.816724] [<ffffffff81b3cf29>] ? acpi_video_init+0x0/0x17
> [ 0.816729] [<ffffffff8124a29e>] ? acpi_bus_register_driver+0x3e/0x40
> [ 0.816732] [<ffffffff8126c8c5>] ? acpi_video_register+0x1b/0x34
> [ 0.816736] [<ffffffff81b3cf3e>] ? acpi_video_init+0x15/0x17
> [ 0.816741] [<ffffffff8100020a>] ? do_one_initcall+0x7a/0x130
> [ 0.816746] [<ffffffff81b1bc0e>] ? kernel_init+0xe1/0x15b
> [ 0.816750] [<ffffffff81002f94>] ? kernel_thread_helper+0x4/0x10
> [ 0.816754] [<ffffffff8102a634>] ? finish_task_switch+0x3f/0xe3
> [ 0.816759] [<ffffffff8155ab44>] ? restore_args+0x0/0x30
> [ 0.816763] [<ffffffff81b1bb2d>] ? kernel_init+0x0/0x15b
> [ 0.816766] [<ffffffff81002f90>] ? kernel_thread_helper+0x0/0x10
> [ 0.816804] ---[ end trace 6d450e935ee1897c ]---
> [ 0.816808] ACPI: Create sysfs link
> [ 0.817274] acpi device:38: registered as cooling_device0
> [ 0.818068] input: Video Bus as /devices/LNXSYSTM:00/device:00/PNP0A03:00/device:36/LNXVIDEO:00/input/input3
> [ 0.818077] ACPI: Video Device [VID] (multi-head: yes rom: no post: no)
> [ 0.818236] [Firmware Bug]: Duplicate ACPI video bus devices for the same VGA controller, please try module parameter "video.allow_duplicates=1"if the current driver doesn't work.

Have you tried this option?

There's nothing sysfs can do here, sorry, it really looks like you have
a BIOS/firmware problem.

good luck,

greg k-h

2011-03-04 04:29:31

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card

On Thu, 03 Mar 2011 16:05:50 PST, Greg KH said:

> > [ 0.818236] [Firmware Bug]: Duplicate ACPI video bus devices for the same VGA controller, please try module parameter "video.allow_duplicates=1"if the current driver doesn't work.
>
> Have you tried this option?
>
> There's nothing sysfs can do here, sorry, it really looks like you have
> a BIOS/firmware problem.

Well, (a) it's been saying "try it if the current driver doesn't work" - and
things have worked just fine all along (or more properly, if it's broken in
behavior, I haven't actually seen the effects...)

and (b) Something changed very recently to add the WARNING, which wasn't there
in rc5-next-2011022.

And (c) I doubt that's going to fix the WARNING, because looking at drivers/
acpi/video.c, the variable allow_duplicates is checked in exactly *ONE* place,
which is *after* the printk:

if (status == AE_ALREADY_EXISTS) {
printk(KERN_WARNING FW_BUG
"Duplicate ACPI video bus devices for the"
" same VGA controller, please try module "
"parameter \"video.allow_duplicates=1\""
"if the current driver doesn't work.\n");
if (!allow_duplicates)
return -ENODEV;
}

So since the warning triggers before we see the printk(), setting the variable
won't make a difference because we warn before we ever get into that if
statement.

Now, maybe we need to be checking allow_duplicates earlier and/or in other
places - but I'll let somebody who actually understands the code to decide taht. ;)


Attachments:
(No filename) (227.00 B)

2011-03-04 05:28:09

by Zhang, Rui

[permalink] [raw]
Subject: Re: mmotm 2011-03-02 - ACPI/sysfs WARNING with NVidia graphics card

On Fri, 2011-03-04 at 12:28 +0800, [email protected] wrote:
> On Thu, 03 Mar 2011 16:05:50 PST, Greg KH said:
>
> > > [ 0.818236] [Firmware Bug]: Duplicate ACPI video bus devices for the same VGA controller, please try module parameter "video.allow_duplicates=1"if the current driver doesn't work.
> >
> > Have you tried this option?
> >
> > There's nothing sysfs can do here, sorry, it really looks like you have
> > a BIOS/firmware problem.
>
right.
this warning message is printed out because there are two ACPI devices
for the same VGA controller, and Linux has no idea which can actually
change the backlight.

> Well, (a) it's been saying "try it if the current driver doesn't work" - and
> things have worked just fine all along (or more properly, if it's broken in
> behavior, I haven't actually seen the effects...)
>
> and (b) Something changed very recently to add the WARNING, which wasn't there
> in rc5-next-2011022.
>
well. c504f8cb has been shipped in 2.6.33-rc5.
can you attach the acpidump output of this machine please?
please attach the dmesg output both with and without this warning.
please attach the output of "grep . /sys/bus/acpi/drivers/video/*/path"
in both kernels.

> And (c) I doubt that's going to fix the WARNING, because looking at drivers/
> acpi/video.c, the variable allow_duplicates is checked in exactly *ONE* place,
> which is *after* the printk:
>
> if (status == AE_ALREADY_EXISTS) {
> printk(KERN_WARNING FW_BUG
> "Duplicate ACPI video bus devices for the"
> " same VGA controller, please try module "
> "parameter \"video.allow_duplicates=1\""
> "if the current driver doesn't work.\n");
> if (!allow_duplicates)
> return -ENODEV;
> }
>
> So since the warning triggers before we see the printk(), setting the variable
> won't make a difference because we warn before we ever get into that if
> statement.
>
> Now, maybe we need to be checking allow_duplicates earlier and/or in other
> places - but I'll let somebody who actually understands the code to decide taht. ;)


2011-03-04 08:56:15

by Jiri Slaby

[permalink] [raw]
Subject: tun: Failed to create tun sysfs files [was: mmotm 2011-03-02-16-52 uploaded]

On 03/03/2011 01:52 AM, [email protected] wrote:
> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to

Hi, I'm seeing this with tun (also with earlier versions):
WARNING: at fs/sysfs/dir.c:455 sysfs_add_one+0xb8/0xe0()
Hardware name: To Be Filled By O.E.M.
sysfs: cannot create duplicate filename '/devices/virtual/net/tun0/group'
Modules linked in: microcode dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
Pid: 3840, comm: openvpn Not tainted 2.6.38-rc4-mm1_64+ #1390
Call Trace:
[<ffffffff8106d61a>] ? warn_slowpath_common+0x7a/0xb0
[<ffffffff8106d6f1>] ? warn_slowpath_fmt+0x41/0x50
[<ffffffff81176638>] ? sysfs_add_one+0xb8/0xe0
[<ffffffff8117570d>] ? sysfs_add_file_mode+0x5d/0xa0
[<ffffffff8117575c>] ? sysfs_add_file+0xc/0x10
[<ffffffff81175841>] ? sysfs_create_file+0x21/0x40
[<ffffffff813609d4>] ? device_create_file+0x14/0x20
[<ffffffff813e0256>] ? tun_set_iff+0x3f6/0x4a0
[<ffffffff813e05fe>] ? __tun_chr_ioctl+0x12e/0x5d0
[<ffffffff8126c5c2>] ? __strncpy_from_user+0x22/0x60
[<ffffffff813e0ade>] ? tun_chr_ioctl+0xe/0x10
[<ffffffff811274ed>] ? do_vfs_ioctl+0x8d/0x300
[<ffffffff811277aa>] ? sys_ioctl+0x4a/0x80
[<ffffffff81030dbb>] ? system_call_fastpath+0x16/0x1b

It's because these devices already contain 'group' in the sysfs dir.

regards,
--
js
suse labs

2011-03-04 09:05:33

by David Miller

[permalink] [raw]
Subject: Re: tun: Failed to create tun sysfs files

From: Jiri Slaby <[email protected]>
Date: Fri, 04 Mar 2011 09:56:09 +0100

> On 03/03/2011 01:52 AM, [email protected] wrote:
>> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>
> Hi, I'm seeing this with tun (also with earlier versions):

The name of the attribute was changed to netdev_group in order to
fix this problem, in fact quite some time ago.

See the last entry of the net_class_attributes array in
net/core/net-sysfs.c, if it isn't called "netdev_group"
something is awry.

2011-03-04 09:37:39

by Jiri Slaby

[permalink] [raw]
Subject: Re: tun: Failed to create tun sysfs files

On 03/04/2011 10:06 AM, David Miller wrote:
> From: Jiri Slaby <[email protected]>
> Date: Fri, 04 Mar 2011 09:56:09 +0100
>
>> On 03/03/2011 01:52 AM, [email protected] wrote:
>>> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>>
>> Hi, I'm seeing this with tun (also with earlier versions):
>
> The name of the attribute was changed to netdev_group in order to
> fix this problem, in fact quite some time ago.
>
> See the last entry of the net_class_attributes array in
> net/core/net-sysfs.c, if it isn't called "netdev_group"
> something is awry.

<idiocy>
Aha, sorry for the noise, I booted the old kernel.
</idiocy>

thanks,
--
js

2011-03-05 08:04:28

by Jiri Slaby

[permalink] [raw]
Subject: tun routing is broken [was: tun: Failed to create tun sysfs files]

On 03/04/2011 10:37 AM, Jiri Slaby wrote:
> On 03/04/2011 10:06 AM, David Miller wrote:
>> From: Jiri Slaby <[email protected]>
>> Date: Fri, 04 Mar 2011 09:56:09 +0100
>>
>>> On 03/03/2011 01:52 AM, [email protected] wrote:
>>>> The mm-of-the-moment snapshot 2011-03-02-16-52 has been uploaded to
>>>
>>> Hi, I'm seeing this with tun (also with earlier versions):
>>
>> The name of the attribute was changed to netdev_group in order to
>> fix this problem, in fact quite some time ago.
>>
>> See the last entry of the net_class_attributes array in
>> net/core/net-sysfs.c, if it isn't called "netdev_group"
>> something is awry.
>
> <idiocy>
> Aha, sorry for the noise, I booted the old kernel.
> </idiocy>

Ok, so I booted the new kernel, and tun is broken there completely. If I
try to ping a vpn peer:
...
capget(0x20080522, 0, NULL) = 0
capset(0x20080522, 0, {0, 0, 0}) = 0
socket(PF_INET, SOCK_DGRAM, IPPROTO_IP) = 4
connect(4, {sa_family=AF_INET, sin_port=htons(1025),
sin_addr=inet_addr("10.20.11.1")}, 16) = -1 EINVAL (Invalid argument)

the route is:
10.20.11.1 dev tun0 proto kernel scope link src 10.20.11.33

When I try to ping a router on eth0 10.0.28.10, it works as expected.

Maybe the changes in ipv4 routing cause this? But my amateur eyes can't
see any breakage there...

Now I'm back in mmotm 2011-02-10-16-26 and it works, indeed.

regards,
--
js
suse labs

2011-03-05 08:09:46

by David Miller

[permalink] [raw]
Subject: Re: tun routing is broken

From: Jiri Slaby <[email protected]>
Date: Sat, 05 Mar 2011 09:04:22 +0100

> Ok, so I booted the new kernel, and tun is broken there completely. If I
> try to ping a vpn peer:

-mm tree is missing this fix which went in yesterday. Please if
you are going to be testing networking a lot, test against net-next-2.6
instead of Andrew's tree which invariable lags behind:

--------------------
ipv4: Fix __ip_dev_find() to use ifa_local instead of ifa_address.

Reported-by: Stephen Hemminger <[email protected]>
Reported-by: Julian Anastasov <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
---
net/ipv4/devinet.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 9038928..ff53860 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -111,7 +111,7 @@ static inline unsigned int inet_addr_hash(struct net *net, __be32 addr)

static void inet_hash_insert(struct net *net, struct in_ifaddr *ifa)
{
- unsigned int hash = inet_addr_hash(net, ifa->ifa_address);
+ unsigned int hash = inet_addr_hash(net, ifa->ifa_local);

spin_lock(&inet_addr_hash_lock);
hlist_add_head_rcu(&ifa->hash, &inet_addr_lst[hash]);
@@ -146,7 +146,7 @@ struct net_device *__ip_dev_find(struct net *net, __be32 addr, bool devref)

if (!net_eq(dev_net(dev), net))
continue;
- if (ifa->ifa_address == addr) {
+ if (ifa->ifa_local == addr) {
result = dev;
break;
}
--
1.7.4.1


2011-03-05 08:17:30

by Jiri Slaby

[permalink] [raw]
Subject: Re: tun routing is broken

On 03/05/2011 09:10 AM, David Miller wrote:
> From: Jiri Slaby <[email protected]>
> Date: Sat, 05 Mar 2011 09:04:22 +0100
>
>> Ok, so I booted the new kernel, and tun is broken there completely. If I
>> try to ping a vpn peer:
>
> -mm tree is missing this fix which went in yesterday. Please if
> you are going to be testing networking a lot, test against net-next-2.6
> instead of Andrew's tree which invariable lags behind:

I'm not testing networking, I'm just using my desktop :). (And
next/master is mostly unusable for these needs. In comparison to mmotm
which is some kind of a "release".)

> --------------------
> ipv4: Fix __ip_dev_find() to use ifa_local instead of ifa_address.

It would be great to have a References: tag or better changelog. Then I
would give the commit a shot. The way it is I ignored it when looking at
next/master inside net/ipv4/ changes for commits to test.

Going to boot with this change.

> Reported-by: Stephen Hemminger <[email protected]>
> Reported-by: Julian Anastasov <[email protected]>
> Signed-off-by: David S. Miller <[email protected]>
> ---
> net/ipv4/devinet.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> index 9038928..ff53860 100644
> --- a/net/ipv4/devinet.c
> +++ b/net/ipv4/devinet.c
> @@ -111,7 +111,7 @@ static inline unsigned int inet_addr_hash(struct net *net, __be32 addr)
>
> static void inet_hash_insert(struct net *net, struct in_ifaddr *ifa)
> {
> - unsigned int hash = inet_addr_hash(net, ifa->ifa_address);
> + unsigned int hash = inet_addr_hash(net, ifa->ifa_local);
>
> spin_lock(&inet_addr_hash_lock);
> hlist_add_head_rcu(&ifa->hash, &inet_addr_lst[hash]);
> @@ -146,7 +146,7 @@ struct net_device *__ip_dev_find(struct net *net, __be32 addr, bool devref)
>
> if (!net_eq(dev_net(dev), net))
> continue;
> - if (ifa->ifa_address == addr) {
> + if (ifa->ifa_local == addr) {
> result = dev;
> break;
> }

thanks,
--
js
suse labs

2011-03-05 08:26:35

by Jiri Slaby

[permalink] [raw]
Subject: Re: tun routing is broken

On 03/05/2011 09:17 AM, Jiri Slaby wrote:
>> ipv4: Fix __ip_dev_find() to use ifa_local instead of ifa_address.
>
> It would be great to have a References: tag or better changelog. Then I
> would give the commit a shot. The way it is I ignored it when looking at
> next/master inside net/ipv4/ changes for commits to test.
>
> Going to boot with this change.

Yes, it works.

thanks,
--
js
suse labs

2011-03-05 11:49:01

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: tun routing is broken

On Sat, 05 Mar 2011 00:10:22 PST, David Miller said:
> --------------------
> ipv4: Fix __ip_dev_find() to use ifa_local instead of ifa_address.
>
> Reported-by: Stephen Hemminger <[email protected]>
> Reported-by: Julian Anastasov <[email protected]>
> Signed-off-by: David S. Miller <[email protected]>
> ---
> net/ipv4/devinet.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> index 9038928..ff53860 100644
> --- a/net/ipv4/devinet.c
> +++ b/net/ipv4/devinet.c

Confirming this fixes the problem I reported with IPv4 over PPP as well, thanks.


Attachments:
(No filename) (227.00 B)

2011-03-07 12:54:34

by Jiri Kosina

[permalink] [raw]
Subject: Re: tun routing is broken

On Sat, 5 Mar 2011, Jiri Slaby wrote:

> > Date: Sat, 05 Mar 2011 09:04:22 +0100
> >
> >> Ok, so I booted the new kernel, and tun is broken there completely. If I
> >> try to ping a vpn peer:
> >
> > -mm tree is missing this fix which went in yesterday. Please if
> > you are going to be testing networking a lot, test against net-next-2.6
> > instead of Andrew's tree which invariable lags behind:
>
> I'm not testing networking, I'm just using my desktop :). (And
> next/master is mostly unusable for these needs. In comparison to mmotm
> which is some kind of a "release".)

I have been hit by similar issues several times already as well.

I guess that question of including -mm into linux-next should be raised
again here ... Andrew, if I remember correctly, on last kernel summit you
were stating that you'd stop eating untill you have -mm included in -next.
Seems like you must be quite hungry these days already :)

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.