2011-03-04 07:14:14

by Axel Lin

Subject: [PATCH 1/2] ASoC: tlv320dac33: add MODULE_DEVICE_TABLE

The device table is required to load modules based on modaliases.

Signed-off-by: Axel Lin <[email protected]>
---
sound/soc/codecs/tlv320dac33.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
index 71d7be8..00b6d87 100644
--- a/sound/soc/codecs/tlv320dac33.c
+++ b/sound/soc/codecs/tlv320dac33.c
@@ -1615,6 +1615,7 @@ static const struct i2c_device_id tlv320dac33_i2c_id[] = {
},
{ },
};
+MODULE_DEVICE_TABLE(i2c, tlv320dac33_i2c_id);

static struct i2c_driver tlv320dac33_i2c_driver = {
.driver = {
--
1.7.2

2011-03-04 07:17:57

by Axel Lin

Subject: [PATCH 2/2] ASoC: Constify i2c_device_id table

Signed-off-by: Axel Lin <[email protected]>
Cc: Alexander Sverdlin <[email protected]>
Cc: Timur Tabi <[email protected]>
---
sound/soc/codecs/cs4270.c | 2 +-
sound/soc/codecs/cs4271.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
index 65f578f..0206a17 100644
--- a/sound/soc/codecs/cs4270.c
+++ b/sound/soc/codecs/cs4270.c
@@ -719,7 +719,7 @@ static int cs4270_i2c_remove(struct i2c_client *i2c_client)
/*
* cs4270_id - I2C device IDs supported by this driver
*/
-static struct i2c_device_id cs4270_id[] = {
+static const struct i2c_device_id cs4270_id[] = {
{"cs4270", 0},
{}
};
diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
index 1791796..41a3ee6 100644
--- a/sound/soc/codecs/cs4271.c
+++ b/sound/soc/codecs/cs4271.c
@@ -555,7 +555,7 @@ static struct spi_driver cs4271_spi_driver = {
#endif /* defined(CONFIG_SPI_MASTER) */

#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
-static struct i2c_device_id cs4271_i2c_id[] = {
+static const struct i2c_device_id cs4271_i2c_id[] = {
{"cs4271", 0},
{}
};
--
1.7.2

2011-03-04 07:39:11

by Alexander Sverdlin

Subject: Re: [PATCH 2/2] ASoC: Constify i2c_device_id table

On Fri, 2011-03-04 at 15:22 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>
> Cc: Alexander Sverdlin <[email protected]>
> Cc: Timur Tabi <[email protected]>
> ---
> sound/soc/codecs/cs4270.c | 2 +-
> sound/soc/codecs/cs4271.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>

Acked-by: Alexander Sverdlin <[email protected]>

2011-03-04 12:41:40

by Timur Tabi

Subject: Re: [PATCH 2/2] ASoC: Constify i2c_device_id table

Axel Lin wrote:
> Signed-off-by: Axel Lin<[email protected]>
> Cc: Alexander Sverdlin<[email protected]>
> Cc: Timur Tabi<[email protected]>
> ---

Acked-by: Timur Tabi <[email protected]>


--
Timur Tabi
Linux kernel developer

2011-03-04 13:49:34

by Peter Ujfalusi

Subject: Re: [PATCH 1/2] ASoC: tlv320dac33: add MODULE_DEVICE_TABLE

On 03/04/11 09:18, ext Axel Lin wrote:
> The device table is required to load modules based on modaliases.
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Peter Ujfalusi <[email protected]>

2011-03-07 10:48:22

by Liam Girdwood

Subject: Re: [PATCH 1/2] ASoC: tlv320dac33: add MODULE_DEVICE_TABLE

On Fri, 2011-03-04 at 15:49 +0200, Peter Ujfalusi wrote:
> On 03/04/11 09:18, ext Axel Lin wrote:
> > The device table is required to load modules based on modaliases.
> >
> > Signed-off-by: Axel Lin <[email protected]>
>
> Acked-by: Peter Ujfalusi <[email protected]>

Acked-by: Liam Girdwood <[email protected]>

2011-03-07 10:49:12

by Liam Girdwood

Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: Constify i2c_device_id table

On Fri, 2011-03-04 at 10:32 +0300, Alexander Sverdlin wrote:
> On Fri, 2011-03-04 at 15:22 +0800, Axel Lin wrote:
> > Signed-off-by: Axel Lin <[email protected]>
> > Cc: Alexander Sverdlin <[email protected]>
> > Cc: Timur Tabi <[email protected]>
> > ---
> > sound/soc/codecs/cs4270.c | 2 +-
> > sound/soc/codecs/cs4271.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
>
> Acked-by: Alexander Sverdlin <[email protected]>
>

Acked-by: Liam Girdwood <[email protected]>

2011-03-07 11:46:14

by Mark Brown

Subject: Re: [PATCH 1/2] ASoC: tlv320dac33: add MODULE_DEVICE_TABLE

On Fri, Mar 04, 2011 at 03:18:18PM +0800, Axel Lin wrote:
> The device table is required to load modules based on modaliases.
>
> Signed-off-by: Axel Lin <[email protected]>

Applied both, thanks.