2011-03-04 22:09:19

by Sheetal Sahasrabudhe

Subject: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile

This patchset contains the following features:
It adds support for Qualcomm Scorpion and ScorpionMP processors to perfevents
and Oprofile.
It adds PMU support for Scorpion and ScorpionMP.
It also updates PMU IRQ identifiers for various Scorpion and ScorpionMP targets.

Sheetal Sahasrabudhe (3):
msm: Add support for Scorpion and ScorpionMP PMU
[ARM] perfevents: Add support for Scorpion performance monitors
[ARM] Oprofile: Add Qualcomm Scorpion and ScorpionMP CPU type

arch/arm/include/asm/perf_event.h | 2 +
arch/arm/kernel/perf_event.c | 11 +
arch/arm/kernel/perf_event_qc.c | 677 ++++++++++++++++++++++++++++
arch/arm/mach-msm/Makefile | 2 +
arch/arm/mach-msm/include/mach/irqs-7x30.h | 2 +-
arch/arm/mach-msm/include/mach/irqs-8960.h | 2 +-
arch/arm/mach-msm/include/mach/irqs-8x50.h | 2 +-
arch/arm/mach-msm/include/mach/irqs-8x60.h | 2 +-
arch/arm/mach-msm/pmu.c | 36 ++
arch/arm/oprofile/common.c | 4 +
10 files changed, 736 insertions(+), 4 deletions(-)
create mode 100644 arch/arm/kernel/perf_event_qc.c
create mode 100644 arch/arm/mach-msm/pmu.c

--
1.7.4.1

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum

2011-03-04 22:42:35

by Bryan Huntsman

Subject: Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile

On 03/04/2011 02:09 PM, Sheetal Sahasrabudhe wrote:
> This patchset contains the following features:
> It adds support for Qualcomm Scorpion and ScorpionMP processors to perfevents
> and Oprofile.
> It adds PMU support for Scorpion and ScorpionMP.
> It also updates PMU IRQ identifiers for various Scorpion and ScorpionMP targets.
>
> Sheetal Sahasrabudhe (3):
> msm: Add support for Scorpion and ScorpionMP PMU
> [ARM] perfevents: Add support for Scorpion performance monitors
> [ARM] Oprofile: Add Qualcomm Scorpion and ScorpionMP CPU type
>
> arch/arm/include/asm/perf_event.h | 2 +
> arch/arm/kernel/perf_event.c | 11 +
> arch/arm/kernel/perf_event_qc.c | 677 ++++++++++++++++++++++++++++
> arch/arm/mach-msm/Makefile | 2 +
> arch/arm/mach-msm/include/mach/irqs-7x30.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8960.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x50.h | 2 +-
> arch/arm/mach-msm/include/mach/irqs-8x60.h | 2 +-
> arch/arm/mach-msm/pmu.c | 36 ++
> arch/arm/oprofile/common.c | 4 +
> 10 files changed, 736 insertions(+), 4 deletions(-)
> create mode 100644 arch/arm/kernel/perf_event_qc.c
> create mode 100644 arch/arm/mach-msm/pmu.c
>

Some minor comments from a quick review:
- you're using multi-line commenting style for single line comments
- see Documentation/CodingStyle, Chapter 8, for preferred multi-line
commenting style
- 'mv perf_event_qc.c perf_event_msm.c'?

- Bryan

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

2011-03-05 21:40:29

by Sheetal Sahasrabudhe

Subject: Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile

Hi Bryan,

> Some minor comments from a quick review:
> - you're using multi-line commenting style for single line comments
> - see Documentation/CodingStyle, Chapter 8, for preferred multi-line
> commenting style
I will fix the commenting style wherever needed.

> - 'mv perf_event_qc.c perf_event_msm.c'?
That's fine with me.

Thanks,
Sheetal

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

2011-03-07 10:06:43

by Jean Pihet

Subject: Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile

Hi,

On Fri, Mar 4, 2011 at 11:09 PM, Sheetal Sahasrabudhe
<[email protected]> wrote:
> This patchset contains the following features:
> It adds support for Qualcomm Scorpion and ScorpionMP processors to perfevents
> and Oprofile.
> It adds PMU support for Scorpion and ScorpionMP.
> It also updates PMU IRQ identifiers for various Scorpion and ScorpionMP targets.
>
> Sheetal Sahasrabudhe (3):
> ?msm: Add support for Scorpion and ScorpionMP PMU
> ?[ARM] perfevents: Add support for Scorpion performance monitors
> ?[ARM] Oprofile: Add Qualcomm Scorpion and ScorpionMP CPU type
>
> ?arch/arm/include/asm/perf_event.h ? ? ? ? ?| ? ?2 +
> ?arch/arm/kernel/perf_event.c ? ? ? ? ? ? ? | ? 11 +
> ?arch/arm/kernel/perf_event_qc.c ? ? ? ? ? ?| ?677 ++++++++++++++++++++++++++++
> ?arch/arm/mach-msm/Makefile ? ? ? ? ? ? ? ? | ? ?2 +
> ?arch/arm/mach-msm/include/mach/irqs-7x30.h | ? ?2 +-
> ?arch/arm/mach-msm/include/mach/irqs-8960.h | ? ?2 +-
> ?arch/arm/mach-msm/include/mach/irqs-8x50.h | ? ?2 +-
> ?arch/arm/mach-msm/include/mach/irqs-8x60.h | ? ?2 +-
> ?arch/arm/mach-msm/pmu.c ? ? ? ? ? ? ? ? ? ?| ? 36 ++
> ?arch/arm/oprofile/common.c ? ? ? ? ? ? ? ? | ? ?4 +
> ?10 files changed, 736 insertions(+), 4 deletions(-)
> ?create mode 100644 arch/arm/kernel/perf_event_qc.c
> ?create mode 100644 arch/arm/mach-msm/pmu.c
>

I cannot test on the actual HW so here is the review ack:
Reviewed-by: Jean Pihet <[email protected]>

Thanks,
Jean

> --
> 1.7.4.1
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum
>
>