2011-03-07 17:00:41

by Roel Kluin

Subject: [PATCH] drm: index i shadowed in 2nd loop

Index i was already used in thhe first loop

Signed-off-by: Roel Kluin <[email protected]>
---
drivers/gpu/drm/drm_fb_helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

The original was wrong, isn't it?

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 6977a1c..f73ef43 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -672,7 +672,7 @@ int drm_fb_helper_setcmap(struct fb_cmap *cmap, struct fb_info *info)
struct drm_crtc_helper_funcs *crtc_funcs;
u16 *red, *green, *blue, *transp;
struct drm_crtc *crtc;
- int i, rc = 0;
+ int i, j, rc = 0;
int start;

for (i = 0; i < fb_helper->crtc_count; i++) {
@@ -685,7 +685,7 @@ int drm_fb_helper_setcmap(struct fb_cmap *cmap, struct fb_info *info)
transp = cmap->transp;
start = cmap->start;

- for (i = 0; i < cmap->len; i++) {
+ for (j = 0; j < cmap->len; j++) {
u16 hred, hgreen, hblue, htransp = 0xffff;

hred = *red++;

2011-03-07 17:11:14

by Chris Wilson

Subject: Re: [PATCH] drm: index i shadowed in 2nd loop

On Mon, 07 Mar 2011 18:00:34 +0100, roel <[email protected]> wrote:
> Index i was already used in thhe first loop

Probably related to https://bugzilla.kernel.org/show_bug.cgi?id=19512
-Chris

--
Chris Wilson, Intel Open Source Technology Centre