2011-04-01 07:45:53

by Konstantin Khlebnikov

Subject: [PATCH] x86, defconfig: replace ext3 with ext4

Replace ext3 with ext4, because now it is a de facto standard file system.
And set CONFIG_EXT4_USE_FOR_EXT23=y to use it also for mounting ext2/ext3.

Signed-off-by: Konstantin Khlebnikov <[email protected]>
---
arch/x86/configs/i386_defconfig | 9 +++++----
arch/x86/configs/x86_64_defconfig | 9 +++++----
2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index 6f98726..cb8268c 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -269,10 +269,11 @@ CONFIG_RTC_CLASS=y
CONFIG_DMADEVICES=y
CONFIG_EEEPC_LAPTOP=y
CONFIG_EFI_VARS=y
-CONFIG_EXT3_FS=y
-# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
-CONFIG_EXT3_FS_POSIX_ACL=y
-CONFIG_EXT3_FS_SECURITY=y
+CONFIG_EXT4_FS=y
+CONFIG_EXT4_USE_FOR_EXT23=y
+CONFIG_EXT4_FS_XATTR=y
+CONFIG_EXT4_FS_POSIX_ACL=y
+CONFIG_EXT4_FS_SECURITY=y
CONFIG_QUOTA=y
CONFIG_QUOTA_NETLINK_INTERFACE=y
# CONFIG_PRINT_QUOTA_WARNING is not set
diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
index ee01a9d..033ec9a 100644
--- a/arch/x86/configs/x86_64_defconfig
+++ b/arch/x86/configs/x86_64_defconfig
@@ -270,10 +270,11 @@ CONFIG_RTC_CLASS=y
CONFIG_DMADEVICES=y
CONFIG_EEEPC_LAPTOP=y
CONFIG_EFI_VARS=y
-CONFIG_EXT3_FS=y
-# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
-CONFIG_EXT3_FS_POSIX_ACL=y
-CONFIG_EXT3_FS_SECURITY=y
+CONFIG_EXT4_FS=y
+CONFIG_EXT4_USE_FOR_EXT23=y
+CONFIG_EXT4_FS_XATTR=y
+CONFIG_EXT4_FS_POSIX_ACL=y
+CONFIG_EXT4_FS_SECURITY=y
CONFIG_QUOTA=y
CONFIG_QUOTA_NETLINK_INTERFACE=y
# CONFIG_PRINT_QUOTA_WARNING is not set

2011-04-04 00:37:37

by Jan Kara

Subject: Re: [PATCH] x86, defconfig: replace ext3 with ext4

On Fri 01-04-11 11:45:48, Konstantin Khlebnikov wrote:
> Replace ext3 with ext4, because now it is a de facto standard file system.
> And set CONFIG_EXT4_USE_FOR_EXT23=y to use it also for mounting ext2/ext3.
I'm sorry but I think it's too early for CONFIG_EXT4_USE_FOR_EXT23 part.
Although ext4 can handle ext3 and is stable, I believe there hasn't been
enough testing of ext4 code used as ext3 replacement. Some of the code
paths used for handling of ext3 are different from those used for ext4 and
there could be bugs lurking. Also ext4 has some slight differences in
performance and behavior in corner cases to ext3 which can potentially
screw users. I'm not saying these differences are showstoppers but we
should at least (try to) identify them before exposing users to them.

Actually, I want to speak to some people about this this week at LSF to get
some concensus on what exactly needs to be done so that we can replace
ext[23] with ext4.

Honza

> Signed-off-by: Konstantin Khlebnikov <[email protected]>
> ---
> arch/x86/configs/i386_defconfig | 9 +++++----
> arch/x86/configs/x86_64_defconfig | 9 +++++----
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
> index 6f98726..cb8268c 100644
> --- a/arch/x86/configs/i386_defconfig
> +++ b/arch/x86/configs/i386_defconfig
> @@ -269,10 +269,11 @@ CONFIG_RTC_CLASS=y
> CONFIG_DMADEVICES=y
> CONFIG_EEEPC_LAPTOP=y
> CONFIG_EFI_VARS=y
> -CONFIG_EXT3_FS=y
> -# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
> -CONFIG_EXT3_FS_POSIX_ACL=y
> -CONFIG_EXT3_FS_SECURITY=y
> +CONFIG_EXT4_FS=y
> +CONFIG_EXT4_USE_FOR_EXT23=y
> +CONFIG_EXT4_FS_XATTR=y
> +CONFIG_EXT4_FS_POSIX_ACL=y
> +CONFIG_EXT4_FS_SECURITY=y
> CONFIG_QUOTA=y
> CONFIG_QUOTA_NETLINK_INTERFACE=y
> # CONFIG_PRINT_QUOTA_WARNING is not set
> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
> index ee01a9d..033ec9a 100644
> --- a/arch/x86/configs/x86_64_defconfig
> +++ b/arch/x86/configs/x86_64_defconfig
> @@ -270,10 +270,11 @@ CONFIG_RTC_CLASS=y
> CONFIG_DMADEVICES=y
> CONFIG_EEEPC_LAPTOP=y
> CONFIG_EFI_VARS=y
> -CONFIG_EXT3_FS=y
> -# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
> -CONFIG_EXT3_FS_POSIX_ACL=y
> -CONFIG_EXT3_FS_SECURITY=y
> +CONFIG_EXT4_FS=y
> +CONFIG_EXT4_USE_FOR_EXT23=y
> +CONFIG_EXT4_FS_XATTR=y
> +CONFIG_EXT4_FS_POSIX_ACL=y
> +CONFIG_EXT4_FS_SECURITY=y
> CONFIG_QUOTA=y
> CONFIG_QUOTA_NETLINK_INTERFACE=y
> # CONFIG_PRINT_QUOTA_WARNING is not set
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2011-04-04 02:08:01

by Randy Dunlap

Subject: Re: [PATCH] x86, defconfig: replace ext3 with ext4

On 4/3/2011 6:22 AM, Jan Kara wrote:
> On Fri 01-04-11 11:45:48, Konstantin Khlebnikov wrote:
>> Replace ext3 with ext4, because now it is a de facto standard file system.
>> And set CONFIG_EXT4_USE_FOR_EXT23=y to use it also for mounting ext2/ext3.
> I'm sorry but I think it's too early for CONFIG_EXT4_USE_FOR_EXT23 part.

I considered the date of the email and then just ignored it. ;)