2011-04-24 23:28:37

by Peter Foley

Subject: [PATCH] kbuild: don't warn about linux/version.h not including itself

This patch makes checkversion.pl not warn that include/linux/version.h
dosen't include itself.

Signed-off-by: Peter Foley <[email protected]>
---
scripts/checkversion.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
index b444e89..b9150c7 100755
--- a/scripts/checkversion.pl
+++ b/scripts/checkversion.pl
@@ -47,7 +47,7 @@ foreach my $file (@ARGV) {
}

# Report used version IDs without include?
- if ($fUseVersion && ! $iLinuxVersion) {
+ if ($fUseVersion && ! $iLinuxVersion && $file !~ "include/linux/version.h") {
print "$file: $.: need linux/version.h\n";
}

--
1.7.5.rc1

2011-04-26 20:35:46

by Michal Marek

Subject: Re: [PATCH] kbuild: don't warn about linux/version.h not including itself

On 25.4.2011 01:27, Peter Foley wrote:
> This patch makes checkversion.pl not warn that include/linux/version.h
> dosen't include itself.
>
> Signed-off-by: Peter Foley <[email protected]>
> ---
> scripts/checkversion.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
> index b444e89..b9150c7 100755
> --- a/scripts/checkversion.pl
> +++ b/scripts/checkversion.pl
> @@ -47,7 +47,7 @@ foreach my $file (@ARGV) {
> }
>
> # Report used version IDs without include?
> - if ($fUseVersion && ! $iLinuxVersion) {
> + if ($fUseVersion && ! $iLinuxVersion && $file !~ "include/linux/version.h") {

A more obvious fix would be to check the filename right at the beginning
of the loop and skip to the next iteration if it is version.h. Also, you
should escape the '.' in the regexp.

Michal