2011-04-25 23:53:00

by Peter Foley

Subject: [PATCH] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error

This patch adds a dependency on NLS to HYPERV_UTILS to avoid a build error.

Signed-off-by: Peter Foley <[email protected]>
---
drivers/staging/hv/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
index d41f380..76f0756 100644
--- a/drivers/staging/hv/Kconfig
+++ b/drivers/staging/hv/Kconfig
@@ -31,7 +31,7 @@ config HYPERV_NET
config HYPERV_UTILS
tristate "Microsoft Hyper-V Utilities driver"
- depends on CONNECTOR
+ depends on CONNECTOR && NLS
default HYPERV
help
Select this option to enable the Hyper-V Utilities.
--
1.7.5.rc1

2011-04-26 00:02:51

by Greg KH

Subject: Re: [PATCH] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error

On Mon, Apr 25, 2011 at 07:52:18PM -0400, Peter Foley wrote:
> This patch adds a dependency on NLS to HYPERV_UTILS to avoid a build error.

What is the build error?

thanks,

greg k-h

2011-04-26 00:54:15

by Peter Foley

Subject: Re: [PATCH] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error

On 4/25/2011 8:00 PM, Greg KH wrote:
> On Mon, Apr 25, 2011 at 07:52:18PM -0400, Peter Foley wrote:
>> This patch adds a dependency on NLS to HYPERV_UTILS to avoid a build error.
>
> What is the build error?
>
> thanks,
>
> greg k-h


When CONFIG_HYPERV_UTILS=y and CONFIG_NLS=n
the build fails with this error:

Building modules, stage 2.
MODPOST 3 modules
ERROR: "utf8s_to_utf16s" [drivers/staging/hv/hv_utils.ko] undefined!
make[3]: *** [__modpost] Error 1
make[2]: *** [modules] Error 2
make[2]: *** Waiting for unfinished jobs....
Kernel: arch/x86/boot/bzImage is ready (#2)
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2

2011-05-03 17:33:28

by Greg KH

Subject: Re: [PATCH] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error

On Mon, Apr 25, 2011 at 08:53:26PM -0400, Peter Foley wrote:
> On 4/25/2011 8:00 PM, Greg KH wrote:
> > On Mon, Apr 25, 2011 at 07:52:18PM -0400, Peter Foley wrote:
> >> This patch adds a dependency on NLS to HYPERV_UTILS to avoid a build error.
> >
> > What is the build error?
> >
> > thanks,
> >
> > greg k-h
>
>
> When CONFIG_HYPERV_UTILS=y and CONFIG_NLS=n
> the build fails with this error:
>
> Building modules, stage 2.
> MODPOST 3 modules
> ERROR: "utf8s_to_utf16s" [drivers/staging/hv/hv_utils.ko] undefined!
> make[3]: *** [__modpost] Error 1
> make[2]: *** [modules] Error 2
> make[2]: *** Waiting for unfinished jobs....
> Kernel: arch/x86/boot/bzImage is ready (#2)
> make[1]: *** [sub-make] Error 2
> make: *** [all] Error 2

Ah, ok, we need this for that function, that's what I wanted to know,
I'll put it in the changelog entry. Please do that the next time.

thanks,

greg k-h

2011-05-03 17:58:22

by Greg KH

Subject: Re: [PATCH] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error

On Mon, Apr 25, 2011 at 07:52:18PM -0400, Peter Foley wrote:
> This patch adds a dependency on NLS to HYPERV_UTILS to avoid a build error.
>
> Signed-off-by: Peter Foley <[email protected]>
> ---
> drivers/staging/hv/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> index d41f380..76f0756 100644
> --- a/drivers/staging/hv/Kconfig
> +++ b/drivers/staging/hv/Kconfig
> @@ -31,7 +31,7 @@ config HYPERV_NET
> config HYPERV_UTILS
> tristate "Microsoft Hyper-V Utilities driver"
> - depends on CONNECTOR
> + depends on CONNECTOR && NLS

This patch doesn't apply at all, and I can't figure out why. Did your
email client somehow mess it up?

Care to resend it, with the proper information in the Changelog entry
(i.e. what build error this is fixing) so I can apply it?

thanks,

greg k-h

2011-05-03 18:12:13

by Peter Foley

Subject: Re: [PATCH] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error

On 5/3/2011 1:57 PM, Greg KH wrote:
> On Mon, Apr 25, 2011 at 07:52:18PM -0400, Peter Foley wrote:
>> This patch adds a dependency on NLS to HYPERV_UTILS to avoid a build error.
>>
>> Signed-off-by: Peter Foley <[email protected]>
>> ---
>> drivers/staging/hv/Kconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
>> index d41f380..76f0756 100644
>> --- a/drivers/staging/hv/Kconfig
>> +++ b/drivers/staging/hv/Kconfig
>> @@ -31,7 +31,7 @@ config HYPERV_NET
>> config HYPERV_UTILS
>> tristate "Microsoft Hyper-V Utilities driver"
>> - depends on CONNECTOR
>> + depends on CONNECTOR && NLS
>
> This patch doesn't apply at all, and I can't figure out why. Did your
> email client somehow mess it up?
>
> Care to resend it, with the proper information in the Changelog entry
> (i.e. what build error this is fixing) so I can apply it?
>
> thanks,
>
> greg k-h

Ok, I'll resend it.
I seem to have a problem with my email client corrupting patches.
I'm going to try a different one which will hopefully fix the problem.

Thanks,

Peter