2011-04-26 22:45:31

by Peter Foley

Subject: [PATCH V2 1/7] kbuild: only build kxgettext when needed

This patch only builds kxgettext when running update-po-config
which is the only target that uses it.

Signed-off-by: Peter Foley <[email protected]>
---
scripts/kconfig/Makefile | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 368ae30..fec830f 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -169,7 +169,7 @@ mconf-objs := mconf.o zconf.tab.o $(lxdialog)
nconf-objs := nconf.o zconf.tab.o nconf.gui.o
kxgettext-objs := kxgettext.o zconf.tab.o

-hostprogs-y := conf qconf gconf kxgettext
+hostprogs-y := conf qconf gconf

ifeq ($(MAKECMDGOALS),nconfig)
hostprogs-y += nconf
@@ -179,6 +179,10 @@ ifeq ($(MAKECMDGOALS),menuconfig)
hostprogs-y += mconf
endif

+ifeq($(MAKECMDGOALS),update-po-config)
+ hostprogs-y += kxgettext
+endif
+
ifeq ($(MAKECMDGOALS),xconfig)
qconf-target := 1
endif
--
1.7.5.rc1

2011-04-26 23:02:28

by Peter Foley

Subject: Re: [PATCH V2 1/7] kbuild: only build kxgettext when needed

Sorry, I forgot a space in this patch. A corrected version is below.

This patch only builds kxgettext when running update-po-config
which is the only target that uses it.

Signed-off-by: Peter Foley <[email protected]>
---
scripts/kconfig/Makefile | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 368ae30..fec830f 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -169,7 +169,7 @@ mconf-objs := mconf.o zconf.tab.o $(lxdialog)
nconf-objs := nconf.o zconf.tab.o nconf.gui.o
kxgettext-objs := kxgettext.o zconf.tab.o

-hostprogs-y := conf qconf gconf kxgettext
+hostprogs-y := conf qconf gconf

ifeq ($(MAKECMDGOALS),nconfig)
hostprogs-y += nconf
@@ -179,6 +179,10 @@ ifeq ($(MAKECMDGOALS),menuconfig)
hostprogs-y += mconf
endif

+ifeq ($(MAKECMDGOALS),update-po-config)
+ hostprogs-y += kxgettext
+endif
+
ifeq ($(MAKECMDGOALS),xconfig)
qconf-target := 1
endif
--
1.7.5.rc1

2011-04-27 15:18:49

by Michal Marek

Subject: Re: [PATCH V2 1/7] kbuild: only build kxgettext when needed

On 27.4.2011 01:01, Peter Foley wrote:
> Sorry, I forgot a space in this patch. A corrected version is below.

The first patch actually applied OK, but patch 2/7 and 4/7 and maybe
other were malformed. Could you please resend the patches as MIME
attachments so that they are not modified by your mailer?

Thanks,
Michal

2011-04-27 16:26:41

by Peter Foley

Subject: Re: [PATCH V2 1/7] kbuild: only build kxgettext when needed

On 4/27/2011 11:18 AM, Michal Marek wrote:
> On 27.4.2011 01:01, Peter Foley wrote:
>> Sorry, I forgot a space in this patch. A corrected version is below.
>
> The first patch actually applied OK, but patch 2/7 and 4/7 and maybe
> other were malformed. Could you please resend the patches as MIME
> attachments so that they are not modified by your mailer?
>
> Thanks,
> Michal

Ok, I'll resend them.
Sorry for any trouble.

Thanks,

Peter