2011-05-04 13:08:16

by Tony Vroon

[permalink] [raw]
Subject: ums-realtek: Unneeded SubClass & Protocol entries (Fujitsu S760 laptop)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Good afternoon,

The following message was emitted by my kernel:
usb 1-1.6: new high speed USB device number 5 using ehci_hcd
ums-realtek 1-1.6:1.0: This device (0bda,0138,3882 S 06 P 50) has
unneeded SubClass and Protocol entries in unusual_devs.h (kernel
2.6.39-rc5-00274-g609cfda)
Please send a copy of this message to <[email protected]> and
<[email protected]>
scsi6 : usb-storage 1-1.6:1.0

This is the built-in card reader on a Fujitsu S760 laptop. Full lsusb
for the device in question:
Bus 001 Device 005: ID 0bda:0138 Realtek Semiconductor Corp.
Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass 0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize0 64
idVendor 0x0bda Realtek Semiconductor Corp.
idProduct 0x0138
bcdDevice 38.82
iManufacturer 1 Generic
iProduct 2 USB2.0-CRW
iSerial 3 20090516388200000
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 32
bNumInterfaces 1
bConfigurationValue 1
iConfiguration 4 CARD READER
bmAttributes 0xa0
(Bus Powered)
Remote Wakeup
MaxPower 500mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 8 Mass Storage
bInterfaceSubClass 6 SCSI
bInterfaceProtocol 80 Bulk (Zip)
iInterface 5 Bulk-In, Bulk-Out, Interface
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x01 EP 1 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x82 EP 2 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Device Qualifier (for other device speed):
bLength 10
bDescriptorType 6
bcdUSB 2.00
bDeviceClass 0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize0 64
bNumConfigurations 1
Device Status: 0x0000
(Bus Powered)

Could you CC me on any postings as I am not subscribed to the USB lists.
If there is further information you require, I am happy to provide it.

Regards,
- --
Tony Vroon
UNIX systems administrator
London Internet Exchange Ltd, Trinity Court, Trinity Street,
Peterborough, PE1 1DA
Registered in England number 3137929
E-Mail: [email protected]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3BTdkACgkQp5vW4rUFj5rGPACgkOfjbenHWGPLpgOAPrzbHqjH
vJEAoKjva6ZsDs/rcdgh6TngHm63/beO
=qwHu
-----END PGP SIGNATURE-----


2011-05-04 16:35:43

by Alan Stern

[permalink] [raw]
Subject: Re: ums-realtek: Unneeded SubClass & Protocol entries (Fujitsu S760 laptop)

On Wed, 4 May 2011, Tony Vroon wrote:

> Good afternoon,
>
> The following message was emitted by my kernel:
> usb 1-1.6: new high speed USB device number 5 using ehci_hcd
> ums-realtek 1-1.6:1.0: This device (0bda,0138,3882 S 06 P 50) has
> unneeded SubClass and Protocol entries in unusual_devs.h (kernel
> 2.6.39-rc5-00274-g609cfda)
> Please send a copy of this message to <[email protected]> and
> <[email protected]>
> scsi6 : usb-storage 1-1.6:1.0

Thanks for reporting this. Does the patch below cause the message to
go away?

Alan Stern



Index: usb-2.6/drivers/usb/storage/unusual_realtek.h
===================================================================
--- usb-2.6.orig/drivers/usb/storage/unusual_realtek.h
+++ usb-2.6/drivers/usb/storage/unusual_realtek.h
@@ -23,19 +23,19 @@
#if defined(CONFIG_USB_STORAGE_REALTEK) || \
defined(CONFIG_USB_STORAGE_REALTEK_MODULE)

-UNUSUAL_DEV(0x0bda, 0x0159, 0x0000, 0x9999,
+UNUSUAL_DEV(0x0bda, 0x0138, 0x0000, 0x9999,
"Realtek",
"USB Card Reader",
- USB_SC_SCSI, USB_PR_BULK, init_realtek_cr, 0),
+ USB_SC_DEVICE, USB_PR_DEVICE, init_realtek_cr, 0),

UNUSUAL_DEV(0x0bda, 0x0158, 0x0000, 0x9999,
"Realtek",
"USB Card Reader",
- USB_SC_SCSI, USB_PR_BULK, init_realtek_cr, 0),
+ USB_SC_DEVICE, USB_PR_DEVICE, init_realtek_cr, 0),

-UNUSUAL_DEV(0x0bda, 0x0138, 0x0000, 0x9999,
+UNUSUAL_DEV(0x0bda, 0x0159, 0x0000, 0x9999,
"Realtek",
"USB Card Reader",
- USB_SC_SCSI, USB_PR_BULK, init_realtek_cr, 0),
+ USB_SC_DEVICE, USB_PR_DEVICE, init_realtek_cr, 0),

#endif /* defined(CONFIG_USB_STORAGE_REALTEK) || ... */

2011-05-05 09:18:15

by Tony Vroon

[permalink] [raw]
Subject: Re: ums-realtek: Unneeded SubClass & Protocol entries (Fujitsu S760 laptop)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/04/11 17:35, Alan Stern wrote:
> Does the patch below cause the message to
> go away?

Tested-By: Tony Vroon <[email protected]>

- -ums-realtek 1-1.6:1.0: This device (0bda,0138,3882 S 06 P 50) has
unneeded SubClass and Protocol entries in unusual_devs.h (kernel
2.6.39-rc5-00274-g609cfda)
- - Please send a copy of this message to <[email protected]>
and <[email protected]>

That is with your patch applied to 2.6.39-rc6-00041-g5895198. Many thanks.

Regards,
- --
Tony Vroon
UNIX systems administrator
London Internet Exchange Ltd, Trinity Court, Trinity Street,
Peterborough, PE1 1DA
Registered in England number 3137929
E-Mail: [email protected]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3Ca1AACgkQp5vW4rUFj5rZ/gCfY5ovrZAWSrWHjJ/pOepuw+uL
EYQAnA6lxmSoD3xEW2x78QmTebiwulCU
=4MJp
-----END PGP SIGNATURE-----

2011-05-05 13:57:29

by Alan Stern

[permalink] [raw]
Subject: Re: ums-realtek: Unneeded SubClass & Protocol entries (Fujitsu S760 laptop)

On Thu, 5 May 2011, Tony Vroon wrote:

> On 05/04/11 17:35, Alan Stern wrote:
> > Does the patch below cause the message to
> > go away?
>
> Tested-By: Tony Vroon <[email protected]>
>
> - -ums-realtek 1-1.6:1.0: This device (0bda,0138,3882 S 06 P 50) has
> unneeded SubClass and Protocol entries in unusual_devs.h (kernel
> 2.6.39-rc5-00274-g609cfda)
> - - Please send a copy of this message to <[email protected]>
> and <[email protected]>
>
> That is with your patch applied to 2.6.39-rc6-00041-g5895198. Many thanks.

Sorry, I don't quite understand what you mean. Do those "- -" strings
indicate that the message is not present when the patch is applied?

Alan Stern

2011-05-05 14:22:14

by Tony Vroon

[permalink] [raw]
Subject: Re: ums-realtek: Unneeded SubClass & Protocol entries (Fujitsu S760 laptop)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/05/11 14:57, Alan Stern wrote:
> Sorry, I don't quite understand what you mean. Do those "- -" strings
> indicate that the message is not present when the patch is applied?

Indeed, I did a diff between the dmesg of the kernel I reported the
problem on, and the dmesg of the newer RC6 with your patch applied.

Regards,
- --
Tony Vroon
UNIX systems administrator
London Internet Exchange Ltd, Trinity Court, Trinity Street,
Peterborough, PE1 1DA
Registered in England number 3137929
E-Mail: [email protected]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3CsosACgkQp5vW4rUFj5oLHwCfSImae4+NjEvgiqd8J0D7RG2o
HhUAoLH4NpYRXyQS0q5/3cnWqZszZXpS
=KOg0
-----END PGP SIGNATURE-----