2011-05-06 12:49:47

by Toshiharu Okada

Subject: [PATCH 1/2] PCH_GbE : Fixed the issue of collision detection

The collision detection setting was invalid.
When collision occurred, because data was not resenr,
there was an issue to which a transmitting throughput falls.

This patch enables the collision detection.

Signed-off-by: Toshiharu Okada <[email protected]>
---
drivers/net/pch_gbe/pch_gbe_main.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/pch_gbe/pch_gbe_main.c b/drivers/net/pch_gbe/pch_gbe_main.c
index 8300f64..babe663 100644
--- a/drivers/net/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/pch_gbe/pch_gbe_main.c
@@ -43,8 +43,7 @@ const char pch_driver_version[] = DRV_VERSION;

#define PCH_GBE_MAC_RGMII_CTRL_SETTING ( \
PCH_GBE_CHIP_TYPE_INTERNAL | \
- PCH_GBE_RGMII_MODE_RGMII | \
- PCH_GBE_CRS_SEL \
+ PCH_GBE_RGMII_MODE_RGMII \
)

/* Ethertype field values */
--
1.6.2.5

2011-05-09 18:56:03

by David Miller

Subject: Re: [PATCH 1/2] PCH_GbE : Fixed the issue of collision detection

From: Toshiharu Okada <[email protected]>
Date: Fri, 06 May 2011 21:53:51 +0900

> The collision detection setting was invalid.
> When collision occurred, because data was not resenr,
> there was an issue to which a transmitting throughput falls.
>
> This patch enables the collision detection.
>
> Signed-off-by: Toshiharu Okada <[email protected]>

Applied.