2011-05-14 18:19:46

by Mark Brown

Subject: [PATCH] regulator: If we can't configure optimum mode we're always in the best one

If either a regulator driver can't tell us what the optimum mode is (or
doesn't have modes in the first place) or the system doesn't allow DRMS
changes then it's more helpful for users to just say that we're in the
optimal mode, even if it's from a selection of one.

Still report errors if the process of picking and setting a mode changes as
this may indicate that we're stuck in a low power mode and unable to deliver
a higher current that the consumer just asked for.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/core.c | 16 +++++++++++++---
1 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 9f18131..051a45d 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2078,16 +2078,26 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load)

mutex_lock(&rdev->mutex);

+ /*
+ * first check to see if we can set modes at all, otherwise just
+ * tell the consumer everything is OK.
+ */
regulator->uA_load = uA_load;
ret = regulator_check_drms(rdev);
- if (ret < 0)
+ if (ret < 0) {
+ ret = 0;
goto out;
- ret = -EINVAL;
+ }

- /* sanity check */
if (!rdev->desc->ops->get_optimum_mode)
goto out;

+ /*
+ * we can actually do this so any errors are indicators of
+ * potential real failure.
+ */
+ ret = -EINVAL;
+
/* get output voltage */
output_uV = _regulator_get_voltage(rdev);
if (output_uV <= 0) {
--
1.7.5.1

2011-05-16 12:19:10

by Liam Girdwood

Subject: Re: [PATCH] regulator: If we can't configure optimum mode we're always in the best one

On 14/05/11 19:19, Mark Brown wrote:
> If either a regulator driver can't tell us what the optimum mode is (or
> doesn't have modes in the first place) or the system doesn't allow DRMS
> changes then it's more helpful for users to just say that we're in the
> optimal mode, even if it's from a selection of one.
>
> Still report errors if the process of picking and setting a mode changes as
> this may indicate that we're stuck in a low power mode and unable to deliver
> a higher current that the consumer just asked for.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/regulator/core.c | 16 +++++++++++++---
> 1 files changed, 13 insertions(+), 3 deletions(-)
>

Applied.

Thanks

Liam