2011-05-14 20:42:35

by Mark Brown

Subject: [PATCH] regulator: Only apply voltage constraints from consumers that set them

When applying the set_voltage() requests from consumers skip over those
consumers that haven't set anything, otherwise we'll come out with a
maximum voltage of zero.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/core.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 051a45d..60ae920 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -161,6 +161,13 @@ static int regulator_check_consumers(struct regulator_dev *rdev,
struct regulator *regulator;

list_for_each_entry(regulator, &rdev->consumer_list, list) {
+ /*
+ * Assume consumers that didn't say anything are OK
+ * with anything in the constraint range.
+ */
+ if (!regulator->min_uV && !regulator->max_uV)
+ continue;
+
if (*max_uV > regulator->max_uV)
*max_uV = regulator->max_uV;
if (*min_uV < regulator->min_uV)
--
1.7.5.1

2011-05-16 12:19:24

by Liam Girdwood

Subject: Re: [PATCH] regulator: Only apply voltage constraints from consumers that set them

On 14/05/11 21:42, Mark Brown wrote:
> When applying the set_voltage() requests from consumers skip over those
> consumers that haven't set anything, otherwise we'll come out with a
> maximum voltage of zero.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---

Applied.

Thanks

Liam