2011-03-28 15:23:26

by Randy Dunlap

Subject: Fw: [PATCH -next RESEND/still needed] staging: altera-jtag needs delay.h

From: Randy Dunlap <[email protected]>

altera-jtag.c needs to include <linux/delay.h> to fix a build error:

drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay'

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Igor M. Liplianin <[email protected]>
---
drivers/staging/altera-stapl/altera-jtag.c | 1 +
1 file changed, 1 insertion(+)

Somehow I was supposed to know to send this to Mauro instead of to Greg,
but I don't see anything in drivers/staging/altera-stapl/ that says that.


--- linux-next-20110304.orig/drivers/staging/altera-stapl/altera-jtag.c
+++ linux-next-20110304/drivers/staging/altera-stapl/altera-jtag.c
@@ -23,6 +23,7 @@
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/

+#include <linux/delay.h>
#include <linux/firmware.h>
#include <linux/slab.h>
#include <staging/altera.h>
--

2011-05-19 19:22:16

by Mauro Carvalho Chehab

Subject: Re: Fw: [PATCH -next RESEND/still needed] staging: altera-jtag needs delay.h

Em 28-03-2011 12:23, Randy Dunlap escreveu:
> From: Randy Dunlap <[email protected]>
>
> altera-jtag.c needs to include <linux/delay.h> to fix a build error:
>
> drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay'
>
> Signed-off-by: Randy Dunlap <[email protected]>
Acked-by: Mauro Carvalho Chehab <[email protected]>

> Cc: Igor M. Liplianin <[email protected]>
> ---
> drivers/staging/altera-stapl/altera-jtag.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Somehow I was supposed to know to send this to Mauro instead of to Greg,
> but I don't see anything in drivers/staging/altera-stapl/ that says that.

Ah, yes, we need to add a readme file there stating about that.

Greg, you may add it on your tree, or if you prefer, I can just add here for
my next upstream pull.

Thanks,
Mauro.

>
>
> --- linux-next-20110304.orig/drivers/staging/altera-stapl/altera-jtag.c
> +++ linux-next-20110304/drivers/staging/altera-stapl/altera-jtag.c
> @@ -23,6 +23,7 @@
> * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> */
>
> +#include <linux/delay.h>
> #include <linux/firmware.h>
> #include <linux/slab.h>
> #include <staging/altera.h>
> --

2011-05-19 20:39:57

by Greg KH

Subject: Re: Fw: [PATCH -next RESEND/still needed] staging: altera-jtag needs delay.h

On Thu, May 19, 2011 at 04:22:06PM -0300, Mauro Carvalho Chehab wrote:
> Em 28-03-2011 12:23, Randy Dunlap escreveu:
> > From: Randy Dunlap <[email protected]>
> >
> > altera-jtag.c needs to include <linux/delay.h> to fix a build error:
> >
> > drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay'
> >
> > Signed-off-by: Randy Dunlap <[email protected]>
> Acked-by: Mauro Carvalho Chehab <[email protected]>
>
> > Cc: Igor M. Liplianin <[email protected]>
> > ---
> > drivers/staging/altera-stapl/altera-jtag.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Somehow I was supposed to know to send this to Mauro instead of to Greg,
> > but I don't see anything in drivers/staging/altera-stapl/ that says that.
>
> Ah, yes, we need to add a readme file there stating about that.
>
> Greg, you may add it on your tree, or if you prefer, I can just add here for
> my next upstream pull.

I see this in my tree already, git commit
92ce52695ccf2b6c4ef7eb02e1bee1bcbf5fde89, what happened to need this
again?

confused,

greg k-h

2011-05-19 20:42:08

by Randy Dunlap

Subject: Re: Fw: [PATCH -next RESEND/still needed] staging: altera-jtag needs delay.h

On 05/19/11 13:39, Greg KH wrote:
> On Thu, May 19, 2011 at 04:22:06PM -0300, Mauro Carvalho Chehab wrote:
>> Em 28-03-2011 12:23, Randy Dunlap escreveu:
>>> From: Randy Dunlap <[email protected]>
>>>
>>> altera-jtag.c needs to include <linux/delay.h> to fix a build error:
>>>
>>> drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay'
>>>
>>> Signed-off-by: Randy Dunlap <[email protected]>
>> Acked-by: Mauro Carvalho Chehab <[email protected]>
>>
>>> Cc: Igor M. Liplianin <[email protected]>
>>> ---
>>> drivers/staging/altera-stapl/altera-jtag.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> Somehow I was supposed to know to send this to Mauro instead of to Greg,
>>> but I don't see anything in drivers/staging/altera-stapl/ that says that.
>>
>> Ah, yes, we need to add a readme file there stating about that.
>>
>> Greg, you may add it on your tree, or if you prefer, I can just add here for
>> my next upstream pull.
>
> I see this in my tree already, git commit
> 92ce52695ccf2b6c4ef7eb02e1bee1bcbf5fde89, what happened to need this
> again?

I think that Mauro is just replying to old emails (guess he's just
trying to catch up...).

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***