2011-05-24 05:41:09

by Justin P. Mattock

Subject: [PATCH v2]net:8021q:vlan.c Fix pr_info to just give the vlan fullname and version.

The below patch removes vlan_buggyright and vlan_copyright from vlan_proto_init,
so that it prints out just the fullname of vlan and the version number.

before:

[ 30.438203] 802.1Q VLAN Support v1.8 Ben Greear <[email protected]>
[ 30.441542] All bugs added by David S. Miller <[email protected]>

after:

[ 31.513910] 802.1Q VLAN Support v1.8

Signed-off-by: Justin P. Mattock <[email protected]>
CC: Joe Perches <[email protected]>
CC: David S. Miller <[email protected]>
CC: Ben Greear <[email protected]>
---
net/8021q/vlan.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index b2274d1..9df3fcb 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -673,8 +673,7 @@ static int __init vlan_proto_init(void)
{
int err;

- pr_info("%s v%s %s\n", vlan_fullname, vlan_version, vlan_copyright);
- pr_info("All bugs added by %s\n", vlan_buggyright);
+ pr_info("%s v%s\n", vlan_fullname, vlan_version);

err = register_pernet_subsys(&vlan_net_ops);
if (err < 0)
--
1.7.5.1

2011-05-24 05:46:07

by Eric Dumazet

Subject: Re: [PATCH v2]net:8021q:vlan.c Fix pr_info to just give the vlan fullname and version.

Le lundi 23 mai 2011 à 22:40 -0700, Justin P. Mattock a écrit :
> The below patch removes vlan_buggyright and vlan_copyright from vlan_proto_init,
> so that it prints out just the fullname of vlan and the version number.
>
> before:
>
> [ 30.438203] 802.1Q VLAN Support v1.8 Ben Greear <[email protected]>
> [ 30.441542] All bugs added by David S. Miller <[email protected]>
>
> after:
>
> [ 31.513910] 802.1Q VLAN Support v1.8
>
> Signed-off-by: Justin P. Mattock <[email protected]>
> CC: Joe Perches <[email protected]>
> CC: David S. Miller <[email protected]>
> CC: Ben Greear <[email protected]>
> ---
> net/8021q/vlan.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index b2274d1..9df3fcb 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -673,8 +673,7 @@ static int __init vlan_proto_init(void)
> {
> int err;
>
> - pr_info("%s v%s %s\n", vlan_fullname, vlan_version, vlan_copyright);
> - pr_info("All bugs added by %s\n", vlan_buggyright);
> + pr_info("%s v%s\n", vlan_fullname, vlan_version);
>
> err = register_pernet_subsys(&vlan_net_ops);
> if (err < 0)

This reminds me a discussion with Harald Welte in netfilter workshop
2010.

Sometime these strings help lot guys working to fight GPL violations.

2011-05-24 05:54:43

by Joe Perches

Subject: Re: [PATCH v2]net:8021q:vlan.c Fix pr_info to just give the vlan fullname and version.

On Tue, 2011-05-24 at 07:45 +0200, Eric Dumazet wrote:
> Le lundi 23 mai 2011 à 22:40 -0700, Justin P. Mattock a écrit :
> > The below patch removes vlan_buggyright and vlan_copyright from vlan_proto_init,
> > so that it prints out just the fullname of vlan and the version number.
[]
> > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> > - pr_info("%s v%s %s\n", vlan_fullname, vlan_version, vlan_copyright);
> > - pr_info("All bugs added by %s\n", vlan_buggyright);
> > + pr_info("%s v%s\n", vlan_fullname, vlan_version);
> >
> > err = register_pernet_subsys(&vlan_net_ops);
> > if (err < 0)
> This reminds me a discussion with Harald Welte in netfilter workshop
> 2010.
> Sometime these strings help lot guys working to fight GPL violations.

How so?

2011-05-24 06:21:53

by David Miller

Subject: Re: [PATCH v2]net:8021q:vlan.c Fix pr_info to just give the vlan fullname and version.

From: "Justin P. Mattock" <[email protected]>
Date: Mon, 23 May 2011 22:40:47 -0700

> The below patch removes vlan_buggyright and vlan_copyright from vlan_proto_init,
> so that it prints out just the fullname of vlan and the version number.

Come on Justin, you're making various strings now completely
unreferenced. Don't just leave them there, remove them.

2011-05-24 06:45:51

by Justin P. Mattock

Subject: Re: [PATCH v2]net:8021q:vlan.c Fix pr_info to just give the vlan fullname and version.

On 05/23/2011 11:21 PM, David Miller wrote:
> From: "Justin P. Mattock"<[email protected]>
> Date: Mon, 23 May 2011 22:40:47 -0700
>
>> The below patch removes vlan_buggyright and vlan_copyright from vlan_proto_init,
>> so that it prints out just the fullname of vlan and the version number.
>
> Come on Justin, you're making various strings now completely
> unreferenced. Don't just leave them there, remove them.
>

ah.. I did think, but was warry about removing them. resent with the
references removed(hopefully).

Justin P. Mattock