2011-05-24 08:42:46

by Nicolas Ferre

Subject: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value

at91sam9g20 is providing master clock to wm8731: not using a crystal but an
external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
we do not need oscillator to be powered.

Signed-off-by: Nicolas Ferre <[email protected]>
---
sound/soc/atmel/sam9g20_wm8731.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
index 28afbbf..95572d2 100644
--- a/sound/soc/atmel/sam9g20_wm8731.c
+++ b/sound/soc/atmel/sam9g20_wm8731.c
@@ -146,7 +146,7 @@ static int at91sam9g20ek_wm8731_init(struct snd_soc_pcm_runtime *rtd)
"at91sam9g20ek_wm8731 "
": at91sam9g20ek_wm8731_init() called\n");

- ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_XTAL,
+ ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_MCLK,
MCLK_RATE, SND_SOC_CLOCK_IN);
if (ret < 0) {
printk(KERN_ERR "Failed to set WM8731 SYSCLK: %d\n", ret);
--
1.7.3

2011-05-25 11:15:52

by Mark Brown

Subject: Re: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value

On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
> we do not need oscillator to be powered.
>
> Signed-off-by: Nicolas Ferre <[email protected]>

Adding Liam.

> ---
> sound/soc/atmel/sam9g20_wm8731.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 28afbbf..95572d2 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -146,7 +146,7 @@ static int at91sam9g20ek_wm8731_init(struct snd_soc_pcm_runtime *rtd)
> "at91sam9g20ek_wm8731 "
> ": at91sam9g20ek_wm8731_init() called\n");
>
> - ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_XTAL,
> + ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_MCLK,
> MCLK_RATE, SND_SOC_CLOCK_IN);
> if (ret < 0) {
> printk(KERN_ERR "Failed to set WM8731 SYSCLK: %d\n", ret);
> --
> 1.7.3
>

2011-05-25 12:21:54

by Liam Girdwood

Subject: Re: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value

On 25/05/11 12:15, Mark Brown wrote:
> On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
>> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
>> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
>> we do not need oscillator to be powered.
>>
>> Signed-off-by: Nicolas Ferre <[email protected]>
>
> Adding Liam.
>

Acked-by: Liam Girdwood <[email protected]>

2011-05-25 15:01:12

by Mark Brown

Subject: Re: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value

On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
> we do not need oscillator to be powered.
>
> Signed-off-by: Nicolas Ferre <[email protected]>

Applied, thanks.