2011-05-25 19:16:47

by Ondrej Zary

Subject: [bisected] 2.6.39 breaks floppy

Hello,
floppy stopped working in 2.6.39 (confirmed on two machines). 2.6.38 worked
fine.
/dev/fd0 is created but does not work (mdir says: "No such device or address",
mount says "/dev/fd0 is not a valid block device"). dmesg shows no errors:

Floppy drive(s): fd0 is 1.44M
FDC 0 is a post-1991 82077

Bisected it to 9fd097b14918875bd6f125ed699d7bbbba5893ee
(block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers)

Adding the removed line back to floppy.c fixes the problem.

--
Ondrej Zary

2011-05-25 19:37:40

by Jens Axboe

Subject: Re: [bisected] 2.6.39 breaks floppy

On 2011-05-25 21:16, Ondrej Zary wrote:
> Hello,
> floppy stopped working in 2.6.39 (confirmed on two machines). 2.6.38 worked
> fine.
> /dev/fd0 is created but does not work (mdir says: "No such device or address",
> mount says "/dev/fd0 is not a valid block device"). dmesg shows no errors:
>
> Floppy drive(s): fd0 is 1.44M
> FDC 0 is a post-1991 82077
>
> Bisected it to 9fd097b14918875bd6f125ed699d7bbbba5893ee
> (block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers)
>
> Adding the removed line back to floppy.c fixes the problem.

Tejun?

--
Jens Axboe

2011-05-25 20:54:23

by Tejun Heo

Subject: Re: [bisected] 2.6.39 breaks floppy

Hello,

On Wed, May 25, 2011 at 9:37 PM, Jens Axboe <[email protected]> wrote:
>> Bisected it to 9fd097b14918875bd6f125ed699d7bbbba5893ee
>> (block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers)
>>
>> Adding the removed line back to floppy.c fixes the problem.

It's the same one as the following. Patch posted. It's caused by
genhd->ev not allocated when ->events | async_events is empty.

https://bugzilla.kernel.org/show_bug.cgi?id=35832

Will soon post a patch.

Thanks.

--
tejun