2011-05-26 09:08:34

by Samuel Ortiz

Subject: [PATCH] regulator: Use device platform_data to retrieve db8500 platform bits

With the addition of a platform device mfd_cell pointer, MFD drivers
can go back to passing platform data back to their sub drivers.
This allows for an mfd_cell->mfd_data removal and thus keep the
sub drivers MFD agnostic. This is mostly needed for non MFD aware
sub drivers.

Signed-off-by: Samuel Ortiz <[email protected]>
---
drivers/regulator/db8500-prcmu.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/db8500-prcmu.c b/drivers/regulator/db8500-prcmu.c
index 1089a96..e5f7b8f 100644
--- a/drivers/regulator/db8500-prcmu.c
+++ b/drivers/regulator/db8500-prcmu.c
@@ -13,7 +13,6 @@
#include <linux/err.h>
#include <linux/spinlock.h>
#include <linux/platform_device.h>
-#include <linux/mfd/core.h>
#include <linux/mfd/db8500-prcmu.h>
#include <linux/regulator/driver.h>
#include <linux/regulator/machine.h>
@@ -471,7 +470,8 @@ static struct db8500_regulator_info

static int __devinit db8500_regulator_probe(struct platform_device *pdev)
{
- struct regulator_init_data *db8500_init_data = mfd_get_data(pdev);
+ struct regulator_init_data *db8500_init_data =
+ dev_get_platdata(&pdev->dev);
int i, err;

/* register all regulators */
--
1.7.2.3

--
Intel Open Source Technology Centre
http://oss.intel.com/

2011-05-26 09:34:08

by Liam Girdwood

Subject: Re: [PATCH] regulator: Use device platform_data to retrieve db8500 platform bits

On 26/05/11 10:08, Samuel Ortiz wrote:
> With the addition of a platform device mfd_cell pointer, MFD drivers
> can go back to passing platform data back to their sub drivers.
> This allows for an mfd_cell->mfd_data removal and thus keep the
> sub drivers MFD agnostic. This is mostly needed for non MFD aware
> sub drivers.
>
> Signed-off-by: Samuel Ortiz <[email protected]>

Acked-by: Liam Girdwood <[email protected]>

2011-05-28 12:13:36

by Mark Brown

Subject: Re: [PATCH] regulator: Use device platform_data to retrieve db8500 platform bits

On Thu, May 26, 2011 at 11:08:27AM +0200, Samuel Ortiz wrote:
> With the addition of a platform device mfd_cell pointer, MFD drivers
> can go back to passing platform data back to their sub drivers.
> This allows for an mfd_cell->mfd_data removal and thus keep the
> sub drivers MFD agnostic. This is mostly needed for non MFD aware
> sub drivers.
>
> Signed-off-by: Samuel Ortiz <[email protected]>

Acked-by: Mark Brown <[email protected]>

Please always CC maintainers on patches!