2011-05-26 02:54:20

by Axel Lin

Subject: [PATCH] ASoC: wm1250-ev1: Define "WM1250 Output" with SND_SOC_DAPM_OUTPUT

Codec output pin should be defined with SND_SOC_DAPM_OUTPUT.

Signed-off-by: Axel Lin <[email protected]>
---
Note:
Just found this bug while reading the code.
I don't have this hardware handy. I appreciate if someone can test it.

Axel

sound/soc/codecs/wm1250-ev1.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm1250-ev1.c b/sound/soc/codecs/wm1250-ev1.c
index 14d0716..bcc2089 100644
--- a/sound/soc/codecs/wm1250-ev1.c
+++ b/sound/soc/codecs/wm1250-ev1.c
@@ -22,7 +22,7 @@ SND_SOC_DAPM_ADC("ADC", "wm1250-ev1 Capture", SND_SOC_NOPM, 0, 0),
SND_SOC_DAPM_DAC("DAC", "wm1250-ev1 Playback", SND_SOC_NOPM, 0, 0),

SND_SOC_DAPM_INPUT("WM1250 Input"),
-SND_SOC_DAPM_INPUT("WM1250 Output"),
+SND_SOC_DAPM_OUTPUT("WM1250 Output"),
};

static const struct snd_soc_dapm_route wm1250_ev1_dapm_routes[] = {
--
1.7.1

2011-05-26 11:04:15

by Liam Girdwood

Subject: Re: [PATCH] ASoC: wm1250-ev1: Define "WM1250 Output" with SND_SOC_DAPM_OUTPUT

On 26/05/11 03:54, Axel Lin wrote:
> Codec output pin should be defined with SND_SOC_DAPM_OUTPUT.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> Note:
> Just found this bug while reading the code.
> I don't have this hardware handy. I appreciate if someone can test it.
>
> Axel
>

The fix does look correct.

Acked-by: Liam Girdwood <[email protected]>

2011-05-26 14:18:33

by Mark Brown

Subject: Re: [PATCH] ASoC: wm1250-ev1: Define "WM1250 Output" with SND_SOC_DAPM_OUTPUT

On Thu, May 26, 2011 at 10:54:12AM +0800, Axel Lin wrote:
> Codec output pin should be defined with SND_SOC_DAPM_OUTPUT.

Applied, thanks.