2011-05-30 18:45:53

by Németh Márton

[permalink] [raw]
Subject: [PATCH] musb_host: compare status for negative error values

From: Márton Németh <[email protected]>

Variable d is a struct usb_iso_packet_descriptor. The status filed is usually
negative when an error happens.

Signed-off-by: Márton Németh <[email protected]>
---

This was not tested at all! I just found this while I was browsing the
code and it looked like a typo. Please verify and test it before aplying
this patch. If I was wrong, sorry about that.

---
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 7295e31..8b2473f 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -1575,7 +1575,7 @@ void musb_host_rx(struct musb *musb, u8 epnum)
/* even if there was an error, we did the dma
* for iso_frame_desc->length
*/
- if (d->status != EILSEQ && d->status != -EOVERFLOW)
+ if (d->status != -EILSEQ && d->status != -EOVERFLOW)
d->status = 0;

if (++qh->iso_idx >= urb->number_of_packets)


2011-06-07 10:27:46

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH] musb_host: compare status for negative error values

On Mon, May 30, 2011 at 08:45:42PM +0200, N?meth M?rton wrote:
> From: M?rton N?meth <[email protected]>
>
> Variable d is a struct usb_iso_packet_descriptor. The status filed is usually
> negative when an error happens.
>
> Signed-off-by: M?rton N?meth <[email protected]>

applied to fixes branch. Thanks

--
balbi


Attachments:
(No filename) (320.00 B)
signature.asc (490.00 B)
Digital signature
Download all attachments