2011-06-09 15:06:43

by Mark Brown

Subject: [PATCH] regulator: Add rdev_crit() macro

No actual users but provide the macro so there's less surprise when it's
not there.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 47bf85d..f5e4665 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -34,6 +34,8 @@

#include "dummy.h"

+#define rdev_crit(rdev, fmt, ...) \
+ pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
#define rdev_err(rdev, fmt, ...) \
pr_err("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
#define rdev_warn(rdev, fmt, ...) \
--
1.7.5.3

2011-06-09 18:15:28

by Liam Girdwood

Subject: Re: [PATCH] regulator: Add rdev_crit() macro

On 09/06/11 16:06, Mark Brown wrote:
> No actual users but provide the macro so there's less surprise when it's
> not there.
>
> Signed-off-by: Mark Brown <[email protected]>
>
Applied.

Thanks

Liam

2011-06-09 18:37:20

by Joe Perches

Subject: Re: [PATCH] regulator: Add rdev_crit() macro

On Thu, 2011-06-09 at 16:06 +0100, Mark Brown wrote:
> No actual users but provide the macro so there's less surprise when it's
> not there.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/regulator/core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 47bf85d..f5e4665 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -34,6 +34,8 @@
>
> #include "dummy.h"
>
> +#define rdev_crit(rdev, fmt, ...) \
> + pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
> #define rdev_err(rdev, fmt, ...) \
> pr_err("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
> #define rdev_warn(rdev, fmt, ...) \

If that's really necessary, shouldn't rdev_emerg, rdev_alert
and rdev_notice be added as well?

2011-06-09 19:09:30

by Mark Brown

Subject: Re: [PATCH] regulator: Add rdev_crit() macro

On Thu, Jun 09, 2011 at 11:37:15AM -0700, Joe Perches wrote:

> > +#define rdev_crit(rdev, fmt, ...) \
> > + pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)

> If that's really necessary, shouldn't rdev_emerg, rdev_alert
> and rdev_notice be added as well?

Yes, but I don't habitually use those when adding random trace during
debug so don't care myself.